ref(react)!: Remove redundant url.path.params.<key> attribute - #23506
Merged
Merged
Conversation
Lms24
requested review from
chargome and
nicohrubec
and removed request for
a team
August 24, 2026 09:10
nicohrubec
approved these changes
Aug 24, 2026
Lms24
force-pushed
the
lms/ref-react-remove-url.path.params
branch
from
August 24, 2026 09:17
226698c to
f7135d0
Compare
Contributor
size-limit report 📦
|
JPeer264
pushed a commit
that referenced
this pull request
Aug 25, 2026
This PR removes the undocumented `url.path.params.<key>` in favour of the already set and [documented](https://getsentry.github.io/sentry-conventions/attributes/url/#url-path-parameter-key) `url.path.parameter.<key>` attribute.
JPeer264
added a commit
to getsentry/sentry-conventions
that referenced
this pull request
Aug 27, 2026
…f `url.path.parameter.<key>` The JavaScript SDK's TanStack Router integration emitted `url.path.params.<key>` and removed it in v11. It holds the same values as `url.path.parameter.<key>`, so it joins that attribute's alias group next to the existing `params.<key>`. Deprecated by getsentry/sentry-javascript#23506 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
JPeer264
added a commit
to getsentry/sentry-conventions
that referenced
this pull request
Aug 27, 2026
…f `url.path.parameter.<key>` The JavaScript SDK's TanStack Router integration emitted `url.path.params.<key>` and removed it in v11. It holds the same values as `url.path.parameter.<key>`, so it joins that attribute's alias group next to the existing `params.<key>`. Deprecated by getsentry/sentry-javascript#23506 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
JPeer264
added a commit
to getsentry/sentry-conventions
that referenced
this pull request
Aug 27, 2026
…f `url.path.parameter.<key>` The JavaScript SDK's TanStack Router integration emitted `url.path.params.<key>` and removed it in v11. It holds the same values as `url.path.parameter.<key>`, so it joins that attribute's alias group next to the existing `params.<key>`. Deprecated by getsentry/sentry-javascript#23506 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
JPeer264
added a commit
to getsentry/sentry-conventions
that referenced
this pull request
Aug 28, 2026
…f `url.path.parameter.<key>` The JavaScript SDK's TanStack Router integration emitted `url.path.params.<key>` and removed it in v11. It holds the same values as `url.path.parameter.<key>`, so it joins that attribute's alias group next to the existing `params.<key>`. Deprecated by getsentry/sentry-javascript#23506 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
JPeer264
added a commit
to getsentry/sentry-conventions
that referenced
this pull request
Aug 28, 2026
…f `url.path.parameter.<key>` (#586) The JavaScript SDK's TanStack Router integration emitted `url.path.params.<key>` and removed it in v11. It holds the same values as `url.path.parameter.<key>`, so it joins that attribute's alias group next to the existing `params.<key>`. Deprecated by getsentry/sentry-javascript#23506 Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the undocumented
url.path.params.<key>in favour of the already set and documentedurl.path.parameter.<key>attribute.