feat(attributes): Add url.path.params.<key> (deprecated) in favor of url.path.parameter.<key> - #586
Merged
Conversation
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Other
Bug Fixes 🐛Names
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
JPeer264
force-pushed
the
jp/conv-url-path-params
branch
from
August 27, 2026 08:17
dc422a0 to
19ac720
Compare
JPeer264
marked this pull request as ready for review
August 27, 2026 08:51
JPeer264
requested review from
a team,
Lms24,
cleptric,
mjq and
nsdeschenes
as code owners
August 27, 2026 08:51
loewenheim
approved these changes
Aug 27, 2026
JPeer264
force-pushed
the
jp/conv-url-path-params
branch
from
August 27, 2026 09:26
19ac720 to
c3c3a47
Compare
Lms24
approved these changes
Aug 27, 2026
Member
|
This change LGTM!
sorry, which PR is that? |
JPeer264
force-pushed
the
jp/conv-url-path-params
branch
2 times, most recently
from
August 27, 2026 16:30
420e7c9 to
99a815b
Compare
JPeer264
changed the base branch from
jp/conv-service-namespace
to
jp/conv-graphql-source
August 27, 2026 16:30
Member
Author
The one which is linked below: getsentry/sentry-javascript#23506 |
JPeer264
force-pushed
the
jp/conv-url-path-params
branch
from
August 27, 2026 16:49
99a815b to
16027df
Compare
JPeer264
force-pushed
the
jp/conv-url-path-params
branch
from
August 28, 2026 11:49
16027df to
f10b538
Compare
…f `url.path.parameter.<key>` The JavaScript SDK's TanStack Router integration emitted `url.path.params.<key>` and removed it in v11. It holds the same values as `url.path.parameter.<key>`, so it joins that attribute's alias group next to the existing `params.<key>`. Deprecated by getsentry/sentry-javascript#23506 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
JPeer264
force-pushed
the
jp/conv-url-path-params
branch
from
August 28, 2026 12:12
f10b538 to
f81ff0a
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JavaScript SDK's TanStack Router integration emitted
url.path.params.<key>and removed it in v11. It holds the same values asurl.path.parameter.<key>, so it joins that attribute's alias group next to the existingparams.<key>.The original PR said
This PR removes the undocumentedso it would be interesting if this PR would still apply @Lms24Deprecated by getsentry/sentry-javascript#23506