Skip to content

feat(attributes): Add url.path.params.<key> (deprecated) in favor of url.path.parameter.<key> - #586

Merged
JPeer264 merged 1 commit into
jp/conv-graphql-sourcefrom
jp/conv-url-path-params
Aug 28, 2026
Merged

JPeer264 merged 1 commit into
jp/conv-graphql-sourcefrom
jp/conv-url-path-params

Conversation

@JPeer264

@JPeer264 JPeer264 commented Aug 27, 2026 •

Copy link
Copy Markdown
Member

The JavaScript SDK's TanStack Router integration emitted url.path.params.<key> and removed it in v11. It holds the same values as url.path.parameter.<key>, so it joins that attribute's alias group next to the existing params.<key>.

The original PR said This PR removes the undocumented so it would be interesting if this PR would still apply @Lms24

Deprecated by getsentry/sentry-javascript#23506

@github-actions

github-actions Bot commented Aug 27, 2026 •

Copy link
Copy Markdown

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

Attributes

  • Add url.path.params.<key> (deprecated) in favor of url.path.parameter.<key> by JPeer264 in #586
  • Add graphql.source (deprecated) in favor of graphql.document by JPeer264 in #584
  • Add legacy Vercel AI span attributes (deprecated) by JPeer264 in #583
  • Add legacy AMQP and Redis span attributes (deprecated) by JPeer264 in #581
  • Add HTTP body size and status text attributes by msonnb in #574
  • Add graphql.processing.type by andreiborza in #572

Other

  • (span-names) Add url.domainrule for http.client spans by Lms24 in #575

Bug Fixes 🐛

Names

  • Add gen_ai.function_id and gen_ai.pipeline.name to agent span name templates by RulaKhaled in #593
  • Add missing gen_ai ops to span name rules by Lms24 in #579
  • Include tool name in gen_ai.execute_tool span names by Lms24 in #580
  • Correct graphql span name examples by andreiborza in #573

Internal Changes 🔧

  • (attributes) Add search alias for segment name by nsdeschenes in #577
  • (search-metadata) Add visibility field by nsdeschenes in #597

🤖 This preview updates automatically when you update the PR.

@JPeer264
JPeer264 force-pushed the jp/conv-url-path-params branch from dc422a0 to 19ac720 Compare August 27, 2026 08:17
@JPeer264
JPeer264 marked this pull request as ready for review August 27, 2026 08:51
@JPeer264
JPeer264 requested review from a team, Lms24, cleptric, mjq and nsdeschenes as code owners August 27, 2026 08:51
@JPeer264
JPeer264 force-pushed the jp/conv-url-path-params branch from 19ac720 to c3c3a47 Compare August 27, 2026 09:26
@Lms24

Lms24 commented Aug 27, 2026

Copy link
Copy Markdown
Member

This change LGTM!

The original PR said This PR removes the undocumented so it would be interesting if this PR would still apply @Lms24

sorry, which PR is that?

@JPeer264
JPeer264 force-pushed the jp/conv-url-path-params branch 2 times, most recently from 420e7c9 to 99a815b Compare August 27, 2026 16:30
@JPeer264
JPeer264 requested a review from a team as a code owner August 27, 2026 16:30
@JPeer264
JPeer264 changed the base branch from jp/conv-service-namespace to jp/conv-graphql-source August 27, 2026 16:30
@JPeer264

JPeer264 commented Aug 27, 2026 •

Copy link
Copy Markdown
Member Author

sorry, which PR is that?

The one which is linked below: getsentry/sentry-javascript#23506
Just wondering if undocumented attributes should still be deprecated

@JPeer264
JPeer264 force-pushed the jp/conv-url-path-params branch from 99a815b to 16027df Compare August 27, 2026 16:49
@JPeer264
JPeer264 force-pushed the jp/conv-url-path-params branch from 16027df to f10b538 Compare August 28, 2026 11:49
…f `url.path.parameter.<key>`

The JavaScript SDK's TanStack Router integration emitted
`url.path.params.<key>` and removed it in v11. It holds the same values as
`url.path.parameter.<key>`, so it joins that attribute's alias group next to
the existing `params.<key>`.

Deprecated by getsentry/sentry-javascript#23506

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@JPeer264
JPeer264 force-pushed the jp/conv-url-path-params branch from f10b538 to f81ff0a Compare August 28, 2026 12:12
@JPeer264
JPeer264 merged commit d21475f into main Aug 28, 2026
16 checks passed
@JPeer264
JPeer264 deleted the jp/conv-url-path-params branch August 28, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants