Skip to content

fix(dashboard): Serve empty Review item reads in mock reporting mode #2476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcramer merged 1 commit into from
Oct 31, 2026
Merged

fix(dashboard): Serve empty Review item reads in mock reporting mode #2476

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions packages/junior-dashboard/src/mock-reporting/routes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ import {
personalSpendReportSchema,
personParamsSchema,
pluginOperationalReportFeedSchema,
reviewItemCountSchema,
reviewItemListSchema,
reviewItemWaitingConversationsSchema,
automationExecutionListSchema,
automationListSchema,
automationParamsSchema,
Expand Down Expand Up @@ -294,6 +297,23 @@ export function createMockReportingApi(): Hono<{
}
return errorResponse("Attachment not found.", 404);
});
// Mock reporting has no Review items. Answer the reads here so the
// dashboard does not query a database that has no review item tables.
app.get("/review-items", () =>
jsonResponse(reviewItemListSchema, { items: [] }),
);
app.get("/review-items/count", () =>
jsonResponse(reviewItemCountSchema, { mine: 0 }),
);
app.get("/review-items/waiting-conversations", () =>
jsonResponse(reviewItemWaitingConversationsSchema, { conversationIds: [] }),
);
app.get("/review-items/:id", () =>
errorResponse("Review item not found.", 404),
);
app.post("/review-items/:id/actions", () =>
errorResponse("Review item not found.", 404),
);
app.get("/automations", (c) => {
const report = readMockAutomationList();
return jsonResponse(
Expand Down
Loading