Repository navigation
fix(dashboard): Serve empty Review item reads in mock reporting mode - #2476
Merged
Merged
Conversation
Mock reporting mode had no review item routes, so the nav count, the waiting dot and the Conversation bar fell through to the real API. That API queried a database with no review item tables and returned 500s. The dashboard e2e logs had about 300 'Failed query' errors per run. Mock mode has no Review items, so the reads return empty results and a single item or an action returns 404. Co-Authored-By: David Cramer <david@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
2 screenshot changes — 2 changed · 0 added · 0 removed Review screenshots in Frameshift
|
dcramer
approved these changes
Oct 31, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mock reporting mode had no review item routes. The nav count, the waiting dot and the Conversation bar fell through to the real API. That API then queried a database with no review item tables and returned 500s. Each dashboard e2e run logged about 300
Failed query ... relation "junior_review_items" does not existerrors.Mock mode has no Review items, so
createMockReportingApinow answers:GET /api/review-items: an empty listGET /api/review-items/count:{ mine: 0 }GET /api/review-items/waiting-conversations: no ConversationsGET /api/review-items/:idandPOST /api/review-items/:id/actions: 404Checks: dashboard typecheck passes. I ran the full dashboard e2e suite locally against an empty database. The count went from about 300
Failed queryerrors to 2, and those 2 are thejunior_automationsquery that was already there before the review desk. 59 of 60 tests passed. The one failure was apending-messagesrequest timeout inconversations-event-log.spec.ts, which doesn't touch review items, and it passed 4/4 when I ran it again.This adds no fixture items, so mock mode shows an empty review desk. Related: #2474 fixes the
conversation-sharetimeout.via David Cramer.
--
View Session [Sentry]