Repository navigation
feat(dashboard): Polish user input controls and the review desk action pane - #2475
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
2 screenshot changes — 2 changed · 0 added · 0 removed Review screenshots in Frameshift
|
…n pane Show each choice as a selectable row with clear hover, focus, and selected states, using the shared Base UI radio and checkbox. Give fields real labels and spacing. Keep Send or Done as the main action and make Take and Dismiss quiet secondary actions in the same row. Show the status in the detail header, the description in the side panel card, and plain empty states. Co-Authored-By: David Cramer <david@sentry.io>
Key the review item detail by item id. Before, choices, Other text, and the send lock stayed when the reader picked another item, so a send could carry the previous answer and a sent answer disabled the next form. Co-Authored-By: David Cramer <david@sentry.io>
Read each linked Conversation with a one-event detail request and show its title. Keep the id as the link title, and as the label when the viewer cannot read the Conversation. Co-Authored-By: David Cramer <david@sentry.io>
sentry-junior
Bot
force-pushed
the
feat/review-desk-form-polish
branch
from
October 31, 2026 04:17
10481f5 to
02d5ba9
Compare
dcramer
approved these changes
Oct 31, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Polish the shared
requestUserInputanswer form and the review desk detail pane. Also fix the form state that carried over between review items (Cursor finding on #2464).Visual changes
UserInputFormnow uses the shared Base UIRadioGroupItemandCheckboxin place of native inputs. Each option is a whole bordered row with hover, focus and selected states (accent border and tint). The transcript ask card, the side panel card and the review desk all get it.Field/FieldLabel/FieldDescription. Labels are semibold, with more space between fields and taller textareas. "Other" is marked optional.Button variant="quiet"and sit right-aligned in the same row. Before, all of them looked the same. The new variant is documented incomponents/README.md.slack:C…ids. Each title comes from the existing detail endpoint with?limit=1. If the viewer cannot read a Conversation, it falls back to the monospace id, and the id stays as the linktitle.EmptyTelemetrybox inside a card.Fix: form state carried over between review items
ReviewItemDetailwas not keyed by item. So choices, Other text, errors and the send lock stayed when the reader picked another item. A send could post the previous item's answer, and a sent answer left the next item's form disabled. It is now keyed byitem.id. The newe2e/review-desk.spec.tscovers this journey: pick a choice, switch items, check the form is clean, answer one item, then answer another.Verification
pnpm typecheck,pnpm lintandpnpm dashboard-style:checkpassed.No API, Conversations page or Slack card change.
--
View Session [Sentry]