Repository navigation
feat(review-desk): Add the review desk page - #2464
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This comment has been minimized.
This comment has been minimized.
sentry-junior
Bot
force-pushed
the
feat/review-desk-page
branch
from
October 31, 2026 00:38
7ad2305 to
7a5a14a
Compare
sentry-junior
Bot
force-pushed
the
feat/review-desk-page
branch
from
October 31, 2026 01:57
7a5a14a to
be0d368
Compare
sentry-junior
Bot
force-pushed
the
feat/review-desk-page
branch
from
October 31, 2026 02:11
be0d368 to
2c50343
Compare
dcramer
force-pushed
the
feat/review-desk-page
branch
from
October 31, 2026 02:35
56e0450 to
adb5a1b
Compare
sentry-junior
Bot
force-pushed
the
feat/review-desk-page
branch
from
October 31, 2026 02:40
adb5a1b to
3c383ab
Compare
dcramer
approved these changes
Oct 31, 2026
…gnees across runs Follow-up to review feedback on #2460, which merged first. - The open dedupe index was global, so one workspace could block a key, such as pr:7, for every other workspace. A new migration scopes the index to the provider tenant, and the lookup filters by tenant. - A private item checked assignees only against the current Conversation. A later run of the same Automation could not keep the people of the run that added the item. The check now also accepts people in the Conversation that added the item. Co-Authored-By: David Cramer <david@sentry.io>
Add Review desk to the dashboard nav, second after Conversations, with the count of open items assigned to the viewer. The page lists open or archived items in the Mine, Everyone, and All views, grouped into items that need an answer, notices, and blocked Automations. The selected item shows its facts and the actions the viewer can take. Move the requestUserInput form into UserInputForm so the review desk submits the same form with a structured answer. Refs #2401 Co-Authored-By: David Cramer <david@sentry.io>
Co-Authored-By: David Cramer <david@sentry.io>
…em in its view Visual QA found five review desk problems: - The answer form scrolled inside a fixed height, so Send was hidden. Only the composer card needs that limit, so it now owns it. - The request question showed raw markdown. - A closed item showed the agent answer text, with the internal request id. It now shows one line for each answered field. - A tab change kept an item that was not in the new list. A tab change now clears the selection. - Item links dropped the view and state, so a click on an archived item moved the desk back to Open. Archived actions are listed as Questions, not Needs an answer. Co-Authored-By: David Cramer <david@sentry.io>
dcramer
marked this pull request as ready for review
October 31, 2026 02:46
sentry-junior
Bot
force-pushed
the
feat/review-desk-page
branch
from
October 31, 2026 02:50
3c383ab to
3d3bf46
Compare
Contributor
|
57 screenshot changes — 57 changed · 0 added · 0 removed Review screenshots in Frameshift
Show 12 more changed screenshots
39 more changed screenshots in Frameshift. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3d3bf46. Configure here.
dcramer
added a commit
that referenced
this pull request
Oct 31, 2026
Part 4 of the review desk stack for #2401. Stacked on #2464. - **Transcript card:** when the agent adds an item (`addReviewItem`, directly or through `executeTool`), the transcript shows a review card under that tool call. The tool row stays out of the collapsed activity group so the card is visible. The card has the same actions as the review desk, shows who closed it and the answer once closed, and links to the item on the review desk. A viewer who cannot act sees it without the form; a viewer who cannot see the item sees nothing. The card needs the tool result, so a transcript that hides tool payloads shows no inline card (the bar still covers it). - **Bar + side panel:** while a Conversation has open linked items, a bar above the message box shows how many. It opens a side panel with a card per item. - **"Waiting on you" dot:** `GET /api/review-items/waiting-conversations` lists Conversations with an open linked item assigned to the viewer or Everyone. Unassigned items do not count. The sidebar, home list, and repository list show a lavender dot for them, and it replaces the other status markers. No layout changes. Tests: `/waiting-conversations` cases in `tests/integration/api/review-items/actions.test.ts`, and a unit test for the tool call parser (`tests/review-item-tool-call.test.ts`). The Slack card follows in the next PR. <!-- junior-request-attribution:start --> via **David Cramer**. <!-- junior-request-attribution:end --> <!-- junior-session-footer:start --> <!-- junior-conversation-id:slack%3AC0AHB7N2JCR%3A1793326028.695969 --> -- [View Session](https://junior-prod.sentry.dev/conversations/slack%3AC0AHB7N2JCR%3A1793326028.695969) [[Sentry]](https://sentry.sentry.io/explore/conversations/slack%3AC0AHB7N2JCR%3A1793326028.695969/?project=4510944073809921) <!-- junior-session-footer:end --> --------- Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> Co-authored-by: David Cramer <david@sentry.io>
This was referenced Oct 31, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 3 of the review desk stack for #2401. Stacked on #2462.
/api/review-items/count, refreshed every minute). Unassigned items do not count./review): item list on the left, selected item on the right (?item=<id>). Mine / Everyone / All views, an Open / Archived filter that uses the same views, and search. The list groups items into "Needs an answer", "Notices", and "Blocked Automations". Blocked Automations come from the viewer's Automations with statusblocked; they are not stored as items. Unassigned items show only in All, with an "Unassigned" label.requestUserInputform moves fromUserInputRequestCardintocomponents/UserInputForm.tsx. The transcript card still sends the formatted answer as a message. The review desk submits the structured answer.ReviewItemActionswill also back the transcript card and side panel in the next PR.No new automated tests: the page is UI composition over the API that #2462 tests. Visual QA follows on the top PR.
via David Cramer.
--
View Session [Sentry]