Repository navigation
Description
Is your feature request related to a problem? Please describe.
Plumber reads .github/workflows/actions.lock and counts locked refs as pinned (#542), but it trusts what the lockfile says. It doesn't check that a locked commit actually belongs to the action repository at that ref, or that owner_id / repo_id still match. The github/actions-lockfile parser leaves that to the caller: Parse "does not verify pin integrity or that actions exist on GitHub; those checks belong to the caller".
gh actions-lock --verify does those checks. Its README describes it as "the same checks as a fix run", which "checks provenance before merge". We already run it in this repository's CI (.github/workflows/verify-lockfile.yml, #568). A repository that runs the Plumber action would otherwise have to set up a separate workflow to get this check.
Describe the solution you'd like
Add a step to action.yml that runs gh actions-lock --verify on the checked-out repository. It is on by default: the goal is to get users of the action onto workflow lockfiles.
- New input
verify-lockfile, defaulttrue.verify-lockfile: falseopts out. - New input
actions-lock-versionwith a pinned gh-actions-lock release as the default (currently0.4.1). The extension is installed withgh extension install github/gh-actions-lock --pin <version>, as inverify-lockfile.yml. - A repository without
.github/workflows/actions.lockgets a warning and the job continues. The warning explains how to create one (gh extension install github/gh-actions-lock && gh actions-lock) and how to opt out. - A verification failure fails the job.
soft-faildoesn't mask a verification failure (the same rule as exit 3). The job summary gets a line with the result. SARIF and artifacts are still uploaded.- With
projectset (remote scan, no checkout), there are no local files to verify. The step is skipped with a warning. - The step uses the
github-tokeninput asGH_TOKEN, like the install step does forgh attestation verify.
Opting out:
- uses: getplumber/plumber@vX
with:
verify-lockfile: falseImplementation Hints
- This belongs in the composite action, not in
plumber analyze, since analysis runs no external binaries (Remove gitleaks integration completely #310). The action already shells out toghforgh attestation verify. - README and action docs: document the two inputs and say that
--verifyneeds network access to the action repositories. - Test on the lock-file-consumer lab repository: a valid lockfile passes, a tampered
commitfails, a missing lockfile warns and the job continues,verify-lockfile: falseskips the step, andprojectis skipped with a warning.
Why It's Valuable
With this on by default, the Plumber action checks, in the same job, that the repository's locked action commits come from the repositories they claim to come from, instead of trusting the lockfile as written. Users get the provenance check without maintaining a separate verify workflow, and repositories without a lockfile get a warning that tells them how to adopt one.
References
- Workflow dependency lockfiles: https://docs.github.com/en/actions/concepts/security/workflow-dependency-lockfiles
- gh-actions-lock modes: https://github.com/github/gh-actions-lock#modes
- Lockfile parser: https://github.com/github/actions-lockfile
- Related: Read GitHub workflow lockfiles (.github/workflows/actions.lock): locked refs count as pinned in ISSUE-701, lockfile consistency control, resolve the locked commit in 702/703 #542, Adopt and enforce workflow lockfiles on this repository #568
Activity
thomasboni commentedon Nov 3, 2026
@Exypte seems good !
One question: why do we disable
verify-lockfileby default ? If a lock file is present, do we have any reason to not enable it ?Exypte commentedon Nov 4, 2026
I'm working on this one, a fix is on the way.
Exypte commentedon Nov 4, 2026
@thomasboni Agreed, no good reason. It'll be on by default, and a repository without
.github/workflows/actions.lockfails the job too: the goal is to get users onto workflow lockfiles.verify-lockfile: falseopts out. I'll update the issue description.[-]Plumber action: opt-in `gh actions-lock --verify` step for the caller's workflow lockfile[/-][+]Plumber action: verify the caller's workflow lockfile with `gh actions-lock --verify` (on by default)[/+]feat(action)!: verify the workflow lockfile with gh actions-lock --ve…
feat(action): verify the workflow lockfile with gh actions-lock --ver…
Exypte commentedon Nov 5, 2026
@thomasboni Change from my last comment: a repository without
.github/workflows/actions.locknow gets a warning and the job continues. A lockfile that doesn't verify still fails the job.verify-lockfilestays on by default, and I've updated the issue description.feat(action): verify the workflow lockfile with gh actions-lock --ver…