Skip to content

Adopt and enforce workflow lockfiles on this repository #568

Closed

Description

@Exypte

Is your feature request related to a problem? Please describe.

Plumber reads GitHub workflow lockfiles (#542, follow-ups in #545), but this repository has none. Our workflows pin every action to a commit SHA, but those pins have gaps:

  • nothing checks that the repository behind a name is still the one we pinned (the lockfile stores owner_id / repo_id and GitHub checks them at run time),
  • nothing pins the actions our actions call (the lockfile records transitive dependencies),
  • nothing enforces them: a new workflow or a new step with @v1 runs without complaint.

Describe the solution you'd like

Onboard every workflow in .github/workflows/ to .github/workflows/actions.lock, then turn on the Require lockfile workflow execution policy so a workflow the lockfile doesn't cover can't run.

Onboarding (one PR)

  • gh extension install github/gh-actions-lock, then run gh actions-lock from the repository root to cover all 10 workflows.
  • Review the whole diff: the extension also rewrites uses: refs (to exact versions, and ./… to $/…, e.g. the ./.github/workflows/propagate.yml call in release.yml). Decide whether to keep the SHA pins with their # vX comments or let the lockfile hold the pins.
  • Add .github/workflows/actions.lock to CODEOWNERS and require code owner review for it.
  • Add a verify job that runs gh actions-lock --verify on pull requests and make it a required check. Optional: a pre-commit hook with gh actions-lock --verify-local --no-fix.
  • Check that Dependabot (github-actions ecosystem, already in .github/dependabot.yml) regenerates the lockfile entry in its bump PRs. It doesn't onboard new workflows, so a new workflow needs gh actions-lock by hand.
  • Check the org/repo allowed-actions list: tag-based entries (owner/action@v1) no longer match locked SHAs, so use a wildcard or a full SHA.
  • Dogfooding: the plumber-action.yml run on this repository should report the locked refs as pinned (Read GitHub workflow lockfiles (.github/workflows/actions.lock): locked refs count as pinned in ISSUE-701, lockfile consistency control, resolve the locked commit in 702/703 #542).

Enforcement (after the onboarding PR is merged)

  • Settings → Actions → Policies → new workflow execution policy → Require lockfile, at org level if possible, otherwise on this repository. Set it to Active: Evaluate mode only exists on GitHub Enterprise Cloud.
  • Target this repository and every onboarded workflow.
  • Check it works: on a scratch branch, a workflow (or step) missing from the lockfile must be blocked.

Notes

  • The feature is in public preview and may change.
  • Turn the policy on only after the lockfile is on main, or runs that aren't onboarded yet get blocked.
  • Lockfile changes are dependency changes: a changed commit is new code that will run, and a changed owner_id / repo_id needs a look before merging. Never edit the file by hand.

References

Activity

  1. self-assigned this
    on Oct 22, 2026
  2. Exypte commented on Oct 22, 2026

    @Exypte
    ContributorAuthor

    I'm working on this one, a fix is on the way.

  3. added theissue type on Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions