Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Make the AndroidContext superclass destructor virtual#22555

Merged
iskakaushik merged 1 commit intoflutter:masterfrom
jason-simmons:bug_70621
Nov 16, 2020
Merged

Make the AndroidContext superclass destructor virtual#22555
iskakaushik merged 1 commit intoflutter:masterfrom
jason-simmons:bug_70621

Conversation

@jason-simmons
Copy link
Copy Markdown
Member

Also remove an obsolete external_view_embedder reference from
AndroidSurfaceFactoryImpl.

Fixes flutter/flutter#70621

Also remove an obsolete external_view_embedder reference from
AndroidSurfaceFactoryImpl.

Fixes flutter/flutter#70621
Copy link
Copy Markdown
Contributor

@iskakaushik iskakaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iskakaushik iskakaushik merged commit 635df89 into flutter:master Nov 16, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 17, 2020
chaselatta pushed a commit to chaselatta/engine that referenced this pull request Nov 30, 2020
Also remove an obsolete external_view_embedder reference from
AndroidSurfaceFactoryImpl.

Fixes flutter/flutter#70621
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression in memory benchmarks...

2 participants