Skip to content

Commit a2dd33c

Browse files
jason-simmonschaselatta
authored andcommitted
Make the AndroidContext superclass destructor virtual (flutter#22555)
Also remove an obsolete external_view_embedder reference from AndroidSurfaceFactoryImpl. Fixes flutter/flutter#70621
1 parent 3a5b67c commit a2dd33c

2 files changed

Lines changed: 1 addition & 2 deletions

File tree

shell/platform/android/context/android_context.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ class AndroidContext {
2222
public:
2323
explicit AndroidContext(AndroidRenderingAPI rendering_api);
2424

25-
~AndroidContext();
25+
virtual ~AndroidContext();
2626

2727
AndroidRenderingAPI RenderingApi() const;
2828

shell/platform/android/platform_view_android.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ class AndroidSurfaceFactoryImpl : public AndroidSurfaceFactory {
3535
private:
3636
const AndroidContext& android_context_;
3737
std::shared_ptr<PlatformViewAndroidJNI> jni_facade_;
38-
std::weak_ptr<AndroidExternalViewEmbedder> external_view_embedder_;
3938
};
4039

4140
class PlatformViewAndroid final : public PlatformView {

0 commit comments

Comments
 (0)