Skip to content

[Route] Add route for IDP account sync information - #49975

Merged
melpike merged 1 commit into
mainfrom
melpike-patch-8
Jul 27, 2026
Merged

[Route] Add route for IDP account sync information#49975
melpike merged 1 commit into
mainfrom
melpike-patch-8

Conversation

@melpike

@melpike melpike commented Jul 27, 2026

Copy link
Copy Markdown
Member

Related issue: Resolves #45524

Summary by CodeRabbit

  • Documentation
    • Added a redirect from the IDP account sync information page to the Apple account provisioning deployment guide.

@fleet-release
fleet-release requested a review from eashaw July 27, 2026 13:18
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 225cdf05-260d-46ff-a172-965ae479c5da

📥 Commits

Reviewing files that changed from the base of the PR and between d06a4c2 and c22cff9.

📒 Files selected for processing (1)
  • website/config/routes.js

Walkthrough

Added a GET /learn-more-about/idp-account-sync redirect in website/config/routes.js. Requests are redirected to /guides/deploying-apple-account-provisioning-with-fleet.

Possibly related PRs

  • fleetdm/fleet#49898 — Adds another learn-more-about/... redirect in the same routing module.
🚥 Pre-merge checks | ✅ 2 | ❌ 3

❌ Failed checks (3 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description only names the related issue and omits the required checklist and testing sections from the template. Add the template sections and fill in the checklist items, especially testing, validation, and any applicable deployment notes.
Linked Issues check ⚠️ Warning The change adds only a redirect route and does not implement the macOS Platform SSO and Fleet Server capabilities required by #45524. Implement the feature set from #45524 or relink this PR to a documentation-only issue that matches the redirect change.
Out of Scope Changes check ⚠️ Warning The route redirect is an ancillary navigation change and appears unrelated to the feature work and acceptance criteria in #45524. Remove it unless the redirect is explicitly required for #45524, or document why this navigation change is in scope.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately reflects the route addition.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch melpike-patch-8

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

macOS local account: initial account creation and sync password based on IdP credentials from any IdP that supports OAuth ROPG

2 participants