Skip to content

[Route] Add route for DDM activations learn more page - #50465

Merged
melpike merged 4 commits into
mainfrom
melpike-patch-6
Aug 6, 2026
Merged

[Route] Add route for DDM activations learn more page#50465
melpike merged 4 commits into
mainfrom
melpike-patch-6

Conversation

@melpike

@melpike melpike commented Aug 3, 2026

Copy link
Copy Markdown
Member

Related issue: Resolves #48222

Summary by CodeRabbit

  • Documentation
    • Added a redirect from the DDM activations information page to the relevant section of the Custom OS Settings article.

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 545f0acb-e1ca-402d-ab0d-d673ec845a9c

📥 Commits

Reviewing files that changed from the base of the PR and between 3e15c17 and 053cea0.

📒 Files selected for processing (1)
  • website/config/routes.js
🚧 Files skipped from review as they are similar to previous changes (1)
  • website/config/routes.js

Walkthrough

The website adds a GET redirect for /learn-more-about/ddm-activations. The redirect targets /guides/custom-os-settings#apple-declarations-ddm.

Possibly related PRs

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description links issue #48222 but omits the change summary, checklist responses, and testing information. Add a brief change summary and complete or remove the applicable checklist and testing sections.
Linked Issues check ⚠️ Warning The route supports the learn-more documentation objective, but the changes provide no evidence for the issue's required activation functionality and validation. Implement or reference the required activation UI, API, YAML, CLI, validation, synchronization, permissions, and Premium feature behavior.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the added DDM activations route.
Out of Scope Changes check ✅ Passed The route change is related to DDM activations and does not introduce unrelated code changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch melpike-patch-6

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot mentioned this pull request Aug 3, 2026
Comment thread website/config/routes.js Outdated
Co-authored-by: Eric <eashaw@sailsjs.com>
@fleet-release
fleet-release requested a review from eashaw August 6, 2026 13:20
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@melpike
melpike merged commit e6f1abe into main Aug 6, 2026
7 of 13 checks passed
@melpike
melpike deleted the melpike-patch-6 branch August 6, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configuration profiles: Support custom activations (DDM)

2 participants