Skip to content

Website: update report details page - #48462

Merged
eashaw merged 2 commits into
mainfrom
website-fix-report-details-apge
Jun 29, 2026
Merged

Website: update report details page#48462
eashaw merged 2 commits into
mainfrom
website-fix-report-details-apge

Conversation

@eashaw

@eashaw eashaw commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Changes:

  • Updated the query tab on the report details page to say "Query" instead of report, and updated the link to the reports guide to not say queries.

Summary by CodeRabbit

  • Documentation
    • Corrected the “learn more” link text so report guidance now points to the reports guide.
    • Updated the visible label in the SQL tab area to show “Query” for clearer wording.

Copilot AI review requested due to automatic review settings June 29, 2026 22:45

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0631abbf-e72a-40ca-8c99-2e2d3b90edcf

📥 Commits

Reviewing files that changed from the base of the PR and between f57e28c and 967cd94.

📒 Files selected for processing (1)
  • website/views/pages/docs/report-details.ejs

Walkthrough

In website/views/pages/docs/report-details.ejs, two text corrections were made: the "learn more" link in the informational paragraph now references the reports guide instead of the queries guide, and the visible label on the SQL codeblock tab was changed from "report" to "Query". The tab selection logic (selectedTab === 'sql' / selectedTab = 'sql') remains unchanged.

Possibly related PRs

  • fleetdm/fleet#48020: Adds URL redirects renaming "queries" routes to "reports" destinations, part of the same queries-to-reports documentation rename effort.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description only lists a change summary and omits the required issue reference, checklist items, and testing details. Add the related issue line, fill in the required checklist/testing sections, and note any skipped items or why they don't apply.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and matches the main change to the report details page, though it is broad.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch website-fix-report-details-apge

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates copy on the website’s report details documentation page to align terminology with “reports” and label the SQL tab as “Query.”

Changes:

  • Updated the “learn more” link text and destination from queries → reports.
  • Renamed the SQL tab label from “report” → “Query” for consistency with similar pages.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@eashaw
eashaw merged commit df82d79 into main Jun 29, 2026
10 checks passed
@eashaw
eashaw deleted the website-fix-report-details-apge branch June 29, 2026 23:37
hurricanehrndz added a commit to hurricanehrndz/fleet that referenced this pull request Jun 30, 2026
…ablement-at

* upstream/main:
  Website: update report details page (fleetdm#48462)
  Foreign vitals mapping: Update SCIM integration instructions (fleetdm#48413)
  Two Product Designers for #g-power-to-pc (fleetdm#48456)
  Revise user story handling post-design review (fleetdm#48457)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants