Skip to content

Foreign vitals mapping: Update SCIM integration instructions - #48413

Merged
rachaelshaw merged 16 commits into
mainfrom
noahtalerman-patch-79
Jun 29, 2026
Merged

Foreign vitals mapping: Update SCIM integration instructions#48413
rachaelshaw merged 16 commits into
mainfrom
noahtalerman-patch-79

Conversation

@noahtalerman

@noahtalerman noahtalerman commented Jun 29, 2026

Copy link
Copy Markdown
Member
  • Update the best practice is to create an API-only user w/ the admin role and access only to necessary SCIM API endpoints
    • These doc updates require this bug to be fixed because the /scim/* API endpoints aren't exposed as API endpoints one can pick when creating an API only user
  • Document the /scim/* API endpoints

Summary by CodeRabbit

  • New Features
    • Added SCIM API endpoints for managing users and groups.
    • Supported actions include listing, creating, viewing, replacing, updating, and deleting SCIM users and groups.
    • Added read-only endpoints for SCIM schemas, service provider configuration, and resource types.

noahtalerman and others added 4 commits March 26, 2026 15:57
Currently, Fleet doesn't support CVEs for Debian or Fedora packages. OS (kernel CVEs) are supported
Best practice is to create an API-only user w/ the admin role and access only to necessary SCIM API endpoints
- These doc updates require [this bug](#48062) to be fixed because the `/scim/*` API endpoints aren't exposed as API endpoints one can pick when creating an API only user
  -  Separate PR to add them to the API docs: TODO
@noahtalerman
noahtalerman marked this pull request as ready for review June 29, 2026 16:18

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

Comment thread articles/role-based-access.md Outdated
Comment thread articles/role-based-access.md Outdated
Comment thread articles/role-based-access.md Outdated
Comment thread articles/foreign-vitals-map-idp-users-to-hosts.md Outdated
@noahtalerman

Copy link
Copy Markdown
Member Author

@rachaelshaw PR is ready for review!

Comment thread docs/REST API/rest-api.md
- [Setup Experience](#setup-experience)
- [Commands](#commands)
- [Integrations](#integrations-1)
- [SCIM](#scim)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lucasmrod when you get the chance can you please double check the request/response examples for the SCIM endpoints? I got Claude's help writing them.

(I don't think your review blocks merge b/c we can tweak if they’re wrong)

FYI @rachaelshaw

Comment thread docs/REST API/rest-api.md Outdated
Comment thread docs/REST API/rest-api.md Outdated
Comment thread docs/REST API/rest-api.md Outdated
Comment thread docs/REST API/rest-api.md Outdated

_Available in Fleet Premium_

`DELETE /api/v1/fleet/scim/Users/{id}`

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`DELETE /api/v1/fleet/scim/Users/{id}`
`DELETE /api/v1/fleet/scim/Users/:id`

Comment thread docs/REST API/rest-api.md Outdated
Comment thread docs/REST API/rest-api.md Outdated
Comment thread docs/REST API/rest-api.md Outdated
Comment thread docs/REST API/rest-api.md Outdated
Comment thread docs/REST API/rest-api.md Outdated
Co-authored-by: Rachael Shaw <r@rachael.wtf>
fleet-release
fleet-release previously approved these changes Jun 29, 2026
@rachaelshaw
rachaelshaw merged commit 2c3e38b into main Jun 29, 2026
16 of 24 checks passed
@rachaelshaw
rachaelshaw deleted the noahtalerman-patch-79 branch June 29, 2026 22:56
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 75f85711-13b6-47d1-8790-ac7b567960ff

📥 Commits

Reviewing files that changed from the base of the PR and between af2d4db and c8a090d.

⛔ Files ignored due to path filters (2)
  • articles/foreign-vitals-map-idp-users-to-hosts.md is excluded by !**/*.md
  • docs/REST API/rest-api.md is excluded by !**/*.md
📒 Files selected for processing (1)
  • server/api_endpoints/api_endpoints.yml

Walkthrough

server/api_endpoints/api_endpoints.yml gains 15 new route entries under /api/v1/fleet/scim/. Full CRUD operations (GET list, POST, GET by ID, PUT, PATCH, DELETE) are declared for /Users and /Groups. Three read-only GET endpoints are added for /Schemas, /ServiceProviderConfig, and /ResourceTypes.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is missing the required template sections, including Related issue, checklist items, testing, and other required subsections. Rewrite the PR description using the repository template and fill in the Related issue, checklist, testing, and other required sections.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately reflects the SCIM integration instruction update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch noahtalerman-patch-79

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.64%. Comparing base (af2d4db) to head (c8a090d).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main   #48413       +/-   ##
===========================================
- Coverage   67.48%   55.64%   -11.84%     
===========================================
  Files        3675     3675               
  Lines      233489   233535       +46     
  Branches    12230    12230               
===========================================
- Hits       157563   129947    -27616     
- Misses      61782    91607    +29825     
+ Partials    14144    11981     -2163     
Flag Coverage Δ
backend 54.87% <ø> (-14.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

hurricanehrndz added a commit to hurricanehrndz/fleet that referenced this pull request Jun 30, 2026
…ablement-at

* upstream/main:
  Website: update report details page (fleetdm#48462)
  Foreign vitals mapping: Update SCIM integration instructions (fleetdm#48413)
  Two Product Designers for #g-power-to-pc (fleetdm#48456)
  Revise user story handling post-design review (fleetdm#48457)
juan-fdz-hawa added a commit that referenced this pull request Jul 2, 2026
Cherry picks:
- #48413
- #48477

---------

Co-authored-by: Noah Talerman <47070608+noahtalerman@users.noreply.github.com>
Co-authored-by: Rachael Shaw <r@rachael.wtf>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants