Foreign vitals mapping: Update SCIM integration instructions - #48413
Conversation
Currently, Fleet doesn't support CVEs for Debian or Fedora packages. OS (kernel CVEs) are supported
Best practice is to create an API-only user w/ the admin role and access only to necessary SCIM API endpoints - These doc updates require [this bug](#48062) to be fixed because the `/scim/*` API endpoints aren't exposed as API endpoints one can pick when creating an API only user - Separate PR to add them to the API docs: TODO
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
@rachaelshaw PR is ready for review! |
| - [Setup Experience](#setup-experience) | ||
| - [Commands](#commands) | ||
| - [Integrations](#integrations-1) | ||
| - [SCIM](#scim) |
There was a problem hiding this comment.
Hey @lucasmrod when you get the chance can you please double check the request/response examples for the SCIM endpoints? I got Claude's help writing them.
(I don't think your review blocks merge b/c we can tweak if they’re wrong)
FYI @rachaelshaw
|
|
||
| _Available in Fleet Premium_ | ||
|
|
||
| `DELETE /api/v1/fleet/scim/Users/{id}` |
There was a problem hiding this comment.
| `DELETE /api/v1/fleet/scim/Users/{id}` | |
| `DELETE /api/v1/fleet/scim/Users/:id` |
Co-authored-by: Rachael Shaw <r@rachael.wtf>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
Walkthrough
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #48413 +/- ##
===========================================
- Coverage 67.48% 55.64% -11.84%
===========================================
Files 3675 3675
Lines 233489 233535 +46
Branches 12230 12230
===========================================
- Hits 157563 129947 -27616
- Misses 61782 91607 +29825
+ Partials 14144 11981 -2163
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…ablement-at * upstream/main: Website: update report details page (fleetdm#48462) Foreign vitals mapping: Update SCIM integration instructions (fleetdm#48413) Two Product Designers for #g-power-to-pc (fleetdm#48456) Revise user story handling post-design review (fleetdm#48457)
/scim/*API endpoints aren't exposed as API endpoints one can pick when creating an API only user/scim/*API endpointsSummary by CodeRabbit