Skip to content

Clarify MDM status tooltips - #47675

Merged
MagnusHJensen merged 3 commits into
mainfrom
clarify-mdm-status-tooltips
Jun 18, 2026
Merged

Clarify MDM status tooltips#47675
MagnusHJensen merged 3 commits into
mainfrom
clarify-mdm-status-tooltips

Conversation

@spalmesano0

@spalmesano0 spalmesano0 commented Jun 16, 2026

Copy link
Copy Markdown
Member

Related issue: Resolves #46245

Checklist for submitter

Testing

  • QA'd all new/changed functionality manually

Summary by CodeRabbit

  • Style
    • Refined MDM enrollment status filter tooltip text for improved clarity on enrollment states.

@spalmesano0
spalmesano0 requested a review from Copilot June 16, 2026 15:52
@spalmesano0 spalmesano0 changed the title Clarify mdm status tooltips Clarify MDM status tooltips Jun 16, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Fleet’s MDM status tooltip copy to better explain what each status means, and reuses the centralized MDM_STATUS_TOOLTIP mapping for the Manage hosts filter pill tooltip so the UI stays consistent.

Changes:

  • Expanded/clarified tooltip text for "On (automatic)", "On (manual)", "On (personal)", and "Pending" MDM enrollment statuses.
  • Removed the bespoke “MDM status pill” tooltip mapping in HostsFilterBlock and derived tooltip content from the shared MDM_STATUS_TOOLTIP.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
frontend/utilities/constants.tsx Updates MDM enrollment tooltip copy (and formatting) in the shared constants map.
frontend/pages/hosts/ManageHostsPage/components/HostsFilterBlock/HostsFilterBlock.tsx Switches MDM filter pill tooltips to use the shared MDM_STATUS_TOOLTIP via the enrollment status UI map.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread frontend/utilities/constants.tsx Outdated
Comment thread frontend/utilities/constants.tsx
@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.21%. Comparing base (67fce02) to head (08f3c02).
⚠️ Report is 49 commits behind head on main.

Files with missing lines Patch % Lines
...e/components/HostsFilterBlock/HostsFilterBlock.tsx 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #47675      +/-   ##
==========================================
+ Coverage   67.19%   67.21%   +0.02%     
==========================================
  Files        3618     3629      +11     
  Lines      229110   229230     +120     
  Branches    11899    11785     -114     
==========================================
+ Hits       153944   154082     +138     
+ Misses      61324    61307      -17     
+ Partials    13842    13841       -1     
Flag Coverage Δ
frontend 58.19% <0.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment on lines +413 to +415
const apiStatus = Object.entries(MDM_ENROLLMENT_STATUS_UI_MAP).find(
([, v]) => v.filterValue === mdmEnrollmentStatus
)?.[0] as MdmEnrollmentStatus | undefined;
@spalmesano0
spalmesano0 force-pushed the clarify-mdm-status-tooltips branch from 0d3c628 to 173f8a4 Compare June 16, 2026 16:39
@spalmesano0
spalmesano0 marked this pull request as ready for review June 17, 2026 19:29
@spalmesano0
spalmesano0 requested a review from a team as a code owner June 17, 2026 19:29

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 351f19b2-b665-413f-94ee-e7146e0c8259

📥 Commits

Reviewing files that changed from the base of the PR and between a950e24 and 08f3c02.

📒 Files selected for processing (2)
  • frontend/pages/hosts/ManageHostsPage/components/HostsFilterBlock/HostsFilterBlock.tsx
  • frontend/utilities/constants.tsx

Walkthrough

The PR updates tooltip text for four MDM enrollment statuses — On (automatic), On (manual), On (personal), and Pending — in the shared MDM_STATUS_TOOLTIP record in constants.tsx, adjusting wording and line break formatting. In HostsFilterBlock.tsx, the local MDM_STATUS_PILL_TOOLTIP record is removed and the renderMDMEnrollmentFilterBlock function is refactored to derive the API status key by matching against MDM_ENROLLMENT_STATUS_UI_MAP entries and then look up the tooltip description directly from the shared MDM_STATUS_TOOLTIP constant.

Possibly related PRs

  • fleetdm/fleet#45245: Also modifies MDM_STATUS_TOOLTIP content in frontend/utilities/constants.tsx for MdmEnrollmentStatus values including On (personal).
  • fleetdm/fleet#46377: Works on MDM status tooltip rendering in the hosts table using the same MDM_STATUS_TOOLTIP constant that this PR updates and consolidates.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is largely incomplete. It only includes the 'Related issue' and one checkbox from the testing section, missing most required template sections like changes files, input validation, security, testing details, and database considerations. Complete the pull request description template by filling in the required sections, particularly around testing, changes files, and any applicable checklists.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Clarify MDM status tooltips' directly summarizes the main change: updating tooltip content and logic to provide clearer descriptions of MDM statuses.
Linked Issues check ✅ Passed The PR successfully addresses issue #46245 by clarifying MDM status tooltips through improved wording in tooltip content and extending tooltip usage to the MDM enrollment filter functionality, aligning with the issue's objectives.
Out of Scope Changes check ✅ Passed All changes are directly related to issue #46245: updating tooltip content in constants.tsx and refactoring tooltip lookup logic in HostsFilterBlock.tsx. No unrelated changes detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch clarify-mdm-status-tooltips

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@MagnusHJensen MagnusHJensen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @spalmesano0

@MagnusHJensen
MagnusHJensen merged commit c36cd67 into main Jun 18, 2026
27 checks passed
@MagnusHJensen
MagnusHJensen deleted the clarify-mdm-status-tooltips branch June 18, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarify MDM status tooltips

3 participants