Clarify MDM status tooltips - #47675
Conversation
There was a problem hiding this comment.
Pull request overview
Updates Fleet’s MDM status tooltip copy to better explain what each status means, and reuses the centralized MDM_STATUS_TOOLTIP mapping for the Manage hosts filter pill tooltip so the UI stays consistent.
Changes:
- Expanded/clarified tooltip text for
"On (automatic)","On (manual)","On (personal)", and"Pending"MDM enrollment statuses. - Removed the bespoke “MDM status pill” tooltip mapping in
HostsFilterBlockand derived tooltip content from the sharedMDM_STATUS_TOOLTIP.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| frontend/utilities/constants.tsx | Updates MDM enrollment tooltip copy (and formatting) in the shared constants map. |
| frontend/pages/hosts/ManageHostsPage/components/HostsFilterBlock/HostsFilterBlock.tsx | Switches MDM filter pill tooltips to use the shared MDM_STATUS_TOOLTIP via the enrollment status UI map. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #47675 +/- ##
==========================================
+ Coverage 67.19% 67.21% +0.02%
==========================================
Files 3618 3629 +11
Lines 229110 229230 +120
Branches 11899 11785 -114
==========================================
+ Hits 153944 154082 +138
+ Misses 61324 61307 -17
+ Partials 13842 13841 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
c824fc5 to
0d3c628
Compare
| const apiStatus = Object.entries(MDM_ENROLLMENT_STATUS_UI_MAP).find( | ||
| ([, v]) => v.filterValue === mdmEnrollmentStatus | ||
| )?.[0] as MdmEnrollmentStatus | undefined; |
0d3c628 to
173f8a4
Compare
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThe PR updates tooltip text for four MDM enrollment statuses — On (automatic), On (manual), On (personal), and Pending — in the shared Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Related issue: Resolves #46245
Checklist for submitter
Testing
Summary by CodeRabbit