Skip to content

Dashboard and Host details page: Tweak copy - #45245

Merged
noahtalerman merged 1 commit into
mainfrom
noahtalerman-patch-79
Jun 2, 2026
Merged

Dashboard and Host details page: Tweak copy#45245
noahtalerman merged 1 commit into
mainfrom
noahtalerman-patch-79

Conversation

@noahtalerman

@noahtalerman noahtalerman commented May 12, 2026

Copy link
Copy Markdown
Member
  • Copy tweak to use platform ("iOS/iPadOS") instead of device name to be consistent w/ "Android"

Tooltip copy before change:

Screenshot 2026-05-12 at 12 11 41 PM

Summary by CodeRabbit

  • Documentation
    • Updated MDM enrollment status tooltip to clarify device platform requirements for Managed Apple Account sign-in.

Review Change Stack

- Copy tweak to use platform instead of device name to be consistent w/ "Android"
@noahtalerman
noahtalerman requested a review from a team as a code owner May 12, 2026 16:12

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai

coderabbitai Bot commented May 12, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0cec383c-2dcf-4e55-9395-e25b49911207

📥 Commits

Reviewing files that changed from the base of the PR and between 07697fa and 24f18e2.

📒 Files selected for processing (1)
  • frontend/utilities/constants.tsx

Walkthrough

This PR updates the tooltip text in the MDM_STATUS_TOOLTIP constant to use more accurate platform terminology. The "On (personal)" enrollment status tooltip now references "iOS/iPadOS" instead of "iPhone/iPad" when describing Managed Apple Account sign-in on Apple devices.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Dashboard and Host details page: Tweak copy' is related to the changeset but is overly broad and lacks specificity about the actual copy change being made. Consider a more specific title like 'Update MDM status tooltip to use iOS/iPadOS instead of iPhone/iPad' to clarify the exact change.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly explains the purpose (platform consistency with Android) and includes a visual reference, but does not follow the provided template's checklist structure.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch noahtalerman-patch-79

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented May 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.81%. Comparing base (a913a5e) to head (24f18e2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #45245   +/-   ##
=======================================
  Coverage   66.81%   66.81%           
=======================================
  Files        2724     2724           
  Lines      219027   219027           
  Branches    10627    10627           
=======================================
  Hits       146342   146342           
  Misses      59520    59520           
  Partials    13165    13165           
Flag Coverage Δ
frontend 55.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@noahtalerman

Copy link
Copy Markdown
Member Author

Hey @cdcme when you get the chance, can you please review this small copy tweak? Thanks!

@noahtalerman
noahtalerman merged commit 64ba33e into main Jun 2, 2026
24 checks passed
@noahtalerman
noahtalerman deleted the noahtalerman-patch-79 branch June 2, 2026 21:53
This was referenced Jun 17, 2026
@coderabbitai coderabbitai Bot mentioned this pull request Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants