Update Fleet-maintained apps - #47474
Closed
fleet-release wants to merge 1 commit into
Closed
Conversation
Generated automatically with cmd/maintained-apps.
Contributor
Script Diff Resultsee/maintained-apps/outputs/aws-cli/windows.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/camunda-modeler/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/fantastical/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/firealpaca/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/framer/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/glyphs/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/macpacker/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/macvim-app/darwin.json=== Install // bae18e19 -> 2fb79ce8 ===
--- /tmp/old.Waq5a6 2026-06-11 23:12:14.094334923 +0000
+++ /tmp/new.SaH29y 2026-06-11 23:12:14.094334923 +0000
@@ -100,12 +100,12 @@
sudo cp -R "$MOUNT_POINT"/* "$TMPDIR"
hdiutil detach "$MOUNT_POINT" || true
# copy to the applications folder
-quit_and_track_application 'org.vim.MacVim.LSSharedFileList'
+quit_and_track_application 'org.vim.MacVim'
if [ -d "$APPDIR/MacVim.app" ]; then
sudo mv "$APPDIR/MacVim.app" "$TMPDIR/MacVim.app.bkp"
fi
sudo cp -R "$TMPDIR/MacVim.app" "$APPDIR"
-relaunch_application 'org.vim.MacVim.LSSharedFileList'
+relaunch_application 'org.vim.MacVim'
mkdir -p .
/bin/ln -h -f -s -- "$APPDIR/MacVim.app/Contents/bin/mvim" "gview"
/bin/ln -h -f -s -- "$APPDIR/MacVim.app/Contents/bin/mvim" "gvim"
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/marked-app/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/melodics/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/memoryanalyzer/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/mimestream/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/musescore/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/twingate/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) === |
Contributor
WalkthroughThis PR updates installer metadata for 14 maintained applications across Windows and macOS. Each update bumps the application version and synchronizes the associated metadata: the installer download URL, the SQL version comparison threshold used in patch detection queries, and the SHA-256 checksum. One exception is MacVim, which also changes the detection bundle identifier and swaps the installation script reference along with its payload. Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
ee/maintained-apps/outputs/firealpaca/darwin.json (1)
12-12:⚠️ Potential issue | 🟠 Major | 🏗️ Heavy liftBypassing SHA256 verification creates a supply-chain security risk.
Setting
sha256to"no_check"disables cryptographic integrity verification of the installer, exposing deployments to man-in-the-middle attacks, corrupted downloads, and supply-chain compromise. Without checksum validation, Fleet cannot detect if the downloaded installer has been tampered with or replaced.Consider using versioned download URLs with stable checksums, or implement an alternative integrity verification mechanism.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ee/maintained-apps/outputs/firealpaca/darwin.json` at line 12, Replace the insecure `"sha256": "no_check"` entry with a real cryptographic checksum and ensure the installer verification uses it; locate the `sha256` field in darwin.json (the `"sha256"` key currently set to `"no_check"`) and update it to the correct SHA-256 hash for the specific FireAlpaca release (or change the manifest to reference a signed/immutable artifact or accompanying checksum file), and verify the download process uses that checksum to validate integrity before installation.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@ee/maintained-apps/outputs/firealpaca/darwin.json`:
- Line 12: Replace the insecure `"sha256": "no_check"` entry with a real
cryptographic checksum and ensure the installer verification uses it; locate the
`sha256` field in darwin.json (the `"sha256"` key currently set to `"no_check"`)
and update it to the correct SHA-256 hash for the specific FireAlpaca release
(or change the manifest to reference a signed/immutable artifact or accompanying
checksum file), and verify the download process uses that checksum to validate
integrity before installation.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d386675b-a215-47e3-803c-2c03d281d167
📒 Files selected for processing (14)
ee/maintained-apps/outputs/aws-cli/windows.jsonee/maintained-apps/outputs/camunda-modeler/darwin.jsonee/maintained-apps/outputs/fantastical/darwin.jsonee/maintained-apps/outputs/firealpaca/darwin.jsonee/maintained-apps/outputs/framer/darwin.jsonee/maintained-apps/outputs/glyphs/darwin.jsonee/maintained-apps/outputs/macpacker/darwin.jsonee/maintained-apps/outputs/macvim-app/darwin.jsonee/maintained-apps/outputs/marked-app/darwin.jsonee/maintained-apps/outputs/melodics/darwin.jsonee/maintained-apps/outputs/memoryanalyzer/darwin.jsonee/maintained-apps/outputs/mimestream/darwin.jsonee/maintained-apps/outputs/musescore/darwin.jsonee/maintained-apps/outputs/twingate/darwin.json
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
Contributor
|
Closing in favor of #47479. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated ingestion of latest Fleet-maintained app data.
Summary by CodeRabbit