Skip to content

Windows FMA - AWS CLI - #46405

Merged
allenhouchins merged 5 commits into
mainfrom
awscli-fma
May 29, 2026
Merged

Windows FMA - AWS CLI#46405
allenhouchins merged 5 commits into
mainfrom
awscli-fma

Conversation

@harrisonravazzolo

@harrisonravazzolo harrisonravazzolo commented May 28, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Features
    • Added AWS Command Line Interface v2 support for Windows, including install and upgrade management.
    • Included AWS CLI metadata for detection and installer handling (x64 MSI, machine scope).
    • Added AWS CLI icon to the software UI for consistent display.

Review Change Stack

@codecov

codecov Bot commented May 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.87%. Comparing base (aeaa7a2) to head (70477fa).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #46405      +/-   ##
==========================================
- Coverage   66.87%   66.87%   -0.01%     
==========================================
  Files        2787     2788       +1     
  Lines      222285   222287       +2     
  Branches    11297    11334      +37     
==========================================
+ Hits       148663   148664       +1     
- Misses      60167    60168       +1     
  Partials    13455    13455              
Flag Coverage Δ
frontend 56.31% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@harrisonravazzolo
harrisonravazzolo marked this pull request as ready for review May 28, 2026 23:37
@harrisonravazzolo
harrisonravazzolo requested a review from a team as a code owner May 28, 2026 23:37

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e597fcdc-3086-4755-8469-d7bed05f8378

📥 Commits

Reviewing files that changed from the base of the PR and between 11da63a and 70477fa.

📒 Files selected for processing (1)
  • ee/maintained-apps/outputs/aws-cli/windows.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • ee/maintained-apps/outputs/aws-cli/windows.json

Walkthrough

This PR adds AWS Command Line Interface v2 support to the Fleet maintained-apps system. Changes include a new winget input metadata file (package identifier Amazon.AWSCLI, installer metadata), a registry entry in apps.json for the Windows platform, a Windows installer output JSON with version 2.34.55 plus MSI URL/checksum and PowerShell install/uninstall scripts, and a new React icon component for the frontend.

Possibly related PRs

  • fleetdm/fleet#46264: Adds a different maintained app (GoToMeeting) to the same ee/maintained-apps/outputs/apps.json registry using the same patterns.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is empty, but the repository template requires multiple sections including related issues, checklists for validation, testing, and platform-specific checks. Add a comprehensive description following the repository template, including related issue number, completed checklists for validation/security, testing performed, and any applicable platform-specific verification.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Windows FMA - AWS CLI' clearly identifies the platform and software being added, directly matching the changeset which adds AWS CLI support for Windows with related input/output metadata and icon component.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch awscli-fma

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ee/maintained-apps/outputs/aws-cli/windows.json`:
- Line 19: The Start-Process invocation in the installer script (install snippet
id "8959087b") uses "-Verb RunAs" which forces UAC elevation and can hang in
non-interactive/SYSTEM runs; remove the "-Verb RunAs" token from the
Start-Process msiexec.exe call and keep "-PassThru -Wait" so the installer runs
under the current execution context without prompting for elevation. Ensure the
rest of the msiexec ArgumentList and subsequent Get-Content $logFile and Exit
$installProcess.ExitCode logic remain unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 05911721-13cf-448e-b1c1-73fe43b51379

📥 Commits

Reviewing files that changed from the base of the PR and between aeaa7a2 and 11da63a.

⛔ Files ignored due to path filters (1)
  • website/assets/images/app-icon-aws-cli-60x60@2x.png is excluded by !**/*.png
📒 Files selected for processing (4)
  • ee/maintained-apps/inputs/winget/aws-cli.json
  • ee/maintained-apps/outputs/apps.json
  • ee/maintained-apps/outputs/aws-cli/windows.json
  • frontend/pages/SoftwarePage/components/icons/AwsCli.tsx

Comment thread ee/maintained-apps/outputs/aws-cli/windows.json Outdated
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@allenhouchins
allenhouchins merged commit 3df0d63 into main May 29, 2026
18 checks passed
@allenhouchins
allenhouchins deleted the awscli-fma branch May 29, 2026 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants