Windows FMA - AWS CLI - #46405
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #46405 +/- ##
==========================================
- Coverage 66.87% 66.87% -0.01%
==========================================
Files 2787 2788 +1
Lines 222285 222287 +2
Branches 11297 11334 +37
==========================================
+ Hits 148663 148664 +1
- Misses 60167 60168 +1
Partials 13455 13455
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThis PR adds AWS Command Line Interface v2 support to the Fleet maintained-apps system. Changes include a new winget input metadata file (package identifier Amazon.AWSCLI, installer metadata), a registry entry in apps.json for the Windows platform, a Windows installer output JSON with version 2.34.55 plus MSI URL/checksum and PowerShell install/uninstall scripts, and a new React icon component for the frontend. Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ee/maintained-apps/outputs/aws-cli/windows.json`:
- Line 19: The Start-Process invocation in the installer script (install snippet
id "8959087b") uses "-Verb RunAs" which forces UAC elevation and can hang in
non-interactive/SYSTEM runs; remove the "-Verb RunAs" token from the
Start-Process msiexec.exe call and keep "-PassThru -Wait" so the installer runs
under the current execution context without prompting for elevation. Ensure the
rest of the msiexec ArgumentList and subsequent Get-Content $logFile and Exit
$installProcess.ExitCode logic remain unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 05911721-13cf-448e-b1c1-73fe43b51379
⛔ Files ignored due to path filters (1)
website/assets/images/app-icon-aws-cli-60x60@2x.pngis excluded by!**/*.png
📒 Files selected for processing (4)
ee/maintained-apps/inputs/winget/aws-cli.jsonee/maintained-apps/outputs/apps.jsonee/maintained-apps/outputs/aws-cli/windows.jsonfrontend/pages/SoftwarePage/components/icons/AwsCli.tsx
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Summary by CodeRabbit