Skip to content

Move tooltip for vulnerability support to "Not supported" - #47074

Merged
spalmesano0 merged 2 commits into
mainfrom
vulns-not-supported
Jun 16, 2026
Merged

Move tooltip for vulnerability support to "Not supported"#47074
spalmesano0 merged 2 commits into
mainfrom
vulns-not-supported

Conversation

@spalmesano0

@spalmesano0 spalmesano0 commented Jun 8, 2026

Copy link
Copy Markdown
Member

Related issue: Resolves #44109

Checklist for submitter

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.

Testing

  • QA'd all new/changed functionality manually

Summary by CodeRabbit

  • Improvements
    • Updated the Vulnerabilities column on the Software > OS page: "Not supported" cells now include a tooltip relocated to the unsupported indicator that explains which platforms support vulnerability detection, and a "Learn more" link to Fleet documentation. Copy clarified to make platform support and next steps more visible to users.

Copilot AI review requested due to automatic review settings June 8, 2026 12:21
@spalmesano0
spalmesano0 requested a review from a team as a code owner June 8, 2026 12:21

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ee544a10-52a6-485f-be59-6659b9f8530a

📥 Commits

Reviewing files that changed from the base of the PR and between 0767a30 and bb07dec.

📒 Files selected for processing (1)
  • frontend/pages/DashboardPage/cards/OperatingSystems/OSTableConfig.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • frontend/pages/DashboardPage/cards/OperatingSystems/OSTableConfig.tsx

Walkthrough

This PR relocates the vulnerability platforms explanation from the Vulnerabilities column header to the "Not supported" cells on the Software > OS page. The Vulnerabilities header is simplified to a plain string, and unsupported-platform cells now display "Not supported" inside a TooltipWrapper that explains which platforms support vulnerability detection and includes a "Learn more" CustomLink to the Fleet vulnerability coverage guide.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: moving a tooltip for vulnerability support information to the 'Not supported' label on the Software > OS page.
Description check ✅ Passed The description includes the related issue number (#44109), confirms the changes file was added, and indicates manual QA testing was completed, meeting the template requirements.
Linked Issues check ✅ Passed The code changes directly implement the requirements from issue #44109: the tooltip is moved from the Vulnerabilities column header to the 'Not supported' element, and it explains which platforms support vulnerability detection.
Out of Scope Changes check ✅ Passed All changes are scoped to the objective: UI updates to the OSTableConfig.tsx file and a changes file addition, with no unrelated modifications present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch vulns-not-supported

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Software > OS operating systems table UX by moving the vulnerability support tooltip from the “Vulnerabilities” column header to the “Not supported” cell state, so users only see the guidance when it’s relevant.

Changes:

  • Replaced the “Vulnerabilities” column header tooltip with a plain header label.
  • Added a tooltip to the “Not supported” cell explaining which platforms support vulnerability detection, including a “Learn more” link.
  • Added a user-visible change note in changes/.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
frontend/pages/DashboardPage/cards/OperatingSystems/OSTableConfig.tsx Moves tooltip behavior from the column header to the “Not supported” cell and adds an external help link in the tooltip content.
changes/44109-vulns-not-supported Adds changelog entry describing the tooltip move/update on Software > OS.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 121 to 126
@@ -141,7 +124,29 @@ const generateDefaultTableHeaders = (
platform !== "windows" &&
!isLinuxLike(platform)
) {
@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.03%. Comparing base (632089e) to head (bb07dec).
⚠️ Report is 62 commits behind head on main.

Files with missing lines Patch % Lines
...boardPage/cards/OperatingSystems/OSTableConfig.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #47074   +/-   ##
=======================================
  Coverage   67.03%   67.03%           
=======================================
  Files        2861     2883   +22     
  Lines      224817   224886   +69     
  Branches    11776    11776           
=======================================
+ Hits       150699   150751   +52     
- Misses      60464    60481   +17     
  Partials    13654    13654           
Flag Coverage Δ
frontend 56.97% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dantecatalfamo dantecatalfamo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spalmesano0
spalmesano0 merged commit ef0aed3 into main Jun 16, 2026
24 checks passed
@spalmesano0
spalmesano0 deleted the vulns-not-supported branch June 16, 2026 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Software > OS: Move vulnerability platforms tooltip to "Not supported"

3 participants