Move tooltip for vulnerability support to "Not supported" - #47074
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThis PR relocates the vulnerability platforms explanation from the Vulnerabilities column header to the "Not supported" cells on the Software > OS page. The Vulnerabilities header is simplified to a plain string, and unsupported-platform cells now display "Not supported" inside a TooltipWrapper that explains which platforms support vulnerability detection and includes a "Learn more" CustomLink to the Fleet vulnerability coverage guide. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates the Software > OS operating systems table UX by moving the vulnerability support tooltip from the “Vulnerabilities” column header to the “Not supported” cell state, so users only see the guidance when it’s relevant.
Changes:
- Replaced the “Vulnerabilities” column header tooltip with a plain header label.
- Added a tooltip to the “Not supported” cell explaining which platforms support vulnerability detection, including a “Learn more” link.
- Added a user-visible change note in
changes/.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| frontend/pages/DashboardPage/cards/OperatingSystems/OSTableConfig.tsx | Moves tooltip behavior from the column header to the “Not supported” cell and adds an external help link in the tooltip content. |
| changes/44109-vulns-not-supported | Adds changelog entry describing the tooltip move/update on Software > OS. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -141,7 +124,29 @@ const generateDefaultTableHeaders = ( | |||
| platform !== "windows" && | |||
| !isLinuxLike(platform) | |||
| ) { | |||
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #47074 +/- ##
=======================================
Coverage 67.03% 67.03%
=======================================
Files 2861 2883 +22
Lines 224817 224886 +69
Branches 11776 11776
=======================================
+ Hits 150699 150751 +52
- Misses 60464 60481 +17
Partials 13654 13654
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Related issue: Resolves #44109
Checklist for submitter
changes/,orbit/changes/oree/fleetd-chrome/changes.Testing
Summary by CodeRabbit