Skip to content

Update Fleet-maintained apps - #46561

Merged
allenhouchins merged 1 commit into
mainfrom
fma-2606011351
Jun 1, 2026
Merged

Update Fleet-maintained apps#46561
allenhouchins merged 1 commit into
mainfrom
fma-2606011351

Conversation

@fleet-release

@fleet-release fleet-release commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Automated ingestion of latest Fleet-maintained app data.

Summary by CodeRabbit

  • Updates
    • Improved Amazon WorkSpaces macOS uninstall behavior for better file cleanup operations
    • Updated Google Gemini macOS version support to 1.63.12.361

Generated automatically with cmd/maintained-apps.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Script Diff Results

ee/maintained-apps/outputs/amazon-workspaces/darwin.json

=== Install Script (no changes) ===
=== Uninstall // c393d9c9 -> 8e0aba36 ===

--- /tmp/old.UYBlaf	2026-06-01 13:55:15.726393654 +0000
+++ /tmp/new.KXTJRp	2026-06-01 13:55:15.727393669 +0000
@@ -128,6 +128,31 @@
   fi
 
   local trash="/Users/$logged_in_user/.Trash"
+
+  # If the target contains glob characters, expand it and move each match.
+  if [[ "$target_file" == *[*?[]* ]]; then
+    local file file_name
+    local matched=false
+    local i=0
+    # compgen -G expands the (quoted) pattern itself, so paths containing
+    # spaces glob correctly; reading line by line keeps each match intact.
+    while IFS= read -r file; do
+      [[ -n "$file" ]] || continue
+      [[ -e "$file" || -L "$file" ]] || continue
+      matched=true
+      i=$((i + 1))
+      file_name="$(basename "$file")"
+      echo "removing $file."
+      # The per-match counter keeps matches that share a basename from
+      # overwriting each other in the trash.
+      mv -f "$file" "$trash/${file_name}_${timestamp}_${rand}_${i}"
+    done < <(compgen -G "$target_file" 2>/dev/null)
+    if [[ "$matched" == false ]]; then
+      echo "$target_file doesn't exist."
+    fi
+    return
+  fi
+
   local file_name="$(basename "${target_file}")"
 
   if [[ -e "$target_file" ]]; then

ee/maintained-apps/outputs/google-gemini/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3474c61b-62c6-4321-93f5-f75c250421d9

📥 Commits

Reviewing files that changed from the base of the PR and between 71a82d0 and 4e32df2.

📒 Files selected for processing (2)
  • ee/maintained-apps/outputs/amazon-workspaces/darwin.json
  • ee/maintained-apps/outputs/google-gemini/darwin.json

Walkthrough

This PR updates configuration for two macOS maintained-app entries. Amazon WorkSpaces receives an uninstall script reference change that enhances the trash() helper to handle glob-pattern targets by expanding matches and moving each to Trash individually, while preserving ~ expansion and existing uninstall steps. Google Gemini receives a version bump from 1.60.2.323 to 1.63.12.361 with corresponding patched query threshold adjustment.

Possibly related PRs

  • fleetdm/fleet#46536: Both PRs modify the Amazon WorkSpaces macOS ee/maintained-apps/outputs/amazon-workspaces/darwin.json uninstall script content/uninstall_script_ref, specifically changing the uninstall-time Trash behavior.
  • fleetdm/fleet#45603: Both PRs update an uninstall script's trash() helper to correctly handle globbed target paths by expanding matches and moving each match into the user Trash with unique per-match naming.
🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is minimal and lacks required checklist items. No related issue reference, no changes file mentioned, and most required checkboxes are incomplete or unchecked. Add related issue reference, complete the checklist items (especially 'Changes file added'), and provide more context about testing and validation performed.
Title check ❓ Inconclusive The title 'Update Fleet-maintained apps' is generic and doesn't specify which apps were updated or what the actual changes are. Consider using a more descriptive title that specifies the apps updated (e.g., 'Update Amazon WorkSpaces and Google Gemini macOS versions') to make the change history more informative.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fma-2606011351

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@allenhouchins
allenhouchins merged commit 7d30ece into main Jun 1, 2026
13 checks passed
@allenhouchins
allenhouchins deleted the fma-2606011351 branch June 1, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants