Skip to content

Update Fleet-maintained apps - #46559

Closed
fleet-release wants to merge 1 commit into
mainfrom
fma-2606011340
Closed

Update Fleet-maintained apps#46559
fleet-release wants to merge 1 commit into
mainfrom
fma-2606011340

Conversation

@fleet-release

@fleet-release fleet-release commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Automated ingestion of latest Fleet-maintained app data.

Summary by CodeRabbit

  • Chores
    • Improved Amazon WorkSpaces macOS uninstall script with enhanced file cleanup capabilities, including support for wildcard pattern matching in trash operations.
    • Updated Google Gemini macOS version detection to recognize the latest application release.

Generated automatically with cmd/maintained-apps.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Script Diff Results

ee/maintained-apps/outputs/amazon-workspaces/darwin.json

=== Install Script (no changes) ===
=== Uninstall // c393d9c9 -> 8e0aba36 ===

--- /tmp/old.Y8bR1m	2026-06-01 13:44:11.210250919 +0000
+++ /tmp/new.7U7GO4	2026-06-01 13:44:11.211250918 +0000
@@ -128,6 +128,31 @@
   fi
 
   local trash="/Users/$logged_in_user/.Trash"
+
+  # If the target contains glob characters, expand it and move each match.
+  if [[ "$target_file" == *[*?[]* ]]; then
+    local file file_name
+    local matched=false
+    local i=0
+    # compgen -G expands the (quoted) pattern itself, so paths containing
+    # spaces glob correctly; reading line by line keeps each match intact.
+    while IFS= read -r file; do
+      [[ -n "$file" ]] || continue
+      [[ -e "$file" || -L "$file" ]] || continue
+      matched=true
+      i=$((i + 1))
+      file_name="$(basename "$file")"
+      echo "removing $file."
+      # The per-match counter keeps matches that share a basename from
+      # overwriting each other in the trash.
+      mv -f "$file" "$trash/${file_name}_${timestamp}_${rand}_${i}"
+    done < <(compgen -G "$target_file" 2>/dev/null)
+    if [[ "$matched" == false ]]; then
+      echo "$target_file doesn't exist."
+    fi
+    return
+  fi
+
   local file_name="$(basename "${target_file}")"
 
   if [[ -e "$target_file" ]]; then

ee/maintained-apps/outputs/google-gemini/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 75f3ae7b-20c8-4705-a1bc-a0aa10cfc32d

📥 Commits

Reviewing files that changed from the base of the PR and between 71a82d0 and a36659d.

📒 Files selected for processing (2)
  • ee/maintained-apps/outputs/amazon-workspaces/darwin.json
  • ee/maintained-apps/outputs/google-gemini/darwin.json

Walkthrough

This PR updates metadata for two maintained macOS applications. The Amazon WorkSpaces uninstall script reference is updated with an enhanced trash() helper that now handles glob patterns by expanding wildcard matches via compgen -G and moving each result to the user's Trash with unique suffixes, while preserving the single-path behavior for non-glob inputs. The Google Gemini macOS app version is bumped from 1.60.2.323 to 1.63.12.361, with a corresponding update to the queries.patched version comparison threshold.

Possibly related PRs

  • fleetdm/fleet#46536: Introduces the Amazon WorkSpaces macOS artifact and initial uninstall/install scripts; this PR extends that work by updating the uninstall script reference and enhancing the trash() helper with glob pattern support.
  • fleetdm/fleet#45603: Modifies the trash() helper in the uninstall script to support glob-pattern expansion via compgen -G with unique per-match suffixes, sharing the same enhancement pattern as this PR's Amazon WorkSpaces update.
  • fleetdm/fleet#46185: Updates the Google Gemini macOS artifact with version bumps and patched query modifications, similar to the Gemini changes in this PR.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description 'Automated ingestion of latest Fleet-maintained app data' is vague and generic. It lacks specific details about what was changed, which files were modified, or the nature of the updates. Provide more specific details about the changes, such as listing which applications were updated, what versions were bumped, and what script modifications were made to improve clarity.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Update Fleet-maintained apps' is concise and accurately describes the main changeset, which involves updating version metadata and scripts for Fleet-maintained applications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fma-2606011340

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Closing in favor of #46561.

@github-actions github-actions Bot closed this Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants