Windows FMA - Zed

[harrisonravazzolo]

Summary by CodeRabbit

• New Features
  • Added Zed support for Windows package management (new Windows package entry and metadata for v1.4.4).
  • Implemented silent install and uninstall flows for Windows with automated handling of running processes.
  • Added registry-based uninstall detection and robust exit-code handling for reliable deployments.

[claude]

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

_{Tip: disable this comment in your organization's Code Review settings.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e2fb6456-91cb-49b1-9c20-84d9d87fd3d3

📥 Commits

Reviewing files that changed from the base of the PR and between ac4d84e and 89437e2.

📒 Files selected for processing (1)

• ee/maintained-apps/inputs/winget/scripts/zed_uninstall.ps1

🚧 Files skipped from review as they are similar to previous changes (1)

• ee/maintained-apps/inputs/winget/scripts/zed_uninstall.ps1

---

Walkthrough

This pull request adds Windows installation and uninstallation support for the Zed application through Fleet's maintained-apps infrastructure. The changes include a winget package configuration file that specifies Zed's identifiers and script paths, a PowerShell installation script that silently executes the Inno Setup installer with all-users scope, a comprehensive uninstallation script that discovers Zed entries in the Windows registry, stops running processes, parses the uninstaller executable, and executes it with enforced silent flags, and compiled output files that catalog Zed as an available application and embed the installation and uninstallation scripts for managed deployment.

Possibly related PRs

• fleetdm/fleet#46401: Adds similar Windows winget installer/uninstaller PowerShell wrappers for another app using Inno Setup silent flags and exit-code handling, with comparable post-run process termination logic.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	No pull request description was provided; the PR is missing critical information about objectives, testing, and validation that the template requires.	Add a comprehensive description explaining what was changed, why, and include relevant checklist items from the template (testing, validation, issue reference).
Title check	❓ Inconclusive	The title 'Windows FMA - Zed' is partially related to the changeset, referring to a real aspect of the change (adding Zed support for Windows), but is overly abbreviated and not sufficiently descriptive of the main change.	Consider a more descriptive title like 'Add Zed Windows installer and uninstaller scripts' to clearly convey the main change.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch win-fma-zed-ide

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ee/maintained-apps/inputs/winget/scripts/zed_uninstall.ps1`:
- Around line 9-10: The uninstall matching is too broad because
$softwareNameLike = "Zed*" can match other SKUs; update the script to target the
exact product name (replace the wildcard pattern and any uses of
$softwareNameLike with an exact name variable like $softwareName = "Zed" and use
exact comparison (e.g., -eq) when filtering installed apps), and make the same
change for the other occurrences noted around the 30-34 region; keep
$publisherLike only if the publisher needs a wildcard, otherwise make it exact
(e.g., "Zed Industries") to avoid uninstalling the wrong package.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 90366b3b-5c8f-4bc5-b391-80c5940b9725

📥 Commits

Reviewing files that changed from the base of the PR and between 1f934e1 and ac4d84e.

📒 Files selected for processing (5)

• ee/maintained-apps/inputs/winget/scripts/zed_install.ps1
• ee/maintained-apps/inputs/winget/scripts/zed_uninstall.ps1
• ee/maintained-apps/inputs/winget/zed.json
• ee/maintained-apps/outputs/apps.json
• ee/maintained-apps/outputs/zed/windows.json