Windows FMA - Windsurf - #46401
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis PR adds winget support for Windsurf on Windows: a winget input manifest, a silent install PowerShell script that runs the Inno installer and treats exit codes 0/3010 as success, a registry-driven uninstall PowerShell script that locates the installed product, stops running processes, parses and enforces Inno silent flags, and maps exit codes 0/3010/1641 to success, plus updated generated outputs embedding scripts and metadata for Windsurf version 2.3.15. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ee/maintained-apps/inputs/winget/scripts/windsurf_uninstall.ps1`:
- Around line 28-31: The current guard exits if $selected.UninstallString is
missing, which incorrectly skips entries that only provide
$selected.QuietUninstallString; change the check to require neither uninstall
field is present (i.e., treat it as missing only when both
$selected.UninstallString and $selected.QuietUninstallString are null/empty).
Update the conditional that references $selected and $selected.UninstallString
to instead check both $selected.UninstallString and
$selected.QuietUninstallString before calling Write-Host/Exit so later logic can
prefer QuietUninstallString when available.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 963193f2-dd3f-4dfb-9c2e-6944b7414b2c
📒 Files selected for processing (5)
ee/maintained-apps/inputs/winget/scripts/windsurf_install.ps1ee/maintained-apps/inputs/winget/scripts/windsurf_uninstall.ps1ee/maintained-apps/inputs/winget/windsurf.jsonee/maintained-apps/outputs/apps.jsonee/maintained-apps/outputs/windsurf/windows.json
Script Diff Resultsee/maintained-apps/outputs/windsurf/windows.json=== Install Script (no changes) ===
=== Uninstall // 52e64cb5 -> bb230cc3 ===
--- /tmp/old.O2gt8d 2026-05-29 03:16:55.507705284 +0000
+++ /tmp/new.Fcp74l 2026-05-29 03:16:55.507705284 +0000
@@ -25,7 +25,7 @@
}
}
-if (-not $selected -or -not $selected.UninstallString) {
+if (-not $selected -or (-not $selected.UninstallString -and -not $selected.QuietUninstallString)) {
Write-Host "Uninstall entry not found for $softwareNameLike"
Exit 0
} |
Summary by CodeRabbit
New Features
Bug Fixes