Skip to content

Update Fleet-maintained apps - #46449

Merged
allenhouchins merged 1 commit into
mainfrom
fma-2605291343
May 29, 2026
Merged

Update Fleet-maintained apps#46449
allenhouchins merged 1 commit into
mainfrom
fma-2605291343

Conversation

@fleet-release

@fleet-release fleet-release commented May 29, 2026

Copy link
Copy Markdown
Contributor

Automated ingestion of latest Fleet-maintained app data.

Summary by CodeRabbit

  • Chores
    • Updated Joplin Windows installation and uninstallation scripts for version 3.6.14.

Review Change Stack

Generated automatically with cmd/maintained-apps.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@github-actions

Copy link
Copy Markdown
Contributor

Script Diff Results

ee/maintained-apps/outputs/joplin/windows.json

=== Install // 03dd002b -> c256db87 ===

--- /tmp/old.y8sn12	2026-05-29 13:46:31.838540312 +0000
+++ /tmp/new.JyZ4Z7	2026-05-29 13:46:31.838540312 +0000
@@ -1,12 +1,3 @@
-# Learn more about .exe install scripts:
-# http://fleetdm.com/learn-more-about/exe-install-scripts
-#
-# Joplin ships as a Nullsoft (NSIS) installer; /S runs silent.
-# /allusers forces a machine-wide install (per the winget manifest's
-# machine-scope Custom switch) -- needed because Fleet runs installs as
-# SYSTEM and the default is a per-user install that lands in the SYSTEM
-# profile.
-
 $exeFilePath = "${env:INSTALLER_PATH}"
 
 try {

=== Uninstall // a36fe00f -> 6eac6dfa ===

--- /tmp/old.7zDGQ9	2026-05-29 13:46:31.854540292 +0000
+++ /tmp/new.PvCMeo	2026-05-29 13:46:31.854540292 +0000
@@ -1,8 +1,3 @@
-# Locates Joplin's NSIS uninstaller from the registry and runs it silently.
-# Machine-scope install (/allusers) registers under HKLM; we also probe HKCU
-# in case a host has a leftover per-user install. The DisplayName includes
-# the version (e.g. "Joplin 3.6.14"), so we match with a wildcard.
-
 $displayNameLike = "Joplin*"
 $publisher = "Laurent Cozic"
 
@@ -48,8 +43,7 @@
 if ($existingArgs -notmatch '\b/S\b') {
     $existingArgs = ("$existingArgs /S").Trim()
 }
-# Mirror the install: ensure all-users uninstall so the machine-scope ARP
-# entry under HKLM is removed (not just the calling user's HKCU view).
+
 if ($existingArgs -notmatch '(?i)/allusers') {
     $existingArgs = ("$existingArgs /allusers").Trim()
 }

@coderabbitai

coderabbitai Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f1904902-0c9e-451e-b871-c79167c68c5d

📥 Commits

Reviewing files that changed from the base of the PR and between 8eae1e9 and 92034aa.

📒 Files selected for processing (1)
  • ee/maintained-apps/outputs/joplin/windows.json

Walkthrough

This PR updates the Joplin Windows maintained-app manifest to use new script reference IDs for version 3.6.14. The install_script_ref and uninstall_script_ref fields are remapped to new hash identifiers (c256db87 and 6eac6dfa), and corresponding entries in the refs map are renamed accordingly. The embedded PowerShell installer and uninstaller logic—silent installation with /S and /allusers flags, and registry-based uninstallation with process termination—remains functionally unchanged.

Possibly related PRs

  • fleetdm/fleet#45922: Updates another Windows maintained-app JSON entry to reference new installer/uninstaller script refs for a different app version, following the same manifest structure and ref-remapping pattern.
🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is minimal and doesn't follow the provided template structure with required sections like Related issue, Checklist items, Testing, or Database migrations. Expand the description to include at least the Related issue number, relevant checklist items, and confirmation that changes don't require data/schema modifications or testing.
Title check ❓ Inconclusive The title 'Update Fleet-maintained apps' is vague and generic, using non-descriptive terms that don't convey what specifically changed or why. Consider a more specific title like 'Update Joplin Windows installer scripts to version 3.6.14' that clearly indicates the main change.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fma-2605291343

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@allenhouchins
allenhouchins merged commit 7695d6c into main May 29, 2026
13 checks passed
@allenhouchins
allenhouchins deleted the fma-2605291343 branch May 29, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants