Skip to content

Update Fleet-maintained apps - #46448

Closed
fleet-release wants to merge 1 commit into
mainfrom
fma-2605291341
Closed

Update Fleet-maintained apps#46448
fleet-release wants to merge 1 commit into
mainfrom
fma-2605291341

Conversation

@fleet-release

@fleet-release fleet-release commented May 29, 2026

Copy link
Copy Markdown
Contributor

Automated ingestion of latest Fleet-maintained app data.

Summary by CodeRabbit

  • Chores
    • Updated Windows installer metadata with refreshed installation and uninstallation script references for Joplin.

Review Change Stack

Generated automatically with cmd/maintained-apps.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@github-actions

Copy link
Copy Markdown
Contributor

Closing in favor of #46449.

@github-actions github-actions Bot closed this May 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Script Diff Results

ee/maintained-apps/outputs/joplin/windows.json

=== Install // 03dd002b -> c256db87 ===

--- /tmp/old.Z5zhRK	2026-05-29 13:46:01.677788251 +0000
+++ /tmp/new.t6BNOF	2026-05-29 13:46:01.677788251 +0000
@@ -1,12 +1,3 @@
-# Learn more about .exe install scripts:
-# http://fleetdm.com/learn-more-about/exe-install-scripts
-#
-# Joplin ships as a Nullsoft (NSIS) installer; /S runs silent.
-# /allusers forces a machine-wide install (per the winget manifest's
-# machine-scope Custom switch) -- needed because Fleet runs installs as
-# SYSTEM and the default is a per-user install that lands in the SYSTEM
-# profile.
-
 $exeFilePath = "${env:INSTALLER_PATH}"
 
 try {

=== Uninstall // a36fe00f -> 6eac6dfa ===

--- /tmp/old.VoDN3P	2026-05-29 13:46:01.699788231 +0000
+++ /tmp/new.zwj1jV	2026-05-29 13:46:01.699788231 +0000
@@ -1,8 +1,3 @@
-# Locates Joplin's NSIS uninstaller from the registry and runs it silently.
-# Machine-scope install (/allusers) registers under HKLM; we also probe HKCU
-# in case a host has a leftover per-user install. The DisplayName includes
-# the version (e.g. "Joplin 3.6.14"), so we match with a wildcard.
-
 $displayNameLike = "Joplin*"
 $publisher = "Laurent Cozic"
 
@@ -48,8 +43,7 @@
 if ($existingArgs -notmatch '\b/S\b') {
     $existingArgs = ("$existingArgs /S").Trim()
 }
-# Mirror the install: ensure all-users uninstall so the machine-scope ARP
-# entry under HKLM is removed (not just the calling user's HKCU view).
+
 if ($existingArgs -notmatch '(?i)/allusers') {
     $existingArgs = ("$existingArgs /allusers").Trim()
 }

@coderabbitai

coderabbitai Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2363d4ac-6640-41c6-8cc0-b965d3388913

📥 Commits

Reviewing files that changed from the base of the PR and between 8eae1e9 and 78fefbb.

📒 Files selected for processing (1)
  • ee/maintained-apps/outputs/joplin/windows.json

Walkthrough

This PR updates the Joplin Windows installer manifest in ee/maintained-apps/outputs/joplin/windows.json. The install_script_ref and uninstall_script_ref identifiers are updated to new values (c256db87 and 6eac6dfa respectively), and the corresponding script definitions in the refs object are replaced with entries keyed by these new IDs. The underlying install and uninstall PowerShell script logic remains functionally equivalent.

Possibly related PRs

  • fleetdm/fleet#46424: Introduces the Joplin Windows FMA manifest with embedded install/uninstall PowerShell scripts; this PR updates the script references within that same manifest.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fma-2605291341

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants