Skip to content

Cherry-pick #44151: Don't ignore secrets in free tier even if exception is on - #44259

Merged
lukeheath merged 1 commit into
rc-minor-fleet-v4.85.0from
sgress454/dont-ignore-secrets-free-tier-cp
Apr 27, 2026
Merged

Cherry-pick #44151: Don't ignore secrets in free tier even if exception is on#44259
lukeheath merged 1 commit into
rc-minor-fleet-v4.85.0from
sgress454/dont-ignore-secrets-free-tier-cp

Conversation

@sgress454

Copy link
Copy Markdown
Contributor

Cherry-pick of #44151 into the RC branch.

<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** Resolves #44118 

# Details

On free tier, ignore exceptions and always apply enroll secrets when
present.

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [ ] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files)
for more information.
n/a, unreleased

## Testing

- [X] Added/updated automated tests
- [X] QA'd all new/changed functionality manually
  @AndreyKizimenko QA'd manually 

For unreleased bug fixes in a release candidate, one of:

- [X] Confirmed that the fix is not expected to adversely impact load
test results
@sgress454
sgress454 requested a review from a team as a code owner April 27, 2026 21:33

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@codecov

codecov Bot commented Apr 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (rc-minor-fleet-v4.85.0@548f4ad). Learn more about missing BASE report.

Additional details and impacted files
@@                    Coverage Diff                    @@
##             rc-minor-fleet-v4.85.0   #44259   +/-   ##
=========================================================
  Coverage                          ?   66.79%           
=========================================================
  Files                             ?     2627           
  Lines                             ?   211186           
  Branches                          ?     9421           
=========================================================
  Hits                              ?   141056           
  Misses                            ?    57310           
  Partials                          ?    12820           
Flag Coverage Δ
backend 68.56% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lukeheath
lukeheath merged commit 35fa9e0 into rc-minor-fleet-v4.85.0 Apr 27, 2026
51 checks passed
@lukeheath
lukeheath deleted the sgress454/dont-ignore-secrets-free-tier-cp branch April 27, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants