Don't ignore secrets in free tier even if exception is on - #44151
Merged
AndreyKizimenko merged 3 commits intoApr 24, 2026
Merged
Conversation
(cherry picked from commit b6e2a64)
Contributor
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
(cherry picked from commit 960c0cb)
lukeheath
approved these changes
Apr 24, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rc-minor-fleet-v4.84.0 #44151 +/- ##
=========================================================
Coverage ? 68.64%
=========================================================
Files ? 1546
Lines ? 178924
Branches ? 0
=========================================================
Hits ? 122821
Misses ? 43613
Partials ? 12490
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AndreyKizimenko
merged commit Apr 24, 2026
a118656
into
rc-minor-fleet-v4.84.0
49 of 51 checks passed
lukeheath
pushed a commit
that referenced
this pull request
Apr 27, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: Resolves #44118
Details
On free tier, ignore exceptions and always apply enroll secrets when present.
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
n/a, unreleased
Testing
@AndreyKizimenko QA'd manually
For unreleased bug fixes in a release candidate, one of: