Skip to content

Don't ignore secrets in free tier even if exception is on - #44151

Merged
AndreyKizimenko merged 3 commits into
rc-minor-fleet-v4.84.0from
sgress454/dont-ignore-secrets-on-free-tier
Apr 24, 2026
Merged

Don't ignore secrets in free tier even if exception is on#44151
AndreyKizimenko merged 3 commits into
rc-minor-fleet-v4.84.0from
sgress454/dont-ignore-secrets-on-free-tier

Conversation

@sgress454

@sgress454 sgress454 commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

Related issue: Resolves #44118

Details

On free tier, ignore exceptions and always apply enroll secrets when present.

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
    n/a, unreleased

Testing

  • Added/updated automated tests
  • QA'd all new/changed functionality manually
    @AndreyKizimenko QA'd manually

For unreleased bug fixes in a release candidate, one of:

  • Confirmed that the fix is not expected to adversely impact load test results

@sgress454
sgress454 requested a review from a team as a code owner April 24, 2026 19:20

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

(cherry picked from commit 960c0cb)
@codecov

codecov Bot commented Apr 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (rc-minor-fleet-v4.84.0@c175335). Learn more about missing BASE report.

Additional details and impacted files
@@                    Coverage Diff                    @@
##             rc-minor-fleet-v4.84.0   #44151   +/-   ##
=========================================================
  Coverage                          ?   68.64%           
=========================================================
  Files                             ?     1546           
  Lines                             ?   178924           
  Branches                          ?        0           
=========================================================
  Hits                              ?   122821           
  Misses                            ?    43613           
  Partials                          ?    12490           
Flag Coverage Δ
backend 68.64% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AndreyKizimenko
AndreyKizimenko merged commit a118656 into rc-minor-fleet-v4.84.0 Apr 24, 2026
49 of 51 checks passed
@AndreyKizimenko
AndreyKizimenko deleted the sgress454/dont-ignore-secrets-on-free-tier branch April 24, 2026 20:02
lukeheath pushed a commit that referenced this pull request Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants