Skip to content

Cherry picks for remaining Android certs backend work - #37960

Merged
getvictor merged 4 commits into
rc-minor-fleet-v4.79.0from
victor/30876-cherry-pick
Jan 7, 2026
Merged

getvictor merged 4 commits into
rc-minor-fleet-v4.79.0from
victor/30876-cherry-pick

Conversation

@getvictor

Copy link
Copy Markdown
Member

Related issue: Resolves #30876

Cherry picks:

Order Commit PR Description
1 155cd56 #37763 Add uuid column to host_certificate_templates
2 c9221b3 #37502 Set android host cert statuses on gitops delete
3 b41effa #37616 Deleting/adding Android certs to host on team transfer
4 a91bb56 #37770 Point to com.fleetdm.agent Android agent by default

getvictor and others added 4 commits January 6, 2026 18:22
<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** Resolves #37580

This migration is needed for the larger unreleased bug PR: #37616

Doing the migration separately to merge quickly and minimize merge
conflicts.

(cherry picked from commit fa9c868)
<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** Resolves #37580 

Resolves unreleased 4.79 bug and needs to be cherry picked. Also
includes fixes from manually going through the test plan at:
[#30876](#30876)

# Checklist for submitter

## Testing

- [x] Added/updated automated tests
- [x] QA'd all new/changed functionality manually

For unreleased bug fixes in a release candidate, one of:

- [x] Confirmed that the fix is not expected to adversely impact load
test results

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Release Notes

* **New Features**
* Per-template versioning and explicit operation/status fields for host
certificate templates; delivery payloads now include per-template
details.

* **Bug Fixes**
* Removal preparation broadened to also clear failed entries and handle
per-host removals; delivery/transition ordering adjusted to avoid race
conditions.

* **Tests**
* Extensive tests added for team-transfer flows, per-host
removal/preparation, and end-to-end Android certificate template
scenarios.

<sub>✏️ Tip: You can customize this high-level summary in your review
settings.</sub>
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** Resolves #37736

Enabling the public Android agent for Android MDM, by default
- `com.fleetdm.agent`

Also bug fix: [Preserve Fleet Agent in Android policy during GitOps/API
app
updates.](9b3ccf5)

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.

## Testing

- [x] Added/updated automated tests
- [x] QA'd all new/changed functionality manually

For unreleased bug fixes in a release candidate, one of:

- [x] Confirmed that the fix is not expected to adversely impact load
test results

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

## Release Notes

* **New Features**
* Added Android agent application with automatic deployment via Android
MDM to support SCEP certificate management on Android devices.
* Introduced configurable Android agent settings for package name and
signing certificate.

* **Documentation**
* Updated Android MDM configuration documentation with environment
variable and YAML configuration examples for Android agent deployment.

<sub>✏️ Tip: You can customize this high-level summary in your review
settings.</sub>

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

(cherry picked from commit 9bf2789)
@getvictor
getvictor marked this pull request as ready for review January 7, 2026 01:04
@getvictor
getvictor requested a review from a team as a code owner January 7, 2026 01:04
@codecov

codecov Bot commented Jan 7, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.52850% with 26 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (rc-minor-fleet-v4.79.0@b66d1a6). Learn more about missing BASE report.

Files with missing lines Patch % Lines
server/worker/software_worker.go 36.36% 3 Missing and 4 partials ⚠️
...rver/datastore/mysql/host_certificate_templates.go 92.10% 4 Missing and 2 partials ⚠️
...0251229000000_AddUUIDToHostCertificateTemplates.go 66.66% 3 Missing and 1 partial ⚠️
cmd/fleet/serve.go 0.00% 3 Missing ⚠️
server/mdm/android/service/profiles.go 84.61% 2 Missing ⚠️
server/service/certificates.go 66.66% 1 Missing and 1 partial ⚠️
cmd/fleet/cron.go 0.00% 1 Missing ⚠️
server/mdm/android/service/service.go 96.77% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##             rc-minor-fleet-v4.79.0   #37960   +/-   ##
=========================================================
  Coverage                          ?   64.22%           
=========================================================
  Files                             ?     2357           
  Lines                             ?   187321           
  Branches                          ?     7949           
=========================================================
  Hits                              ?   120307           
  Misses                            ?    55856           
  Partials                          ?    11158           
Flag Coverage Δ
android 22.03% <ø> (?)
backend 65.77% <86.52%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@getvictor getvictor linked an issue Jan 7, 2026 that may be closed by this pull request
49 of 55 tasks
@getvictor
getvictor merged commit dcae524 into rc-minor-fleet-v4.79.0 Jan 7, 2026
49 of 52 checks passed
@getvictor
getvictor deleted the victor/30876-cherry-pick branch January 7, 2026 03:30

This branch was previously deployed

1 inactive deployment
Docker Hub — a91bb562 Deployed Jan 7, 2026 by getvictor via publish #73576
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deploy/delete certificates on Android hosts via UI/API

3 participants