Skip to content

Set android host cert statuses on gitops delete - #37502

Merged
mostlikelee merged 26 commits into
mainfrom
36783-delete-gitops
Dec 19, 2025
Merged

mostlikelee merged 26 commits into
mainfrom
36783-delete-gitops

Conversation

@mostlikelee

Copy link
Copy Markdown
Contributor

Related issue: Resolves #36783

Using existing pattern of deleting/setting host certificate templates on the spec endpoint for gitops.

  • Added/updated automated tests

@codecov

codecov Bot commented Dec 18, 2025 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.96%. Comparing base (8774833) to head (d28a864).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
server/service/certificates.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #37502      +/-   ##
==========================================
+ Coverage   65.94%   65.96%   +0.01%     
==========================================
  Files        2356     2355       -1     
  Lines      186897   186710     -187     
  Branches     7969     7789     -180     
==========================================
- Hits       123250   123158      -92     
+ Misses      52391    52293      -98     
- Partials    11256    11259       +3     
Flag Coverage Δ
backend 67.76% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mostlikelee
mostlikelee marked this pull request as ready for review December 19, 2025 23:46
@mostlikelee
mostlikelee requested a review from a team as a code owner December 19, 2025 23:46
@mostlikelee
mostlikelee merged commit e68cc1a into main Dec 19, 2025
50 checks passed
@mostlikelee
mostlikelee deleted the 36783-delete-gitops branch December 19, 2025 23:54
getvictor added a commit that referenced this pull request Jan 7, 2026
<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** Resolves #30876

Cherry picks:

| Order | Commit | PR | Description |

|-------|------------|--------|--------------------------------------------------------|
| 1 | 155cd56 | #37763 | Add uuid column to
host_certificate_templates |
| 2 | c9221b3 | #37502 | Set android host cert statuses on gitops
delete |
| 3 | b41effa | #37616 | Deleting/adding Android certs to host on
team transfer |
| 4 | a91bb56 | #37770 | Point to com.fleetdm.agent Android agent by
default |

---------

Co-authored-by: Tim Lee <timlee@fleetdm.com>

This branch was previously deployed

1 inactive deployment
Docker Hub — d28a8646 Deployed Dec 19, 2025 by mostlikelee via publish #72732
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android certs: delete (gitops)

2 participants