Skip to content

My device page (self-service) for iOS/iPadOS - #35238

Merged
cdcme merged 13 commits into
mainfrom
feat-32247-ios-ipados-self-service
Nov 7, 2025
Merged

My device page (self-service) for iOS/iPadOS#35238
cdcme merged 13 commits into
mainfrom
feat-32247-ios-ipados-self-service

Conversation

@cdcme

@cdcme cdcme commented Nov 5, 2025

Copy link
Copy Markdown
Member

jkatz01 and others added 7 commits October 31, 2025 11:40
**Related issue:** Resolves #34257 
TestIntegrationsMDM/TestVPPAppInstallVerification should fail since
ios/ipados device authentication isn't merged yet. Will need to be
updated and test should pass after that happens and the test is updated.

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [ ] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files)
for more information.

- [ ] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements)
- [ ] If paths of existing endpoints are modified without backwards
compatibility, checked the frontend/CLI for any necessary changes

## Testing

- [x] Added/updated automated tests
- [x] Where appropriate, [automated tests simulate multiple hosts and
test for host
isolation](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/reference/patterns-backend.md#unit-testing)
(updates to one hosts's records do not affect another)

- [x] QA'd all new/changed functionality manually
Implements #34258. Adds certificate authentication for the My Device page on iOS/iPadOS.
)

## Testing

- [x] Added/updated automated tests
- [x] Where appropriate, [automated tests simulate multiple hosts and
test for host
isolation](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/reference/patterns-backend.md#unit-testing)
(updates to one hosts's records do not affect another)

- [ ] QA'd all new/changed functionality manually
@cdcme
cdcme marked this pull request as ready for review November 5, 2025 20:26
@cdcme
cdcme requested review from a team as code owners November 5, 2025 20:26
@RachelElysia

RachelElysia commented Nov 6, 2025

Copy link
Copy Markdown
Member

@cdcme re: merge conflicts, I don't know the best way to resolve them with git

Here's the FE choices:

  1. This tooltip thing needs to be reworked after this is merged, so for now accept the code on main knowing that it's undoing my "if this is mobile, show the tooltip onClick" work and I can do a followup PR as an unreleased bug for that part of the feature due to this conflict
Screenshot 2025-11-06 at 5 32 08 PM
  1. This branch just needs the || enrolUrlError added to it
Screenshot 2025-11-06 at 5 29 55 PM
  1. Accept the code on main
Screenshot 2025-11-06 at 5 28 42 PM

cdcme and others added 2 commits November 7, 2025 14:28
Fixes cert-based auth to do device lookup using the correct tables
@codecov

codecov Bot commented Nov 7, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.63889% with 75 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.14%. Comparing base (68d236a) to head (65a1cbb).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...reTitleDetailsPage/EditIconModal/EditIconModal.tsx 33.33% 9 Missing and 1 partial ⚠️
...e/components/SelfServiceTiles/SelfServiceTiles.tsx 23.07% 10 Missing ⚠️
server/datastore/mysql/host_identity_scep.go 67.74% 8 Missing and 2 partials ⚠️
...details/cards/Software/SelfService/SelfService.tsx 35.71% 9 Missing ⚠️
...end/components/DeviceUserError/DeviceUserError.tsx 53.33% 7 Missing ⚠️
...re/SelfService/SelfServiceCard/SelfServiceCard.tsx 64.70% 6 Missing ⚠️
...bles/20251107164629_AddSelfServiceToInHouseApps.go 66.66% 4 Missing and 2 partials ⚠️
frontend/hooks/useIsMobileWidth.tsx 76.47% 4 Missing ⚠️
ee/server/service/software_installers.go 90.00% 2 Missing and 1 partial ⚠️
...es/hosts/details/DeviceUserPage/DeviceUserPage.tsx 80.00% 3 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #35238      +/-   ##
==========================================
+ Coverage   66.11%   66.14%   +0.03%     
==========================================
  Files        2086     2095       +9     
  Lines      176703   177028     +325     
  Branches     7316     7393      +77     
==========================================
+ Hits       116821   117097     +276     
- Misses      49154    49198      +44     
- Partials    10728    10733       +5     
Flag Coverage Δ
backend 67.80% <90.72%> (+0.03%) ⬆️
frontend 53.65% <71.73%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sgress454 sgress454 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 as this is a merge of previously approved. I did a quick scan for merge conflicts and didn't see any.

@cdcme
cdcme merged commit 715d963 into main Nov 7, 2025
44 checks passed
@cdcme
cdcme deleted the feat-32247-ios-ipados-self-service branch November 7, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants