My device page (self-service) for iOS/iPadOS - #35238
Merged
Merged
Conversation
**Related issue:** Resolves #34257 TestIntegrationsMDM/TestVPPAppInstallVerification should fail since ios/ipados device authentication isn't merged yet. Will need to be updated and test should pass after that happens and the test is updated. # Checklist for submitter If some of the following don't apply, delete the relevant line. - [ ] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files) for more information. - [ ] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) - [ ] If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes ## Testing - [x] Added/updated automated tests - [x] Where appropriate, [automated tests simulate multiple hosts and test for host isolation](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/reference/patterns-backend.md#unit-testing) (updates to one hosts's records do not affect another) - [x] QA'd all new/changed functionality manually
Implements #34258. Adds certificate authentication for the My Device page on iOS/iPadOS.
…nges" This reverts commit d05affa.
) ## Testing - [x] Added/updated automated tests - [x] Where appropriate, [automated tests simulate multiple hosts and test for host isolation](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/reference/patterns-backend.md#unit-testing) (updates to one hosts's records do not affect another) - [ ] QA'd all new/changed functionality manually
cdcme
marked this pull request as ready for review
November 5, 2025 20:26
Member
|
@cdcme re: merge conflicts, I don't know the best way to resolve them with Here's the FE choices:
|
Fixes cert-based auth to do device lookup using the correct tables
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #35238 +/- ##
==========================================
+ Coverage 66.11% 66.14% +0.03%
==========================================
Files 2086 2095 +9
Lines 176703 177028 +325
Branches 7316 7393 +77
==========================================
+ Hits 116821 117097 +276
- Misses 49154 49198 +44
- Partials 10728 10733 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sgress454
approved these changes
Nov 7, 2025
sgress454
left a comment
Contributor
There was a problem hiding this comment.
+1 as this is a merge of previously approved. I did a quick scan for merge conflicts and didn't see any.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Implements #32247. This is the complete feature branch, consolidating: