34257 ios self service vpp - #35018
Merged
jkatz01 merged 8 commits intoOct 31, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat-32247-ios-ipados-self-service #35018 +/- ##
======================================================================
- Coverage 66.21% 62.61% -3.61%
======================================================================
Files 2073 2073
Lines 174776 174778 +2
Branches 7095 7095
======================================================================
- Hits 115732 109434 -6298
- Misses 48411 55280 +6869
+ Partials 10633 10064 -569
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jkatz01
marked this pull request as ready for review
October 31, 2025 14:10
jkatz01
merged commit Oct 31, 2025
601ccdb
into
feat-32247-ios-ipados-self-service
36 of 39 checks passed
16 tasks
cdcme
added a commit
that referenced
this pull request
Nov 7, 2025
Implements #32247. This is the complete feature branch, consolidating: - #35018 - #34758 - #35009 - #35181 - #35342 --------- Co-authored-by: Jonathan Katz <44128041+jkatz01@users.noreply.github.com> Co-authored-by: RachelElysia <71795832+RachelElysia@users.noreply.github.com> Co-authored-by: Martin Angers <martin.n.angers@gmail.com> Co-authored-by: jkatz01 <yehonatankatz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: Resolves #34257
TestIntegrationsMDM/TestVPPAppInstallVerification should fail since ios/ipados device authentication isn't merged yet. Will need to be updated and test should pass after that happens and the test is updated.
Checklist for submitter
If some of the following don't apply, delete the relevant line.
Changes file added for user-visible changes in
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
Input data is properly validated,
SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements)If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes
Testing
Added/updated automated tests
Where appropriate, automated tests simulate multiple hosts and test for host isolation (updates to one hosts's records do not affect another)
QA'd all new/changed functionality manually