Skip to content

[DO NOT MERGE]: temp branch to start gitops of ipa installers before ipa self-service is ready - #35164

Closed
mna wants to merge 27 commits into
mainfrom
mna-33164-temporary-from-mna-34274-self-service-ipa-good
Closed

[DO NOT MERGE]: temp branch to start gitops of ipa installers before ipa self-service is ready#35164
mna wants to merge 27 commits into
mainfrom
mna-33164-temporary-from-mna-34274-self-service-ipa-good

Conversation

@mna

@mna mna commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

Was cut from mna-34274-self-service-ipa-good (#35099), first commit for this ticket was f5b6f50 ("Add gitops tests with ipa software installer").

jkatz01 and others added 12 commits October 31, 2025 11:40
**Related issue:** Resolves #34257 
TestIntegrationsMDM/TestVPPAppInstallVerification should fail since
ios/ipados device authentication isn't merged yet. Will need to be
updated and test should pass after that happens and the test is updated.

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [ ] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files)
for more information.

- [ ] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements)
- [ ] If paths of existing endpoints are modified without backwards
compatibility, checked the frontend/CLI for any necessary changes

## Testing

- [x] Added/updated automated tests
- [x] Where appropriate, [automated tests simulate multiple hosts and
test for host
isolation](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/reference/patterns-backend.md#unit-testing)
(updates to one hosts's records do not affect another)

- [x] QA'd all new/changed functionality manually
Implements #34258. Adds certificate authentication for the My Device page on iOS/iPadOS.
@mna
mna force-pushed the mna-33164-temporary-from-mna-34274-self-service-ipa-good branch from 15f0468 to 6aa0d2d Compare November 4, 2025 19:02
@codecov

codecov Bot commented Nov 4, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 63.16425% with 305 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.38%. Comparing base (cf55977) to head (8524050).
⚠️ Report is 226 commits behind head on main.

Files with missing lines Patch % Lines
server/datastore/mysql/in_house_apps.go 55.64% 217 Missing and 7 partials ⚠️
ee/server/service/software_installers.go 67.61% 26 Missing and 8 partials ⚠️
server/datastore/mysql/software.go 62.22% 16 Missing and 1 partial ⚠️
...bles/20251028140720_AddSelfServiceToInHouseApps.go 11.11% 16 Missing ⚠️
...tions/tables/20251104090013_AddUrlToInHouseApps.go 16.66% 10 Missing ⚠️
server/datastore/mysql/software_installers.go 96.00% 0 Missing and 2 partials ⚠️
server/service/devices.go 93.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #35164      +/-   ##
==========================================
- Coverage   66.21%   59.38%   -6.84%     
==========================================
  Files        2073     2076       +3     
  Lines      174780   175452     +672     
  Branches     7194     7173      -21     
==========================================
- Hits       115738   104198   -11540     
- Misses      48408    61508   +13100     
+ Partials    10634     9746     -888     
Flag Coverage Δ
backend 60.07% <63.16%> (-7.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from feat-32247-ios-ipados-self-service to main November 7, 2025 22:30
@mna mna closed this Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants