IPA: add support of ipa to unified queue (partial) - #34005
Conversation
|
|
||
| // TODO(sarah): do we need to handle host_deleted_at similar to GetSummaryHostSoftwareInstalls? | ||
| // Currently there is no host_deleted_at in host_vpp_software_installs, so | ||
| // not handling it as part of the unified queue work. |
There was a problem hiding this comment.
We do soft-deletes for host software installs because the row contains the execution result (exit code, script outputs, etc.) needed for the past activity when clicking on "Details" (those activities outlive the host), but for MDM-command-based installs (VPP and In-House), the past activity contains the MDM command uuid so my understanding is that it doesn't need the host vpp installs/host in-house installs row at all.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feat-in-house-apps #34005 +/- ##
=====================================================
Coverage ? 64.14%
=====================================================
Files ? 2056
Lines ? 206801
Branches ? 6754
=====================================================
Hits ? 132644
Misses ? 63745
Partials ? 10412
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
Related issue: Partial #33086
Checklist for submitter
SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements)Testing
I haven't added tests yet as too many things are missing (enqueue an IPA install request, XML of the command, etc.), I'll circle back to it later when more of the story is implemented - noted as todo in the ticket).