Skip to content

chore(workbench): sync T3 Code upstream through e1f33e0 - #163

Merged
filipgutica merged 15 commits into
mainfrom
chore/upstream-sync-20261018b
Oct 18, 2026
Merged

filipgutica merged 15 commits into
mainfrom
chore/upstream-sync-20261018b

Conversation

@filipgutica

Copy link
Copy Markdown
Owner

Sync T3 Code upstream through e1f33e023c804226671736828b7d25e502bdb1db, 12 commits after #159. This brings in the rest of upstream's web performance work, including faster thread switching, and the fix for slow startup on large databases (pingdotgg#21122). Merge with a merge commit (gh pr merge --merge), not squash.

Changes

Upstream commits imported

Conflict resolutions

  • ChatMarkdown.browser.test.tsx: took upstream's comment. The code it describes is identical on both sides.
  • CommandPalette.tsx: kept the Workbench useVisibleThreads filter. Dropped projectOrder, which upstream no longer reads at that site.
  • LinkPullRequestDialog.tsx: upstream moved resolveLinkPullRequestInput and the project resolver into @t3tools/client-runtime/pull-request-link-input. The dialog now uses that module, and the fork's duplicated copies are deleted. Workbench PR browsing and number search are unchanged. The one fork-specific error message gives way to upstream's wording, so the shared module stays unpatched.
  • pnpm-lock.yaml: merged automatically. vp i ran on the merged tree.
  • The CI ownership baseline now points to the pinned upstream SHA.
  • The iOS segmented-control exclusion from chore(workbench): sync T3 Code upstream through 6a6ebb2 #159 still holds. No upstream commit in this range touches those files.

Verification

  • Tests:
    • Unit: 80 passed, covering pullRequestLinkInput, threadPullRequestListLines, the dialog input tests, both command palette suites, and WorkbenchLinkPullRequest.
    • Browser: ChatMarkdown.browser.test.tsx, 69 passed.
  • Typechecks: web, mobile, Workbench and client-runtime are clean.
  • CI and isolation: node scripts/workbench-ci.ts --lint exits 0, with existing warnings only. --check and node scripts/workbench-isolation.ts pass.
  • Fallow: fallow audit --base origin/main passes with nothing new introduced.
  • After merge: confirm git merge-base --is-ancestor e1f33e023c origin/main.

Implemented with Claude Opus 5.5 in the Claude Code harness.

juliusmarminge and others added 13 commits October 17, 2026 23:31
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
pingdotgg#19697)

Co-authored-by: Nikita Maximilian Grimm <github@nikitagrimm.de>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…us returns (pingdotgg#21118)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…n unchanged preview list (pingdotgg#21130)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…nutes (pingdotgg#21122)

Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…'s rows (pingdotgg#21123)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…21146)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…21147)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Merge upstream pingdotgg/t3code e1f33e0. The PR dialog uses upstream's shared link-input module and keeps Workbench PR browsing; the command palette keeps its visible-Thread filter.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-18T15:54:47.669093Z 45d450e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL labels Oct 18, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 45d450e2c2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/web/src/components/CommandPalette.tsx Outdated
Comment thread apps/mobile/src/features/threads/thread-list-v2-items.tsx
Upstream moved project sorting into a helper that reads every Thread, so hidden Workbench preparation Threads could reorder projects and change the default for New thread in. Apply the visible-Thread filter there too.
@github-actions

Copy link
Copy Markdown

Workbench demo

Open the private 20-minute demo. Sign in to Vercel, then choose Open demo. Reopening this link in the same browser resumes its running demo; Start new demo creates a fresh one. Jira starts disconnected.

Application, runtime startup, fixtures, and native smoke: PR 4b88124c31ebcb56a0ee6a0d5f0b6a290536a481. Dockerfile, build configuration, bundle export, publisher, and protected launcher: main 92e5ac05a8a88a7b624399d6a9d027c025e71cff.

Expired? Return to this link and launch again. Use synthetic content with the free OpenCode model.

@filipgutica
filipgutica merged commit 238144c into main Oct 18, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants