Skip to content

chore(workbench): sync T3 Code upstream through 6a6ebb2 - #159

Merged
filipgutica merged 418 commits into
mainfrom
chore/upstream-sync-20261018
Oct 18, 2026
Merged

filipgutica merged 418 commits into
mainfrom
chore/upstream-sync-20261018

Conversation

@filipgutica

Copy link
Copy Markdown
Owner

Sync T3 Code upstream through 6a6ebb278dc70dd859439a3c28960a7d23a1e645 (409 upstream commits) while keeping upstream ancestry and the Workbench overlay. Replaces closed #144. Merge with a merge commit (gh pr merge --merge), not squash.

Changes

Merge (d89c335)

  • Resolved 24 conflicts, all in apps/web plus pnpm-lock.yaml. Each resolution keeps upstream behavior and reapplies the existing Workbench integration:
    • ChatView: kept upstream's extracted right panel, which moved the fork's panel integration into RightPanelSurfaceContent and useProactivePanels.
    • PR panels and dialog: kept PR browsing, number search and URL acceptance, focused review threads, and remote-checkout safeguards.
    • Sidebar and command palette: kept visible-Thread filtering, Workbench execution status, and host utility pages.
    • Update paths: kept Workbench release links and the npm-update restriction.
    • Upstream test migration: upstream moved several unit tests to browser suites. Fork regression cases moved into the new browser suites.
  • Regenerated pnpm-lock.yaml with vp i instead of merging it by hand.
  • Left out upstream e58a485 (native iOS segmented controls), as chore: sync T3 Code upstream #144 did. iOS keeps the shared control with option-specific spoken labels, selection state and tab roles. Upstream's native wrapper still passes neither. The follow-up 79ad856 touches only the removed implementation.
  • Advanced the CI ownership baseline to the pinned upstream SHA.

Follow-up repairs (292e4ae)

  • Added CI ownership entries for the extracted RightPanelSurfaceContent and useProactivePanels integrations and for the retained mobile controls and PR actions. Added mobile typecheck routing and the rerun-failed-checks label and icon entries.
  • Install Chromium before the integration job's browser tests and the sync workflow's integration tests.
  • Kept the web test dependencies that fork tests still use. Pointed fork mocks at upstream's new atom config owner.
  • Did not port chore: sync T3 Code upstream #144's workbench-upstream-sync-merge.ts changes. ci(workbench): make upstream sync publish reliably and gate fully #145 already covers merge-ref readiness and dispatch recovery.

Verification

  • vp run --filter @t3tools/workbench typecheck (including the package boundary), plus the web, server (t3) and mobile typechecks, passed.
  • vp run --filter @t3tools/desktop smoke-test passed.
  • Six conflicted browser suites passed: 217 tests.
  • 21 focused conflict and unit suites passed: 559 tests.
  • The CI, sync and isolation suites passed: scripts/workbench-ci.test.ts, workbench-upstream-sync*.test.ts and scripts/lib/workbench-isolation.test.ts.
  • node scripts/workbench-ci.ts --check and node scripts/workbench-isolation.ts passed at 292e4ae.
  • The only files that now differ from upstream without a prior fork change are the planned exclusions above, the migrated browser tests, and the two extracted integration points. The format hook rewrote no upstream file.
  • Confirm after merge: git merge-base --is-ancestor 6a6ebb278dc70dd859439a3c28960a7d23a1e645 origin/main.

Limits

  • No live client pass yet. A demo spot check follows the merge.

Implemented with GPT-6.1-Sol in the Codex harness. Committed and published with Claude Opus 5.5 in the Claude Code harness.

juliusmarminge and others added 30 commits October 16, 2026 21:54
…on (pingdotgg#20673)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ion (pingdotgg#20672)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…moization (pingdotgg#20671)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ion (pingdotgg#20666)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…er (pingdotgg#20664)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…oization (pingdotgg#20663)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…zation (pingdotgg#20661)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…tion (pingdotgg#20660)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…oization (pingdotgg#20659)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…on (pingdotgg#20658)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ion (pingdotgg#20657)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…g#20656)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…tgg#20655)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…otgg#20654)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…tgg#20652)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…g#20651)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
… memoization (pingdotgg#20649)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…gg#20644)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
juliusmarminge and others added 6 commits October 17, 2026 20:12
…g#20969)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…tgg#20971)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Merge upstream pingdotgg/t3code 6a6ebb2 into the Workbench fork. Excludes upstream e58a485 (native iOS segmented controls) so iOS keeps the shared accessible control.
…eam sync

Own the extracted RightPanelSurfaceContent and useProactivePanels integrations and the retained mobile controls and PR actions. Route mobile typechecks, install Chromium before migrated browser tests, keep fork-only web test dependencies, and point fork mocks at upstream's atom config owner.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-18T06:29:21.766236Z 8dce60e Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL labels Oct 18, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 292e4ae0aa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/workbench-ci-scope.json
@github-actions

github-actions Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Workbench demo

Open the private 20-minute demo. Sign in to Vercel, then choose Open demo. Reopening this link in the same browser resumes its running demo; Start new demo creates a fresh one. Jira starts disconnected.

Application, runtime startup, fixtures, and native smoke: PR 8dce60e69c00d88d48c2ca03779d4b7ae07a80e6. Dockerfile, build configuration, bundle export, publisher, and protected launcher: main 01cc135c82eebe430a3d099b845995f9cd7579be.

Expired? Return to this link and launch again. Use synthetic content with the free OpenCode model.

The sync's regenerated lockfile resolved @vitest/browser-playwright to Playwright 1.63.0 via the site's @playwright/test pin, while CI installs Chromium for apps/web's 1.60.0. Pin the site to 1.60.0 so every consumer resolves upstream's version.

Copy link
Copy Markdown
Owner Author

@codex review

Please review exact head b6a08d7f68a1be553fb4dbc1f0f903e55ed6d562 against base 01cc135c82eebe430a3d099b845995f9cd7579be for the daily upstream compatibility review. The prior automatic review predates the follow-up repairs.

Independent native/state, client and CI/distribution audits found no confirmed defects in their inspected Workbench boundaries. The cloud review passed 277 focused compatibility tests plus 49 migration, composition, sync and isolation tests, Workbench/contracts typechecks and the package/host import gates. This is review-only; no merge, release or upstream-sync workflow dispatch is authorized.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: b6a08d7f68

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

filipgutica and others added 2 commits October 17, 2026 23:06
…ut test

The case dispatches Cmd+Shift+K, which only matches the shortcut on macOS; CI runs the browser suite on Linux.

Copy link
Copy Markdown
Owner Author

@codex review

Please review exact head 88b1dc09257f5997c51c9b0baf2e18fec947728e against base 01cc135c82eebe430a3d099b845995f9cd7579be.

Since the prior reviewed head, the owner restored the Mac platform fixture for the migrated PR-number shortcut test. At the user's request, the one-line desktop smoke routing fix is now included directly in this PR: chore/upstream-sync-* branches run the existing smoke job. The existing event guard and prior branch alternatives remain intact. Independent review and Test Audit found no issues in these two focused changes. Please keep this review read-only; no merge, release or upstream-sync publisher dispatch.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 88b1dc0925

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Owner Author

@codex review

Please review exact head 8dce60e69c00d88d48c2ca03779d4b7ae07a80e6 against base 01cc135c82eebe430a3d099b845995f9cd7579be.

Since the prior reviewed head, this adds only a test synchronization repair in ChatMarkdown.browser.test.tsx. After the existing animation-frame wait, the same exact highlight-text assertion now uses vi.waitFor and rereads the current highlight registry each attempt. All table cases and the separate indexed-occurrence assertion remain intact. No production code changed.

The baseline integration run failed the Mermaid case with an empty live Range. Independent Test Audit found no weakened assertions or new seams. Seventeen focused search/indexing tests, targeted formatting, the generated CI check and Workbench host boundary passed locally; corrected Chromium execution is pending hosted CI.

Keep this review read-only. This significant upstream sync returns for user review; do not merge or dispatch releases.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: 8dce60e69c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants