Repository navigation
chore(workbench): sync T3 Code upstream through 6a6ebb2 - #159
Conversation
…ingdotgg#20675) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…on (pingdotgg#20673) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ion (pingdotgg#20672) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…moization (pingdotgg#20671) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ngdotgg#20670) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
pingdotgg#20669) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…pingdotgg#20668) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ingdotgg#20667) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ion (pingdotgg#20666) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ingdotgg#20665) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…er (pingdotgg#20664) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…oization (pingdotgg#20663) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…dotgg#20662) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…zation (pingdotgg#20661) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…tion (pingdotgg#20660) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…oization (pingdotgg#20659) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…on (pingdotgg#20658) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ion (pingdotgg#20657) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…g#20656) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…tgg#20655) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…otgg#20654) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…gdotgg#20653) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…tgg#20652) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…g#20651) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…pingdotgg#20650) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
… memoization (pingdotgg#20649) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ngdotgg#20648) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ingdotgg#20647) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ingdotgg#20646) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…gg#20644) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…g#20969) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ngdotgg#20970) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…tgg#20971) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…eam sync Own the extracted RightPanelSurfaceContent and useProactivePanels integrations and the retained mobile controls and PR actions. Route mobile typechecks, install Chromium before migrated browser tests, keep fork-only web test dependencies, and point fork mocks at upstream's atom config owner.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 292e4ae0aa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Workbench demoOpen the private 20-minute demo. Sign in to Vercel, then choose Open demo. Reopening this link in the same browser resumes its running demo; Start new demo creates a fresh one. Jira starts disconnected. Application, runtime startup, fixtures, and native smoke: PR Expired? Return to this link and launch again. Use synthetic content with the free OpenCode model. |
The sync's regenerated lockfile resolved @vitest/browser-playwright to Playwright 1.63.0 via the site's @playwright/test pin, while CI installs Chromium for apps/web's 1.60.0. Pin the site to 1.60.0 so every consumer resolves upstream's version.
|
@codex review Please review exact head Independent native/state, client and CI/distribution audits found no confirmed defects in their inspected Workbench boundaries. The cloud review passed 277 focused compatibility tests plus 49 migration, composition, sync and isolation tests, Workbench/contracts typechecks and the package/host import gates. This is review-only; no merge, release or upstream-sync workflow dispatch is authorized. |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…ut test The case dispatches Cmd+Shift+K, which only matches the shortcut on macOS; CI runs the browser suite on Linux.
|
@codex review Please review exact head Since the prior reviewed head, the owner restored the Mac platform fixture for the migrated PR-number shortcut test. At the user's request, the one-line desktop smoke routing fix is now included directly in this PR: |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review Please review exact head Since the prior reviewed head, this adds only a test synchronization repair in The baseline integration run failed the Mermaid case with an empty live Range. Independent Test Audit found no weakened assertions or new seams. Seventeen focused search/indexing tests, targeted formatting, the generated CI check and Workbench host boundary passed locally; corrected Chromium execution is pending hosted CI. Keep this review read-only. This significant upstream sync returns for user review; do not merge or dispatch releases. |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Sync T3 Code upstream through
6a6ebb278dc70dd859439a3c28960a7d23a1e645(409 upstream commits) while keeping upstream ancestry and the Workbench overlay. Replaces closed #144. Merge with a merge commit (gh pr merge --merge), not squash.Changes
Merge (
d89c335)apps/webpluspnpm-lock.yaml. Each resolution keeps upstream behavior and reapplies the existing Workbench integration:RightPanelSurfaceContentanduseProactivePanels.pnpm-lock.yamlwithvp iinstead of merging it by hand.e58a485(native iOS segmented controls), as chore: sync T3 Code upstream #144 did. iOS keeps the shared control with option-specific spoken labels, selection state and tab roles. Upstream's native wrapper still passes neither. The follow-up79ad856touches only the removed implementation.Follow-up repairs (
292e4ae)RightPanelSurfaceContentanduseProactivePanelsintegrations and for the retained mobile controls and PR actions. Added mobile typecheck routing and thererun-failed-checkslabel and icon entries.workbench-upstream-sync-merge.tschanges. ci(workbench): make upstream sync publish reliably and gate fully #145 already covers merge-ref readiness and dispatch recovery.Verification
vp run --filter @t3tools/workbench typecheck(including the package boundary), plus the web, server (t3) and mobile typechecks, passed.vp run --filter @t3tools/desktop smoke-testpassed.scripts/workbench-ci.test.ts,workbench-upstream-sync*.test.tsandscripts/lib/workbench-isolation.test.ts.node scripts/workbench-ci.ts --checkandnode scripts/workbench-isolation.tspassed at292e4ae.git merge-base --is-ancestor 6a6ebb278dc70dd859439a3c28960a7d23a1e645 origin/main.Limits
Implemented with GPT-6.1-Sol in the Codex harness. Committed and published with Claude Opus 5.5 in the Claude Code harness.