test(main-page): drop assertions for the removed empty-state headline - #2388
Closed
uuzzrm wants to merge 1 commit into
Closed
test(main-page): drop assertions for the removed empty-state headline#2388uuzzrm wants to merge 1 commit into
uuzzrm wants to merge 1 commit into
Conversation
48267e5 ("Remove unnecessary headline") removed the visible value-proposition text ("Private AI search: answers with sources, on your own instance.") from the MainPage empty state, but left the two tests asserting it behind -- they have been failing on every PR since, since the text only ever existed in the test itself. The remaining value proposition is the visually-hidden h1, which is already covered by the "renders a visually-hidden h1" test in this file. Signed-off-by: uuzzrm <uuzzrm@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Commit
48267e53("Remove unnecessary headline") removed the visible value-proposition text ("Private AI search: answers with sources, on your own instance.") from the MainPage empty state, but left the two tests asserting it behind. They have been failing on every PR since (the text only ever existed in the test itself), including the current IME fix PR #2385 and the eval PR #2382.The remaining value proposition is the visually-hidden h1 ("MiniSearch — Private AI search with sources"), which is already covered by the "renders a visually-hidden h1" test in this same file.
Test plan
Removed 2 obsolete assertions; the 12 remaining tests all pass.