test(main-page): drop stale value-proposition assertions - #2386
Merged
Conversation
Signed-off-by: Ruiming Zhao <uuzzrm@gmail.com>
This was referenced Aug 15, 2026
Contributor
Author
|
Hey - quick note that #2388 (identical change, same two test deletions) was merged a few minutes ago, so this PR is now redundant. Closing to keep the queue tidy. Thanks for the fast merge! |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
48267e5("Remove unnecessary headline") removed the empty-state headline fromMainPage.tsx:but left the two tests that assert that text behind. The positive one ("shows the value proposition in the empty state") has been failing consistently since — locally and in CI (
build-testonmainis red for it) — and the negative one now tests a feature that no longer exists, so it passes only because the text is never rendered.This removes both stale test cases.
Test plan
npx vitest run client/components/Pages/Main/MainPage.test.tsx→ 12 pass (was 13 pass + 1 fail)npx vitest run→ no new failures (the only 2 remaining failures locally are the doc-validator/doc-gardening script tests, which fail on this Windows checkout regardless of any change — they pass on CI)Nothing else references the removed text.