[flow] Replace $PropertyType with indexed access type in ReactNativeTypes#32733
Merged
SamChou19815 merged 1 commit intomainfrom Mar 25, 2025
Merged
[flow] Replace $PropertyType with indexed access type in ReactNativeTypes#32733SamChou19815 merged 1 commit intomainfrom
SamChou19815 merged 1 commit intomainfrom
Conversation
…ypes Replace these deprecated types to prepare for removal of support in Flow.
|
Comparing: e5f275e...5c5dda8 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Mar 26, 2025
Summary: Pull Request resolved: #50271 In the next version of Flow, support for `$PropertyType` will be removed in favor of indexed access types. The final 2 usages in react-native is in `ReactNativeTypes`, which is synced from upstream react. Sync of facebook/react#32733 is currently blocked by test failures, so I will add the temporary shim to unblock releases. Changelog: [Internal] Reviewed By: panagosg7 Differential Revision: D71849353 fbshipit-source-id: d4787fe17ae52aa50d54f9fb7fb8b14c149aa1e6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace these deprecated types to prepare for removal of support in Flow.
How did you test this change?
flow