Shim $PropertyType in react-native for now#50271
Closed
SamChou19815 wants to merge 1 commit intofacebook:mainfrom
SamChou19815:export-D71849353
Closed
Shim $PropertyType in react-native for now#50271SamChou19815 wants to merge 1 commit intofacebook:mainfrom SamChou19815:export-D71849353
$PropertyType in react-native for now#50271SamChou19815 wants to merge 1 commit intofacebook:mainfrom
SamChou19815:export-D71849353
Conversation
Summary: In the next version of Flow, support for `$PropertyType` will be removed in favor of indexed access types. The final 2 usages in react-native is in `ReactNativeTypes`, which is synced from upstream react. Sync of facebook/react#32733 is currently blocked by test failures, so I will add the temporary shim to unblock releases. Changelog: [Internal] Reviewed By: panagosg7 Differential Revision: D71849353
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71849353 |
Contributor
|
This pull request has been merged in a70fe45. |
Collaborator
|
This pull request was successfully merged by @SamChou19815 in a70fe45 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In the next version of Flow, support for
$PropertyTypewill be removed in favor of indexed access types. The final 2 usages in react-native is inReactNativeTypes, which is synced from upstream react. Sync of facebook/react#32733 is currently blocked by test failures, so I will add the temporary shim to unblock releases.Changelog: [Internal]
Reviewed By: panagosg7
Differential Revision: D71849353