ReactDOM.useEvent: revert and add guard for null stateNode#18441
Merged
trueadm merged 2 commits intofacebook:masterfrom Apr 1, 2020
Merged
ReactDOM.useEvent: revert and add guard for null stateNode#18441trueadm merged 2 commits intofacebook:masterfrom
trueadm merged 2 commits intofacebook:masterfrom
Conversation
This reverts commit 90e90ac.
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit dc6518e:
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2d01aae:
|
Details of bundled changes.Comparing: 90e90ac...2d01aae react-dom
react-art
react-test-renderer
ReactDOM: size: 0.0%, gzip: -0.0% Size changes (stable) |
Collaborator
|
Thanks. Could you go through all code behind useEvent flag to search for similar bugs? |
Contributor
Author
|
@gaearon I deep a deep dive earlier today, I couldn't see anywhere else we access |
trueadm
force-pushed
the
fix-use-event
branch
2 times, most recently
from
dee7c8e to
6d5e3ad
Compare
gaearon
reviewed
Mar 31, 2020
Add accumulateUseEventListeners flag Fix Fxi Add support for HostText being target Fix Remove last part Fix Fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts the revert PR (#18438) and applies the appropiate fix. The previous problem was that we were trying to call
getListenersFromTargeton theinstance, which was taken fromnode.stateNode. I missed the case where thestateNodecan benull(when the component gets unmounted), so we should make sure to check that the instance is notnull. I also added some validation to ensure thatlastHostComponentshould never benulltoo, as per comments from @gaearon in #18375.