Revert useEvent PRs by acdlite · Pull Request #18438 · facebook/react

acdlite · 2020-03-31T02:05:11Z

One of these commits led to a bug in www. We had to revert the most recent sync.

Reverting to unblock the other changes in master.

…test (facebook#18395)" This reverts commit e0ab1a4.

…acebook#18375)" This reverts commit a16b349. * ReactDOM.useEvent: Add support for experimental scopes API

codesandbox-ci · 2020-03-31T02:08:30Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8f3a84e:

Sandbox	Source
hopeful-hawking-ohr9u	Configuration

sizebot · 2020-03-31T02:10:29Z

Details of bundled changes.

Comparing: bf30e37...8f3a84e

react-dom

File	Filesize Diff	Gzip Diff	Prev Size	Current Size	Prev Gzip	Current Gzip	ENV
react-dom.profiling.min.js	0.0%	0.0%	126.91 KB	126.91 KB	39.73 KB	39.73 KB	NODE_PROFILING
react-dom-unstable-fizz.browser.development.js	0.0%	+0.1%	3.35 KB	3.35 KB	1.27 KB	1.27 KB	UMD_DEV
ReactDOM-dev.js	-2.0%	-1.8%	965.58 KB	946.63 KB	214.88 KB	210.99 KB	FB_WWW_DEV
ReactDOM-prod.js	-3.2%	-3.2%	406.72 KB	393.59 KB	73.76 KB	71.39 KB	FB_WWW_PROD
ReactDOM-profiling.js	-3.1%	-3.1%	418.21 KB	405.08 KB	75.74 KB	73.4 KB	FB_WWW_PROFILING
react-dom-unstable-fizz.browser.development.js	0.0%	+0.1%	2.95 KB	2.95 KB	1.18 KB	1.18 KB	NODE_DEV
react-dom-unstable-fizz.browser.production.min.js	0.0%	-0.2%	1 KB	1 KB	610 B	609 B	NODE_PROD
react-dom-test-utils.development.js	0.0%	0.0%	59.24 KB	59.24 KB	15.65 KB	15.65 KB	UMD_DEV
ReactDOMTesting-dev.js	-2.4%	-2.3%	922.76 KB	900.83 KB	206.17 KB	201.5 KB	FB_WWW_DEV
ReactDOMTesting-prod.js	-3.7%	-3.7%	394.71 KB	380.11 KB	71.98 KB	69.35 KB	FB_WWW_PROD
react-dom-test-utils.development.js	0.0%	0.0%	54.7 KB	54.7 KB	15.03 KB	15.04 KB	NODE_DEV
ReactDOMTesting-profiling.js	-3.7%	-3.7%	394.71 KB	380.11 KB	71.98 KB	69.35 KB	FB_WWW_PROFILING
react-dom-server.node.production.min.js	0.0%	0.0%	20.49 KB	20.49 KB	7.52 KB	7.52 KB	NODE_PROD
react-dom-server.browser.production.min.js	0.0%	0.0%	20.08 KB	20.08 KB	7.37 KB	7.38 KB	NODE_PROD
react-dom.development.js	-0.0%	-0.0%	925.35 KB	925.26 KB	202.63 KB	202.6 KB	UMD_DEV
react-dom-unstable-native-dependencies.development.js	0.0%	0.0%	57.71 KB	57.71 KB	14.36 KB	14.36 KB	UMD_DEV
ReactDOMForked-dev.js	-2.0%	-1.8%	965.58 KB	946.63 KB	214.88 KB	210.99 KB	FB_WWW_DEV
react-dom-unstable-native-dependencies.production.min.js	0.0%	0.0%	10.32 KB	10.32 KB	3.49 KB	3.49 KB	UMD_PROD
ReactDOMForked-prod.js	-3.2%	-3.2%	406.72 KB	393.59 KB	73.76 KB	71.39 KB	FB_WWW_PROD
ReactDOMServer-prod.js	0.0%	0.0%	45.91 KB	45.91 KB	10.67 KB	10.67 KB	FB_WWW_PROD
react-dom.development.js	-0.0%	-0.0%	881.16 KB	881.07 KB	200.14 KB	200.12 KB	NODE_DEV
ReactDOMForked-profiling.js	-3.1%	-3.1%	418.21 KB	405.08 KB	75.74 KB	73.4 KB	FB_WWW_PROFILING
react-dom-unstable-native-dependencies.development.js	0.0%	0.0%	54.72 KB	54.72 KB	14.14 KB	14.14 KB	NODE_DEV
react-dom.production.min.js	0.0%	0.0%	122.93 KB	122.93 KB	38.45 KB	38.45 KB	NODE_PROD
react-dom-unstable-native-dependencies.production.min.js	0.0%	0.0%	10.05 KB	10.05 KB	3.38 KB	3.38 KB	NODE_PROD

react-art

File	Filesize Diff	Gzip Diff	Prev Size	Current Size	Prev Gzip	Current Gzip	ENV
ReactART-dev.js	-0.8%	-0.9%	582.07 KB	577.12 KB	122.42 KB	121.26 KB	FB_WWW_DEV
ReactART-prod.js	-0.2%	-0.2%	242.52 KB	242.05 KB	41.13 KB	41.06 KB	FB_WWW_PROD
react-art.production.min.js	0.0%	-0.0%	109.28 KB	109.28 KB	33.12 KB	33.12 KB	UMD_PROD

react-test-renderer

File	Filesize Diff	Gzip Diff	Prev Size	Current Size	Prev Gzip	Current Gzip	ENV
react-test-renderer-shallow.development.js	0.0%	0.0%	38.4 KB	38.4 KB	9.3 KB	9.3 KB	UMD_DEV
ReactTestRenderer-dev.js	-0.9%	-1.0%	567.78 KB	562.77 KB	120 KB	118.84 KB	FB_WWW_DEV

Size changes (experimental)

Generated by 🚫 dangerJS against 8f3a84e

sizebot · 2020-03-31T02:14:53Z

Details of bundled changes.

Comparing: bf30e37...8f3a84e

react-dom

File	Filesize Diff	Gzip Diff	Prev Size	Current Size	Prev Gzip	Current Gzip	ENV
react-dom.production.min.js	0.0%	0.0%	118.78 KB	118.78 KB	37.33 KB	37.33 KB	NODE_PROD
ReactDOMTesting-profiling.js	-3.5%	-3.4%	407.37 KB	393.25 KB	74 KB	71.5 KB	FB_WWW_PROFILING
react-dom-unstable-fizz.browser.development.js	0.0%	+0.1%	3.34 KB	3.34 KB	1.26 KB	1.26 KB	UMD_DEV
react-dom.profiling.min.js	0.0%	0.0%	122.64 KB	122.64 KB	38.52 KB	38.52 KB	NODE_PROFILING
react-dom-unstable-fizz.browser.production.min.js	0.0%	🔺+0.1%	1.17 KB	1.17 KB	689 B	690 B	UMD_PROD
react-dom-server.node.production.min.js	0.0%	0.0%	20.03 KB	20.03 KB	7.44 KB	7.44 KB	NODE_PROD
ReactDOMForked-dev.js	-1.9%	-1.8%	995.5 KB	976.52 KB	221.51 KB	217.58 KB	FB_WWW_DEV
ReactDOMForked-prod.js	-3.0%	-2.9%	421.57 KB	408.83 KB	76.11 KB	73.88 KB	FB_WWW_PROD
react-dom.development.js	-0.0%	-0.0%	895.51 KB	895.43 KB	197.34 KB	197.32 KB	UMD_DEV
ReactDOMForked-profiling.js	-2.9%	-2.8%	433.12 KB	420.38 KB	78.04 KB	75.84 KB	FB_WWW_PROFILING
react-dom-server.browser.production.min.js	0.0%	0.0%	19.71 KB	19.71 KB	7.34 KB	7.34 KB	UMD_PROD
react-dom.profiling.min.js	0.0%	0.0%	122.43 KB	122.43 KB	39.33 KB	39.33 KB	UMD_PROFILING
ReactDOMTesting-dev.js	-2.3%	-2.3%	949.28 KB	927.34 KB	211.96 KB	207.13 KB	FB_WWW_DEV
react-dom.development.js	-0.0%	-0.0%	852.56 KB	852.48 KB	194.91 KB	194.89 KB	NODE_DEV
ReactDOMTesting-prod.js	-3.5%	-3.4%	407.37 KB	393.25 KB	74 KB	71.5 KB	FB_WWW_PROD
ReactDOM-dev.js	-1.9%	-1.8%	995.5 KB	976.52 KB	221.51 KB	217.58 KB	FB_WWW_DEV
ReactDOM-prod.js	-3.0%	-2.9%	421.57 KB	408.83 KB	76.11 KB	73.88 KB	FB_WWW_PROD
ReactDOMServer-prod.js	0.0%	0.0%	46.62 KB	46.62 KB	10.86 KB	10.86 KB	FB_WWW_PROD
ReactDOM-profiling.js	-2.9%	-2.8%	433.12 KB	420.38 KB	78.04 KB	75.84 KB	FB_WWW_PROFILING
react-dom-unstable-native-dependencies.development.js	0.0%	0.0%	57.7 KB	57.7 KB	14.36 KB	14.36 KB	UMD_DEV
react-dom-unstable-fizz.browser.production.min.js	0.0%	-0.2%	1013 B	1013 B	602 B	601 B	NODE_PROD
react-dom-unstable-native-dependencies.production.min.js	0.0%	0.0%	10.31 KB	10.31 KB	3.49 KB	3.49 KB	UMD_PROD
react-dom-unstable-native-dependencies.development.js	0.0%	0.0%	54.71 KB	54.71 KB	14.13 KB	14.14 KB	NODE_DEV
react-dom-unstable-native-dependencies.production.min.js	0.0%	0.0%	10.04 KB	10.04 KB	3.37 KB	3.37 KB	NODE_PROD

react-art

File	Filesize Diff	Gzip Diff	Prev Size	Current Size	Prev Gzip	Current Gzip	ENV
react-art.production.min.js	0.0%	-0.0%	71.7 KB	71.7 KB	21.64 KB	21.64 KB	NODE_PROD
ReactART-dev.js	-0.8%	-0.9%	594.4 KB	589.45 KB	124.77 KB	123.65 KB	FB_WWW_DEV
ReactART-prod.js	-0.2%	-0.2%	251.44 KB	250.97 KB	42.57 KB	42.5 KB	FB_WWW_PROD

react-test-renderer

File	Filesize Diff	Gzip Diff	Prev Size	Current Size	Prev Gzip	Current Gzip	ENV
react-test-renderer-shallow.development.js	0.0%	0.0%	38.39 KB	38.39 KB	9.29 KB	9.29 KB	UMD_DEV
ReactTestRenderer-dev.js	-0.9%	-1.0%	567.77 KB	562.75 KB	119.99 KB	118.83 KB	FB_WWW_DEV

Size changes (stable)

Generated by 🚫 dangerJS against 8f3a84e

This reverts commit 90e90ac.

acdlite added 2 commits March 30, 2020 18:58

Revert "ReactDOM.useEvent: enable on internal www and add inspection …

dc3d3fc

…test (facebook#18395)" This reverts commit e0ab1a4.

Revert "ReactDOM.useEvent: Add support for experimental scopes API (f…

8f3a84e

…acebook#18375)" This reverts commit a16b349. * ReactDOM.useEvent: Add support for experimental scopes API

acdlite requested a review from trueadm March 31, 2020 02:05

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 31, 2020

gaearon approved these changes Mar 31, 2020

View reviewed changes

acdlite merged commit 90e90ac into facebook:master Mar 31, 2020

trueadm added a commit to trueadm/react that referenced this pull request Mar 31, 2020

Revert "Revert useEvent PRs (facebook#18438)"

515957d

This reverts commit 90e90ac.

trueadm mentioned this pull request Mar 31, 2020

ReactDOM.useEvent: revert and add guard for null stateNode #18441

Merged

trueadm added a commit to trueadm/react that referenced this pull request Apr 1, 2020

Revert "Revert useEvent PRs (facebook#18438)"

47e337e

This reverts commit 90e90ac.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Revert useEvent PRs#18438

Revert useEvent PRs#18438
acdlite merged 2 commits intofacebook:masterfrom
acdlite:revert-useevent

acdlite commented Mar 31, 2020

Uh oh!

codesandbox-ci bot commented Mar 31, 2020

Uh oh!

sizebot commented Mar 31, 2020

react-dom

react-art

react-test-renderer

Uh oh!

sizebot commented Mar 31, 2020

react-dom

react-art

react-test-renderer

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

Conversation

acdlite commented Mar 31, 2020

Uh oh!

codesandbox-ci bot commented Mar 31, 2020

Uh oh!

sizebot commented Mar 31, 2020

react-dom

react-art

react-test-renderer

Size changes (experimental)

Uh oh!

sizebot commented Mar 31, 2020

react-dom

react-art

react-test-renderer

Size changes (stable)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants