Repository navigation
fix(tests): run Bogota fixtures on the Amsterdam spec in the json loader - #3696
Closed
AnkushinDaniil wants to merge 1 commit into
Closed
AnkushinDaniil wants to merge 1 commit into
AnkushinDaniil wants to merge 1 commit into
Conversation
Contributor
|
Closing as we no longer need the alias :) we now have the real Bogota fork module from #3665 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since the rebase onto newer
forks/amsterdam(#3564), the json loader only knows forks that have anethereum.forks.*module.Bogotais a test-only fork on the Amsterdam spec, sojson-loaderfails onAmsterdamToBogotaAtTime15kandvalidate-blocksdrops every Bogota fixture and exits 5 infill (bogota). This mapsBogotato the Amsterdam spec.Checked locally:
tests/json_loader/test_fork_transition_networks.py24 passed. Filled 27 Bogota blockchain fixtures (-k nonce);validate-blockson them gives exit 5 without the change and 53 passed with it.Related Issues or PRs
Unblocks CI on #3682, #3683.
Checklist
ruff check,ruff format --checkon the changed file<type>(<area>): <title>