Repository navigation
feat(spec-specs,test-forks,ci): add the Bogota fork module - #3665
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## forks/bogota #3665 +/- ##
================================================
+ Coverage 94.62% 94.91% +0.28%
================================================
Files 624 672 +48
Lines 36976 40846 +3870
Branches 3349 3775 +426
================================================
+ Hits 34988 38767 +3779
- Misses 1397 1445 +48
- Partials 591 634 +43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
13d21d6 to
061a91d
Compare
061a91d to
1645e86
Compare
6ab264f to
192d7c2
Compare
danceratopz
left a comment
There was a problem hiding this comment.
Few small CI and doc related suggestions/questions!
Can you bump these, here, too?
execution-specs/packages/testing/src/execution_testing/config/docs.py
Lines 11 to 18 in 949856f
danceratopz
left a comment
There was a problem hiding this comment.
Target branch is currently forks/amsterdam, we shouldn't merge this work to Amsterdam. We should create forks/bogota and merge that there. We can then bump the default dev branch when we're ready.
|
The branch exists btw (and doesn't contain Bogota yet :-) ): |
192d7c2 to
568b44b
Compare
152ccf8 to
b64973f
Compare
b64973f to
e505a90
Compare
marioevz
left a comment
There was a problem hiding this comment.
LGTM, I diffed both spec folders for Amsterdam and Bogota and they have only the correct changes. Thanks for this.
Description
Adds the
bogotafork module as a copy of Amsterdam with no protocol changes, plus framework support for Bogota and the Amsterdam-to-Bogota transition. Includes automatic EIP mixin discovery, packaging and Hive compatibility, and enables Bogota in CI filling, block validation, coverage, benchmark filling, and execute/consume collection checks.Related Issues or PRs
N/A.
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.