feat(tests): add precompile as block coinbase coverage - #3462
Merged
spencer-tb merged 2 commits intoSep 2, 2026
Merged
Conversation
shubham5080
marked this pull request as ready for review
August 28, 2026 03:49
shubham5080
force-pushed
the
test/precompile-coinbase
branch
2 times, most recently
from
August 30, 2026 19:10
60aaa92 to
5183f8b
Compare
LouisTsai-Csie
requested changes
Aug 31, 2026
LouisTsai-Csie
left a comment
LouisTsai-Csie
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution! I've left some comments. Could you move this test to test_precompiles.py?
danceratopz
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #3462 +/- ##
===================================================
+ Coverage 93.90% 94.01% +0.10%
===================================================
Files 624 624
Lines 36905 36905
Branches 3326 3326
===================================================
+ Hits 34655 34695 +40
+ Misses 1569 1533 -36
+ Partials 681 677 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Cover enabled precompile addresses used as coinbase/fee recipient so the state transition still succeeds, including a follow-up call to that precompile. Fixes ethereum#1669.
Move the test into test_precompiles.py, tighten the docstring to state-transition only, and drop the hardcoded gas_limit.
shubham5080
force-pushed
the
test/precompile-coinbase
branch
from
August 31, 2026 07:59
5183f8b to
ac4835c
Compare
Contributor
Author
|
@LouisTsai-Csie
|
LouisTsai-Csie
approved these changes
Sep 2, 2026
spencer-tb
approved these changes
Sep 2, 2026
20 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a Frontier blockchain test that uses each enabled precompile as the block coinbase / fee recipient and then calls that address.
This covers issue #1669: setting an enabled precompile as coinbase must not break the state transition. Pattern matches
tests/shanghai/eip4895_withdrawals/test_withdrawals.py::test_withdrawing_to_precompiles(@pytest.mark.with_all_precompiles, two blocks, emptypost).Filled locally:
221 passed.
Related Issues or PRs
Fixes #1669.
Checklist
just static<type>(<area>): <title>Cute Animal Picture