Repository navigation
chore(deps): update @cloudflare/kumo to 2.15.0 - #4308
khoinguyenpham04 wants to merge 21 commits into
Conversation
Keeps admin dialogs centred and content-sized, drops the extra menu icon margin now that Kumo spaces DropdownMenu icons itself, restores the code block toolbar's RTL edges, and keeps revision fields at the editor's control height.
…gned with Kumo 2.15
🦋 Changeset detectedLatest commit: 2c3b33d The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
Bot
added
review/needs-review
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/auth-atproto
@emdash-cms/blocks
@emdash-cms/cloudflare
@emdash-cms/contentful-to-portable-text
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/plugin-cli
@emdash-cms/plugin-test
@emdash-cms/plugin-types
@emdash-cms/registry-client
@emdash-cms/registry-lexicons
@emdash-cms/registry-loader
@emdash-cms/registry-moderation
@emdash-cms/registry-verification
upgrade-emdash
@emdash-cms/sandbox-workerd
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-ai-search
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-field-kit
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
![emdashbot[bot]](https://avatars.githubusercontent.com/in/3255304?s=60&v=4){kind=small}
There was a problem hiding this comment.
The approach is sound: bump the exactly pinned Kumo dependency to 2.15.0 and adapt the admin where Kumo's new defaults would change the existing design (dialog position and width, DropdownMenu icon spacing, RTL toolbar edges, and so on). Neither reviewer found a blocking bug or a convention violation. Both reviews were static, so the PR's reported visual comparisons and test results remain unverified. The first reviewer also could not check the new CSS class selectors against Kumo 2.15's dist. There is one non-blocking suggestion: a CSS comment gives the wrong reason for the existing small-screen dialog rule. The second reviewer raised no findings.
Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol.
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
docs | 2c3b33d | Oct 31 2026, 10:29 PM |
…tions Kumo 2.15 animates DropdownMenu open and close. The table menus hand focus back to the editor once the close finishes, so a key pressed during the transition landed in the closing menu. Table e2e tests now measure after the open and close transitions settle.
emdashbot
Bot
added
review/needs-review
There was a problem hiding this comment.
The approach remains sound: update Kumo while preserving the admin’s existing layout and interactions. I reviewed the follow-up diff, including the table-menu exit timing and animation-aware browser-test waits. The revised dialog comment addresses the earlier suggestion, and the author’s clarification is reasonable. No new defects or convention violations found in the changed code.
Review was static; I did not run tests or verify browser rendering.
Follow-up review by openai/gpt-6.1-sol, scoped to the changes since the last review.
The table menu is translated in Arabic now, so the English labels these RTL steps looked up never appeared.
There was a problem hiding this comment.
The approach remains sound: update Kumo while preserving the admin’s existing layout and interactions. I reviewed only the changes since the last review: the menu-animation wait, Arabic visual-test selectors, and table-menu label padding. The selectors match the Arabic catalog and test locale; no new defects or convention violations found.
The earlier dialog-comment concern is settled by the revision and author’s clarification; nothing remains open.
Review was static; I did not run tests or verify browser rendering.
Follow-up review by openai/gpt-6.1-sol, scoped to the changes since the last review.
Kumo 2.15 pads icon-less menu rows and labels with a physical pl-8 when another row has an icon. Keep the calendar filter, HTML block and table mixed-header rows on their previous padding, which also stops the calendar filter menu shifting when Clear filters appears.
There was a problem hiding this comment.
The approach remains sound: upgrade Kumo while preserving the admin’s existing layout. I reviewed the changes since the previous head: calendar and HTML menu padding, mixed-state table-item padding, comment removal, and changeset clarifications.
The padding overrides preserve RTL-safe spacing, and the release note clarifies coordinated plugin upgrades and the line-height change. The earlier dialog-comment concern remains settled; nothing is still open. No new defects or convention violations found.
Review was static; I did not run tests or verify browser rendering.
Follow-up review by openai/gpt-6.1-sol, scoped to the changes since the last review.
|
/accept-baselines |
There was a problem hiding this comment.
The approach remains sound: update Kumo while preserving the admin’s existing layout, including table styling introduced by intervening main-branch changes.
I reviewed the follow-up diff against the current PR diff, focusing on the new table border and row-background overrides and the affected surrounding markup. No new actionable defects found. The earlier dialog-comment concern remains resolved by the author’s clarification; nothing remains open from that finding.
Review was static. I did not run tests or verify browser rendering, and binary screenshot differences were not visually inspected.
Follow-up review by openai/gpt-6.1-sol, scoped to the changes since the last review.
|
/accept-baselines |
|
✅ Baselines accepted by @khoinguyenpham04 and committed to this PR. |
danielmlr
left a comment
danielmlr
left a comment
There was a problem hiding this comment.
2 points that came up:
- I think AI Search needs to go in the changeset too. The release (#4265) used up its pending changesets, so its published 0.1.0 would keep requiring Kumo 2.6.0 and clash with the update.
- The content list menus from #4446 still have
me-2on their icons, so the gap is twice as wide as in the other menus. Dropping it from those six icons inContentList.tsxwould line them up.
emdashbot
Bot
added
review/needs-rereview
github-actions
Bot
added
review/awaiting-author
… in the Kumo changeset Kumo 2.15's DropdownMenu spaces item icons itself, so the extra me-2 doubled the gap in the content list row menus. AI Search 0.1.0 was published requiring Kumo 2.6.0, so it needs a release with the new pin too.
github-actions
Bot
added
review/needs-rereview
There was a problem hiding this comment.
The approach remains sound: upgrade Kumo while preserving the admin’s existing layout and coordinating plugin upgrades.
I reviewed the follow-up changes against the current PR diff, focusing on the content-row menu icon spacing and the expanded changeset’s AI Search coverage and upgrade guidance. No new actionable defects found. The earlier dialog-comment concern remains settled by the author’s clarification; nothing remains open.
Review was static. I did not run tests or verify browser rendering, and binary screenshot differences were not visually inspected.
Follow-up review by openai/gpt-6.1-sol, scoped to the changes since the last review.
emdashbot
Bot
added
review/needs-rereview
github-actions
Bot
added
review/needs-review
…ate-12d776 # Conflicts: # packages/admin/src/components/TaxonomyManager.tsx # packages/admin/src/routes/bylines.tsx
Kumo 2.15's DropdownMenu spaces item icons itself, so me-2 doubled the gap in the content type, relation, comment and byline field menus.
…emdash-cms/emdash into noah/kumo-version-update-12d776
github-actions
Bot
added
review/needs-rereview
There was a problem hiding this comment.
The approach is sound. The PR upgrades Kumo to 2.15.0 and adds targeted overrides so the admin keeps its existing layout, and the changeset coordinates the plugin upgrades. Both reviewers approved and found nothing to fix. The earlier small-screen dialog comment concern is resolved by the reworded comment. Both reviews were static: neither ran tests, checked browser rendering, or inspected the updated screenshot baselines.
Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol. The change since the last review (2316 lines) was too large for a scoped follow-up, so this is a full review.
What does this PR do?
Updates
@cloudflare/kumofrom 2.6.0 to 2.15.0 and keeps the admin's existing design where Kumo's new defaults would change it:styles.csskeeps dialogs centred and sized to their content, with each size as a minimum width, as on 2.6. Dialogs that set amin-w-*class or ansm:w-*width that isn't one of Kumo's sizes still get it. The menu, section and taxonomy dialogs now usesm:w-lgto keep their exact 512px width.DropdownMenunow spaces item icons itself, so the extrame-*margins are removed, including in the content list row menus.Tableno longer draws a line under each row and shades every other row instead. The content list, bylines and taxonomy tables keep their row lines and plain rows.DropdownMenunow indents rows and labels without an icon when another row has one, using a physical left padding. In the table, calendar filter and HTML block menus, those rows keep their old padding. This also stops the calendar filter menu from shifting sideways when Clear filters appears.Toolbarnow sets corners and dividers from the toolbar itself, which put the divider on the wrong side in RTL. The buttons now use important logical classes.Button'sshapeis now a discriminated union, so the table menu trigger is split into its two variants. They render the same as before.text-baseandtext-lgline heights grew, so the revision view's single-line fields keep a 20px line to match the editor's fixed-height inputs.Buttontrims leading padding when an icon comes first, so in LTR the Library and From URL tabs now match the Upload button's padding.mainafter the Arabic catalog was extracted. They now use the Arabic labels.Visible changes that remain from Kumo:
text-baseandtext-lgnow have a 1.5 line height (21px and 24px, from 20px), so labels and headings are slightly taller. The confirm dialog is 4px taller as a result.mainin fix(admin): stop forcing every border to the default gray #4118, but the change was too faint for the screenshot tests, so the baselines updated here are the first to show it.Buttontrims leading padding with a physicalpl-*class when an icon comes first, so in RTL the narrower side is next to the text instead of the icon.The changeset includes AI Search, since its published 0.1.0 requires Kumo 2.6.0, and tells sites to update
emdashand the Kumo-using plugins together.The catalog pin stays exact because the admin ships a prebuilt stylesheet generated from Kumo's dist.
Type of change
Your connection to this change
Checklist
pnpm typecheckpassespnpm lintpassespnpm testpasses (or targeted tests for my change)pnpm formathas been runmessages.pochanges except in translation PRs — a workflow extracts catalogs on merge tomain.No new tests: the existing admin tests for the code block toolbar and the revision view, and the bylines e2e test for the media tabs, caught the regressions this PR fixes and now pass. No strings changed. Not a feature, so no design PR.
AI assistance disclosure
Screenshots / test output
Admin unit tests (3656), blocks tests (167), typecheck and lint pass. 105 e2e tests pass (media library, bylines, menus, content actions, entry lock, widgets, welcome modal, invite flow, revisions, code blocks, accessibility, i18n). Compared with
mainat 700×720 and 1280×720, the confirm dialog and media picker have the same position and size.The media picker at 1280×720, centred with its footer on screen:
The Ownership select before and after. The menu now opens below the field instead of covering it: