Skip to content

ci: release - #4265

Merged
khoinguyenpham04 merged 1 commit into
mainfrom
changeset-release/main
Oct 29, 2026
Merged

khoinguyenpham04 merged 1 commit into
mainfrom
changeset-release/main

Conversation

@emdashbot

@emdashbot emdashbot Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

The changelog information of each package has been omitted from this message, as the content exceeds the size limit.

@emdash-cms/admin@1.4.0

emdash@1.4.0

@emdash-cms/plugin-ai-search@0.1.0

@emdash-cms/auth-atproto@0.2.50

@emdash-cms/blocks@1.4.0

@emdash-cms/cloudflare@1.4.0

@emdash-cms/plugin-cli@0.13.5

@emdash-cms/plugin-test@0.2.11

@emdash-cms/plugin-embeds@0.1.58

@emdash-cms/plugin-forms@0.2.12

@emdash-cms/sandbox-workerd@0.9.6

@emdash-cms/auth@1.4.0

create-emdash@1.4.0

@emdash-cms/gutenberg-to-portable-text@1.4.0

@emdash-cms/x402@1.4.0

@emdashbot emdashbot Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a standard Changesets release PR, and the approach fits the repo's workflow. It consumes the pending changeset (a patch to @emdash-cms/admin for German admin translation updates), bumps the fixed-group packages to 1.3.2, and propagates version bumps to dependents. Both reviewers checked the version bumps, changelog entries and changeset consumption, and neither found anything needing a fix. The review was static only; no tests, builds or publishing commands were run.


Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol.

@pkg-pr-new

pkg-pr-new Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@emdash-cms/admin

npm i https://pkg.pr.new/@emdash-cms/admin@4265

@emdash-cms/auth

npm i https://pkg.pr.new/@emdash-cms/auth@4265

@emdash-cms/auth-atproto

npm i https://pkg.pr.new/@emdash-cms/auth-atproto@4265

@emdash-cms/blocks

npm i https://pkg.pr.new/@emdash-cms/blocks@4265

@emdash-cms/cloudflare

npm i https://pkg.pr.new/@emdash-cms/cloudflare@4265

@emdash-cms/contentful-to-portable-text

npm i https://pkg.pr.new/@emdash-cms/contentful-to-portable-text@4265

emdash

npm i https://pkg.pr.new/emdash@4265

create-emdash

npm i https://pkg.pr.new/create-emdash@4265

@emdash-cms/gutenberg-to-portable-text

npm i https://pkg.pr.new/@emdash-cms/gutenberg-to-portable-text@4265

@emdash-cms/plugin-cli

npm i https://pkg.pr.new/@emdash-cms/plugin-cli@4265

@emdash-cms/plugin-test

npm i https://pkg.pr.new/@emdash-cms/plugin-test@4265

@emdash-cms/plugin-types

npm i https://pkg.pr.new/@emdash-cms/plugin-types@4265

@emdash-cms/registry-client

npm i https://pkg.pr.new/@emdash-cms/registry-client@4265

@emdash-cms/registry-lexicons

npm i https://pkg.pr.new/@emdash-cms/registry-lexicons@4265

@emdash-cms/registry-loader

npm i https://pkg.pr.new/@emdash-cms/registry-loader@4265

@emdash-cms/registry-moderation

npm i https://pkg.pr.new/@emdash-cms/registry-moderation@4265

@emdash-cms/registry-verification

npm i https://pkg.pr.new/@emdash-cms/registry-verification@4265

upgrade-emdash

npm i https://pkg.pr.new/upgrade-emdash@4265

@emdash-cms/sandbox-workerd

npm i https://pkg.pr.new/@emdash-cms/sandbox-workerd@4265

@emdash-cms/x402

npm i https://pkg.pr.new/@emdash-cms/x402@4265

@emdash-cms/plugin-ai-moderation

npm i https://pkg.pr.new/@emdash-cms/plugin-ai-moderation@4265

@emdash-cms/plugin-ai-search

npm i https://pkg.pr.new/@emdash-cms/plugin-ai-search@4265

@emdash-cms/plugin-atproto

npm i https://pkg.pr.new/@emdash-cms/plugin-atproto@4265

@emdash-cms/plugin-audit-log

npm i https://pkg.pr.new/@emdash-cms/plugin-audit-log@4265

@emdash-cms/plugin-color

npm i https://pkg.pr.new/@emdash-cms/plugin-color@4265

@emdash-cms/plugin-embeds

npm i https://pkg.pr.new/@emdash-cms/plugin-embeds@4265

@emdash-cms/plugin-field-kit

npm i https://pkg.pr.new/@emdash-cms/plugin-field-kit@4265

@emdash-cms/plugin-forms

npm i https://pkg.pr.new/@emdash-cms/plugin-forms@4265

@emdash-cms/plugin-webhook-notifier

npm i https://pkg.pr.new/@emdash-cms/plugin-webhook-notifier@4265

commit: 9569e00

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://changeset-release-main.try.emdashcms.com, https://changeset-release-main-emdash-playground.emdash-cms.workers.dev (commit 9569e00)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://c2a4e8b4.try.emdashcms.com, https://c2a4e8b4-emdash-playground.emdash-cms.workers.dev 9569e00 2026-10-29T12:34:28.126Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://6d28293c.try.emdashcms.com, https://6d28293c-emdash-playground.emdash-cms.workers.dev 2052b65 2026-10-29T10:03:56.203Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://dd083e3a.try.emdashcms.com, https://dd083e3a-emdash-playground.emdash-cms.workers.dev aa5c5ef 2026-10-28T22:31:33.054Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://90bb971b.try.emdashcms.com, https://90bb971b-emdash-playground.emdash-cms.workers.dev 0a0bdc7 2026-10-28T14:36:03.712Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://f6d5f71d.try.emdashcms.com, https://f6d5f71d-emdash-playground.emdash-cms.workers.dev 9701bba 2026-10-28T09:29:04.600Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://ae57b470.try.emdashcms.com, https://ae57b470-emdash-playground.emdash-cms.workers.dev a76ecdb 2026-10-28T01:30:54.686Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://85c55e7f.try.emdashcms.com, https://85c55e7f-emdash-playground.emdash-cms.workers.dev d0f1faa 2026-10-27T23:14:26.765Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://73cc1666.try.emdashcms.com, https://73cc1666-emdash-playground.emdash-cms.workers.dev 730c2cc 2026-10-27T19:42:26.078Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://0b018fa4.try.emdashcms.com, https://0b018fa4-emdash-playground.emdash-cms.workers.dev 102e45d 2026-10-27T17:43:21.086Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://facdd7c6.try.emdashcms.com, https://facdd7c6-emdash-playground.emdash-cms.workers.dev cbe0ceb 2026-10-26T23:53:11.942Z Visit the dashboard ↗

View all previews: View all previews ↗

@emdashbot
emdashbot Bot force-pushed the changeset-release/main branch from 48c445d to f2f6d15 Compare October 18, 2026 21:32
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
docs 9569e00 Oct 29 2026, 12:32 PM

@emdashbot emdashbot Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated release remains consistent with EmDash’s Changesets workflow: it includes the Brazilian Portuguese translation update alongside the previously reviewed German translations.

I checked the follow-up diff, release notes, fixed-group version bumps, dependent-package releases, changeset consumption, and Portuguese catalog text and interpolation placeholders. I found nothing needing a fix. The previous review had no outstanding findings, and this update introduces no confirmed defects.

Static review only; no tests, builds, or publishing commands were run.


Follow-up review by openai/gpt-6.1-sol, scoped to the changes since the last review.

@emdashbot
emdashbot Bot force-pushed the changeset-release/main branch 3 times, most recently from 9a7adfd to 87f5472 Compare October 19, 2026 15:53
@github-actions github-actions Bot added size/L and removed size/M labels Oct 19, 2026

@emdashbot emdashbot Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated release follows EmDash’s Changesets workflow and appropriately includes the editor fixes alongside the previously reviewed translations.

I checked the follow-up’s release changes against the full PR diff, including version bumps, dependent-package releases, consumed changesets, the new editor release notes against implementation and documentation, and preservation of the archived changelog. I found nothing needing a fix. The previous review had no outstanding findings, and none remain open.

Static review only; no tests, builds, or publishing commands were run.


Follow-up review by openai/gpt-6.1-sol, scoped to the changes since the last review.

@emdashbot
emdashbot Bot force-pushed the changeset-release/main branch 4 times, most recently from f4c9c77 to 6e3b081 Compare October 19, 2026 18:16

@emdashbot emdashbot Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated release remains consistent with EmDash’s Changesets workflow and is an appropriate patch release.

I checked the follow-up release changes against the full PR diff, including consumed changesets, package versions, fixed-group and dependent-package releases, release-note claims, and preservation of the archived changelog. I found nothing needing a fix. The previous review had no outstanding findings, and none remain open.

Static review only; no tests, builds, or publishing commands were run.


Follow-up review by openai/gpt-6.1-sol, scoped to the changes since the last review.

@emdashbot
emdashbot Bot force-pushed the changeset-release/main branch from 6e3b081 to c6e14e3 Compare October 19, 2026 19:22

@emdashbot emdashbot Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated release remains an appropriate patch release and follows EmDash’s Changesets workflow.

I checked the follow-up against the full PR diff, including package versions, fixed-group and dependent-package bumps, consumed changesets, release-note claims, and changelog archival. All consumed descriptions are preserved in the package changelogs, and the archived 1.1.0 notes and previous archive link are intact. I found nothing needing a fix. The prior review had no outstanding findings, and none remain open.

Static review only; no tests, builds, or publishing commands were run.


Follow-up review by openai/gpt-6.1-sol, scoped to the changes since the last review.

@emdashbot
emdashbot Bot force-pushed the changeset-release/main branch from c6e14e3 to 6602d2e Compare October 20, 2026 04:12

@emdashbot emdashbot Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated patch release remains appropriate and follows EmDash’s Changesets workflow.

I reviewed the changes since the previous head, checking consumed changesets against the release notes, package versions and dependent bumps, changelog archival, and the Turkish catalog’s interpolation placeholders. The consumed descriptions are preserved, the archived notes and previous archive link remain intact, and I found nothing needing a fix. The prior review had no outstanding findings; none remain open.

Static review only; no tests, builds, or publishing commands were run.


Follow-up review by openai/gpt-6.1-sol, scoped to the changes since the last review.

@emdashbot
emdashbot Bot force-pushed the changeset-release/main branch from 6602d2e to ec3cff0 Compare October 20, 2026 06:53
@emdashbot
emdashbot Bot force-pushed the changeset-release/main branch from b200ed0 to 0a5b4ca Compare October 24, 2026 16:10

@emdashbot emdashbot Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release remains an appropriate use of EmDash’s Changesets workflow.

I checked the follow-up against the current PR diff, separating upstream editor and plugin-test changes from release-only edits. All 46 consumed changesets are represented in the changelogs, including the two newly incorporated fixes. Package versions match their release headings and the fixed release group; the changelog archive chain remains intact.

I found nothing needing a fix. The previous review had no outstanding findings, and none remain open. Static review only—no tests, builds, or publishing commands were run.


Follow-up review by openai/gpt-6.1-sol, scoped to the changes since the last review.

@emdashbot
emdashbot Bot force-pushed the changeset-release/main branch 7 times, most recently from 6489d7d to 254db5f Compare October 24, 2026 21:05

@emdashbot emdashbot Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release remains an appropriate use of EmDash’s Changesets workflow.

I checked the follow-up against the current release-only diff, separating upstream implementation changes from release edits. All 53 consumed changesets are represented in the changelogs. Package versions match their release headings and the fixed release group, and archived entries and archive links are preserved.

I found nothing needing a fix. The previous review had no outstanding findings, and none remain open. Static review only—no tests, builds, or publishing commands were run.


Follow-up review by openai/gpt-6.1-sol, scoped to the changes since the last review.

@emdashbot
emdashbot Bot force-pushed the changeset-release/main branch 2 times, most recently from e654bc5 to cfbaf0b Compare October 24, 2026 22:50

@emdashbot emdashbot Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release remains an appropriate use of EmDash’s Changesets workflow.

I checked the follow-up against the current release-only diff, separating upstream implementation changes from release edits. All 57 consumed changesets are represented in the changelogs. Package versions match their release headings and the fixed release group, and moved historical entries and archive links are preserved. I also checked the newly included release claims against the relevant implementation.

I found nothing needing a fix. The previous review had no outstanding findings, and none remain open. Static review only—no tests, builds, or publishing commands were run.


Follow-up review by openai/gpt-6.1-sol, scoped to the changes since the last review.

@emdashbot emdashbot Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release remains an appropriate use of EmDash’s Changesets workflow.

I checked the follow-up against the full release diff, separating upstream editor changes from release edits. All 58 consumed changesets are represented in the changelogs, package versions match their release headings and fixed release group, and archived historical entries and links are preserved. I also checked the newly included editor release note against the implementation and regression tests.

I found nothing needing a fix. The previous review had no outstanding findings, and none remain open.

Static review only; no tests, builds, or publishing commands were run.


Follow-up review by openai/gpt-6.1-sol, scoped to the changes since the last review.

@emdashbot emdashbot Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release remains an appropriate use of EmDash’s Changesets workflow.

I checked the follow-up against the release diff, separating upstream source and catalog updates from release edits. The newly included title-field slug note matches the editor/API implementation and regression tests. All 59 consumed changesets are represented in the changelogs, package versions match their release headings and fixed release group, and archived historical entries are preserved.

I found nothing needing a fix. The previous review had no outstanding findings, and none remain open.

Static review only; no tests, builds, or publishing commands were run.


Follow-up review by openai/gpt-6.1-sol, scoped to the changes since the last review.

@emdashbot emdashbot Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a standard Changesets release PR, and it is an appropriate use of EmDash's release workflow. Both reviewers approved with no findings. All 60 consumed changesets are removed and represented in the changelogs. Package versions match their release headings and the fixed release group, and archived historical changelog entries are preserved. The newly included table-insertion and placeholder release note matches the editor implementation and regression coverage. Both were static reviews; no tests, builds or publishing commands were run.


Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol. The change since the last review (1002 lines) was too large for a scoped follow-up, so this is a full review.

@emdashbot emdashbot Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a standard Changesets release PR and an appropriate use of EmDash's release workflow. Both reviewers approved with no findings, and there were no earlier findings to carry over. All consumed changesets are removed and represented in the package changelogs. Package versions match their changelog headings and the fixed release group, and historical changelog entries are preserved in archives. Reviewers spot-checked that the public surfaces named in the release notes exist in the source. Both reviews were static only; no tests, builds or publish commands were run.


Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol. The change since the last review (1007 lines) was too large for a scoped follow-up, so this is a full review.

@emdashbot emdashbot Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the bot-generated Changesets release PR, and the approach is correct: it consumes the pending changesets, bumps versions, and writes the CHANGELOG entries and archives. Both reviewers found the version bumps and changelog archiving consistent with the repository's release setup. They differ on one point. The openai reviewer found a documentation error in the new AI Search changelog entry, which the anthropic reviewer, who approved, did not raise. Because that finding stands as needs_fixing, the verdict is request_changes. The fix is a changeset or CHANGELOG wording correction, not a code change.


Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol.

Comment thread packages/plugins/ai-search/CHANGELOG.md Outdated

### Minor Changes

- [#4071](https://github.com/emdash-cms/emdash/pull/4071) [`772838d`](https://github.com/emdash-cms/emdash/commit/772838d20a748a42d9e1c03ad94a992006745bef) Thanks [@ttmx](https://github.com/ttmx)! - Adds `@emdash-cms/plugin-ai-search`, a plugin that indexes published content and author profiles into Cloudflare AI Search and keeps the index current as content changes. Set it up from the admin wizard, then add the `AiSearch` Astro component to a layout for a search button and modal. Requires EmDash 1.0.1 or later, Cloudflare Workers, and an `ai_search_namespaces` binding. See the [AI Search plugin guide](https://docs.emdashcms.com/plugins/ai-search/).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[needs fixing] The introductory entry says Cloudflare Workers and an ai_search_namespaces binding are required, but this same 0.1.0 release supports Node.js and binding-free Workers through the REST API. openProvider() in src/connection.ts falls back to REST credentials when no binding exists, and the linked guide documents both connection methods. As written, the entry can wrongly rule out the plugin for Node.js users and contradicts the next bullet.

Combine these two entries into one introduction describing the complete initial release, with a Workers binding or Cloudflare REST credentials as alternative connection methods. Preserve the REST setup and rate-limit guidance. The anthropic reviewer approved and raised no issue here, so this comes from the openai reviewer alone.

@emdashbot emdashbot Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the bot-generated Changesets release PR, and the approach is correct. It consumes the pending changesets, bumps package versions, writes the CHANGELOG entries, and archives older sections under changelog/ following the existing naming pattern. Both reviewers found no other problems with the version bumps or changelog archiving.

The one open issue is the AI Search 0.1.0 changelog entry. It still says the plugin requires Cloudflare Workers and an ai_search_namespaces binding, but the same release supports Node.js and binding-free Workers through the REST API. This was raised in the prior review and has not been fixed or answered. It is a release-note wording fix, not a runtime change, and belongs in the source changesets on main. Both reviewers' verdicts were comment, but I am choosing request_changes because the finding is needs_fixing.


Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol. The change since the last review (1047 lines) was too large for a scoped follow-up, so this is a full review.

Comment thread packages/plugins/ai-search/CHANGELOG.md Outdated

### Minor Changes

- [#4071](https://github.com/emdash-cms/emdash/pull/4071) [`772838d`](https://github.com/emdash-cms/emdash/commit/772838d20a748a42d9e1c03ad94a992006745bef) Thanks [@ttmx](https://github.com/ttmx)! - Adds `@emdash-cms/plugin-ai-search`, a plugin that indexes published content and author profiles into Cloudflare AI Search and keeps the index current as content changes. Set it up from the admin wizard, then add the `AiSearch` Astro component to a layout for a search button and modal. Requires EmDash 1.0.1 or later, Cloudflare Workers, and an `ai_search_namespaces` binding. See the [AI Search plugin guide](https://docs.emdashcms.com/plugins/ai-search/).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[needs fixing] This entry is unchanged from the prior review. It says the plugin requires EmDash 1.0.1 or later, Cloudflare Workers, and an ai_search_namespaces binding. The same 0.1.0 release also supports Node.js and Workers without a binding through the Cloudflare REST API, as the next bullet (#4310) says. openProvider() in src/connection.ts falls back to REST credentials, and the guide documents both connection methods. As written, the entry wrongly excludes supported deployments and contradicts the next bullet.

Merge .changeset/add-plugin-ai-search.md and .changeset/ai-search-rest-api.md into one introduction for the first release. Present a Workers binding or Cloudflare REST credentials as alternative connection methods, and keep the REST setup and rate-limit guidance. Fix this in the source changesets on main so the next regeneration of this PR picks it up.

@emdashbot emdashbot Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the bot-generated Changesets release PR, and the approach is correct. It consumes the pending changesets, bumps package versions, writes CHANGELOG entries, and archives older sections under changelog/ with the existing naming and linking pattern. Neither reviewer found other problems with the version bumps or archives.

One issue remains open from the prior review, with no author reply: the AI Search 0.1.0 introductory entry says the plugin requires Cloudflare Workers and an ai_search_namespaces binding. The same release supports Node.js and binding-free Workers through the REST API, so the entry contradicts the next bullet (#4310) and wrongly excludes supported deployments. This is a release-note wording fix, not a runtime change, and belongs in the source changesets on main so the regenerated PR picks it up. The anthropic reviewer left it as a comment and posted no inline finding, pointing to the existing thread. The openai reviewer re-raised it as needs_fixing, and I kept that severity.


Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol. The change since the last review (1053 lines) was too large for a scoped follow-up, so this is a full review.

Comment thread packages/plugins/ai-search/CHANGELOG.md Outdated

### Minor Changes

- [#4071](https://github.com/emdash-cms/emdash/pull/4071) [`772838d`](https://github.com/emdash-cms/emdash/commit/772838d20a748a42d9e1c03ad94a992006745bef) Thanks [@ttmx](https://github.com/ttmx)! - Adds `@emdash-cms/plugin-ai-search`, a plugin that indexes published content and author profiles into Cloudflare AI Search and keeps the index current as content changes. Set it up from the admin wizard, then add the `AiSearch` Astro component to a layout for a search button and modal. Requires EmDash 1.0.1 or later, Cloudflare Workers, and an `ai_search_namespaces` binding. See the [AI Search plugin guide](https://docs.emdashcms.com/plugins/ai-search/).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[needs fixing] This introduction says Cloudflare Workers and an ai_search_namespaces binding are required. The same 0.1.0 release also supports Node.js and Workers without a binding through Cloudflare REST credentials. openProvider() in src/connection.ts implements that fallback, and the linked guide documents both connection methods. As written, the entry wrongly rules out supported deployments and contradicts the next bullet (#4310). The anthropic reviewer raised this only as a prose note and did not post an inline finding; the openai reviewer raised it as needs_fixing, and this body follows that severity.

Merge .changeset/add-plugin-ai-search.md and .changeset/ai-search-rest-api.md on main into one introduction for the initial release. Present a Workers binding or Cloudflare REST credentials as alternative connection methods, and keep the REST setup and rate-limit guidance. Then regenerate this release PR.

@emdashbot emdashbot Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the bot-generated Changesets release PR, and the approach is correct. It consumes the pending changesets, bumps versions, writes CHANGELOG entries, and archives older sections under changelog/ with the existing naming and linking pattern. Neither reviewer found problems with the version bumps, archives, or other generated entries.

One issue remains open from the prior review, with no author reply: the AI Search 0.1.0 introductory entry says the plugin requires Cloudflare Workers and an ai_search_namespaces binding. The same release supports Node.js and binding-free Workers through the REST API. This is a release-note wording fix that belongs in the source changesets on main. The anthropic reviewer did not repost it inline and pointed to the existing thread, while the openai reviewer re-raised it as needs_fixing. I kept that severity.


Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol. The change since the last review (1062 lines) was too large for a scoped follow-up, so this is a full review.

Comment thread packages/plugins/ai-search/CHANGELOG.md Outdated

### Minor Changes

- [#4071](https://github.com/emdash-cms/emdash/pull/4071) [`772838d`](https://github.com/emdash-cms/emdash/commit/772838d20a748a42d9e1c03ad94a992006745bef) Thanks [@ttmx](https://github.com/ttmx)! - Adds `@emdash-cms/plugin-ai-search`, a plugin that indexes published content and author profiles into Cloudflare AI Search and keeps the index current as content changes. Set it up from the admin wizard, then add the `AiSearch` Astro component to a layout for a search button and modal. Requires EmDash 1.0.1 or later, Cloudflare Workers, and an `ai_search_namespaces` binding. See the [AI Search plugin guide](https://docs.emdashcms.com/plugins/ai-search/).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[needs fixing] This introduction says Cloudflare Workers and an ai_search_namespaces binding are required. The same 0.1.0 release also supports Node.js and Workers without a binding through Cloudflare REST credentials. openProvider() in src/connection.ts falls back to REST credentials, and the guide documents both connection methods. As written, the entry wrongly excludes supported deployments and contradicts the next bullet (#4310). The anthropic reviewer did not post this inline and referred to the existing thread, while the openai reviewer raised it as needs_fixing.

Merge .changeset/add-plugin-ai-search.md and .changeset/ai-search-rest-api.md on main into one introduction for the initial release. Present a Workers binding or Cloudflare REST credentials as alternative connection methods, and keep the REST setup and rate-limit guidance. Then regenerate this release PR.

@emdashbot emdashbot Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach is correct. This is the bot-generated Changesets release PR. It consumes the pending changesets, bumps versions, writes CHANGELOG entries, and archives older sections under changelog/ with the existing naming and linking. Both reviewers found no problems with the version bumps, archives, or other generated entries. One issue from the prior review is still open with no author reply: the AI Search 0.1.0 introduction says the plugin requires Cloudflare Workers and an ai_search_namespaces binding, but the same release supports Node.js and binding-free Workers through the REST API. The fix belongs in the source changesets on main, followed by regenerating this PR. Neither reviewer reposted the finding inline this round, and both pointed to the existing thread. I kept it as needs_fixing, the severity set in the prior review.


Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol. The change since the last review (1073 lines) was too large for a scoped follow-up, so this is a full review.

@emdashbot emdashbot Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach is correct: this is the bot-generated Changesets release PR that consumes pending changesets, bumps versions, writes CHANGELOG entries, and archives older sections under changelog/. Both reviewers found no problems with the version bumps, archives, or other generated entries. One issue remains open with no author reply. The AI Search 0.1.0 introduction says Cloudflare Workers and an ai_search_namespaces binding are required, but the same release supports Node.js and binding-free Workers through the REST API. Neither reviewer reposted it inline this round; both pointed to the existing thread. The fix belongs in the source changesets on main, followed by regenerating this PR.


Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol. The change since the last review (1094 lines) was too large for a scoped follow-up, so this is a full review.

@emdashbot emdashbot Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach is correct: this is the bot-generated Changesets release PR that consumes pending changesets, bumps versions, writes CHANGELOG entries, and archives older sections. Both reviewers found no problems with the version bumps, archives, or other generated entries. One issue remains open with no author reply. The AI Search 0.1.0 introduction says Cloudflare Workers and an ai_search_namespaces binding are required, but the same release supports Node.js and binding-free Workers through the REST API. The two reviewers did not repost the finding this round and pointed to the existing thread, so I am keeping it as one finding.


Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol. The change since the last review (1099 lines) was too large for a scoped follow-up, so this is a full review.

@emdashbot emdashbot Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the bot-generated Changesets release PR, and the approach is correct. Both reviewers found the version bumps, consumed changesets, archives and other generated entries fine. One issue remains open and has no author reply. The AI Search 0.1.0 introduction (#4071) says Cloudflare Workers and an ai_search_namespaces binding are required. The same release (#4310) supports Node.js and binding-free Workers through the REST API. The anthropic reviewer noted this only as prose and left the existing thread open. The openai reviewer also left it as the existing thread and did not post it inline. I am keeping it as one finding. The fix belongs in the source changesets on main, after which this PR should be regenerated.


Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol. The change since the last review (1104 lines) was too large for a scoped follow-up, so this is a full review.

@emdashbot emdashbot Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generating the release with Changesets is the right approach. Both reviewers found the version bumps, consumed changesets, archives and changelog headers consistent with the generated pattern, and neither found new problems. One finding is still open with no author reply. The AI Search 0.1.0 introduction (#4071) says Cloudflare Workers and an ai_search_namespaces binding are required. The same release (#4310) supports Node.js and binding-free Workers through Cloudflare REST credentials. The anthropic reviewer noted this only in prose and referred to the existing thread, while the openai reviewer raised it as needs_fixing. I kept it as one finding with needs_fixing severity. The fix belongs in the source changesets on main, after which this PR should be regenerated.


Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol. The change since the last review (1153 lines) was too large for a scoped follow-up, so this is a full review.

Comment thread packages/plugins/ai-search/CHANGELOG.md Outdated

### Minor Changes

- [#4071](https://github.com/emdash-cms/emdash/pull/4071) [`772838d`](https://github.com/emdash-cms/emdash/commit/772838d20a748a42d9e1c03ad94a992006745bef) Thanks [@ttmx](https://github.com/ttmx)! - Adds `@emdash-cms/plugin-ai-search`, a plugin that indexes published content and author profiles into Cloudflare AI Search and keeps the index current as content changes. Set it up from the admin wizard, then add the `AiSearch` Astro component to a layout for a search button and modal. Requires EmDash 1.0.1 or later, Cloudflare Workers, and an `ai_search_namespaces` binding. See the [AI Search plugin guide](https://docs.emdashcms.com/plugins/ai-search/).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[needs fixing] The introduction says Cloudflare Workers and an ai_search_namespaces binding are required. The same 0.1.0 release also supports Node.js and binding-free Workers through Cloudflare REST credentials, as the next bullet (#4310) explains. openProvider() in src/connection.ts implements that fallback, and the guide documents both connection methods. As written, the entry wrongly excludes supported deployments and contradicts the next bullet.

The anthropic reviewer raised this only as a prose note and referred to the existing thread, while the openai reviewer raised it as needs_fixing. This body follows the openai severity.

Merge .changeset/add-plugin-ai-search.md and .changeset/ai-search-rest-api.md on main into one introduction for the initial release. Present a Workers binding or Cloudflare REST credentials as alternative connection methods, and keep the REST setup and rate-limit guidance. Then regenerate this release PR.

@emdashbot emdashbot Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generating this release with Changesets is the right approach. Both reviewers approved with no open findings. Version bumps, consumed changesets, archive files and changelog header links follow the generated pattern. The previously open AI Search 0.1.0 finding is resolved: the initial-release entry is now a single introduction that presents a Workers binding or Cloudflare REST credentials as alternative connection methods. This matches openProvider() and the linked guide, and it no longer contradicts the REST fallback. This was a static review only; no tests or builds were run.


Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol. The change since the last review (1162 lines) was too large for a scoped follow-up, so this is a full review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant