Skip to content

Disable PostHog's swizzling. - #4964

Merged
pixlwave merged 1 commit into
developfrom
doug/posthog
Jan 16, 2026
Merged

pixlwave merged 1 commit into
developfrom
doug/posthog

Conversation

@pixlwave

@pixlwave pixlwave commented Jan 16, 2026 •

Copy link
Copy Markdown
Member

There's a new option available since PostHog/posthog-ios#388. As we only want to track the events provided by https://github.com/matrix-org/matrix-analytics-events and we aren't using any of the additional features swizzling brings, it seems reasonable to disable it.

We aren't using any of the features it brings anyway.
@pixlwave
pixlwave requested a review from a team as a code owner January 16, 2026 11:40
@pixlwave
pixlwave requested review from stefanceriu and removed request for a team January 16, 2026 11:40
@pixlwave pixlwave added the pr-misc for other changes label Jan 16, 2026

@stefanceriu stefanceriu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@pixlwave
pixlwave enabled auto-merge (squash) January 16, 2026 11:58
@codecov

codecov Bot commented Jan 16, 2026

Copy link
Copy Markdown

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
1151 3 1148 0
View the top 1 failed test(s) by shortest run time
StartChatScreenViewModelTests::testJoinRoomByAddressFailsBecauseNotFound()
Stack Traces | 10.1s run time
XCTUnwrap failed: expected non-nil value of type "Result<StartChatScreenViewState, Error>" - Awaited publisher did not produce any output (.../Other/Extensions/XCTestCase.swift:46)
View the full list of 2 ❄️ flaky test(s)
SecurityAndPrivacyScreenViewModelTests::testSingleUnknownSpaceMembersAccessCanBeReselected()

Flake rate in main: 38.71% (Passed 95 times, Failed 60 times)

Stack Traces | 0.014s run time
XCTAssertFalse failed (UnitTests/Sources/SecurityAndPrivacyScreenViewModelTests.swift:112)
UserSessionFlowCoordinatorTests::testShareMediaRouteWithRoom()

Flake rate in main: 32.41% (Passed 219 times, Failed 105 times)

Stack Traces | 1.96s run time
XCTAssertTrue failed (UnitTests/Sources/UserSessionFlowCoordinatorTests.swift:133)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@pixlwave
pixlwave disabled auto-merge January 16, 2026 15:30
@pixlwave
pixlwave merged commit 9131c09 into develop Jan 16, 2026
7 of 8 checks passed
@pixlwave
pixlwave deleted the doug/posthog branch January 16, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-misc for other changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants