Repository navigation
feat: add config option to disable swizzling - #388
Merged
Merged
Conversation
Contributor
Author
|
@marandaneto I'd like your take and thoughts on the following:
I’d like to respect the config option to disable swizzling altogether in our code. How would you handle session manager here? Options i see:
wdyt? |
marandaneto
reviewed
Oct 10, 2025
ioannisj
force-pushed
the
feat/disable-swizzling
branch
from
October 13, 2025 20:22
6af52e2 to
d43d48a
Compare
ioannisj
marked this pull request as ready for review
October 13, 2025 21:13
11 tasks
marandaneto
reviewed
Oct 14, 2025
marandaneto
reviewed
Oct 14, 2025
marandaneto
reviewed
Oct 14, 2025
marandaneto
approved these changes
Oct 14, 2025
marandaneto
left a comment
Member
There was a problem hiding this comment.
LGTM.
ps: just make sure the RN session replay plugin compiles and works correctly after the session manager changes
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Closes #362
Docs PR: PostHog/posthog.com#13204
💚 How did you test it?
📝 Checklist