Deleted r2s_loading_from_wfs_test.cpp from map downloader tests#86
Merged
akoerner1 merged 2 commits intoMar 23, 2026
Merged
Conversation
- Deleted because the test compared data from the test server, which is subject to frequent updates, to a static download done once at a specific point in time with the Python legacy.
- Every update of the R2S data on the test server would require a likewise update of the datasets dowloaded by the Python legacy (otherwise the test would not be meaningful, i.e. it would report a failed comparison on wrong grounds). This does not seem to be workable.
- Also, the test is dispensable:
- the remaining basic_map_loading_from_wfs_test still tests basic access to the test server
- one of the unit tests in adore_libraries/adore_map/test/ already tests the same for static R2S data (static because a cache is used): this is the test results_comparable_to_legacy_results
Signed-off-by: s0nofab1t <ruediger.ebendt@dlr.de>
Signed-off-by: s0nofab1t <ruediger.ebendt@dlr.de>
Contributor
Author
|
Thanks for your work on PR 7 of adore_map and for merging! I have now updated the hash of adore_libraries/adore_map. |
akoerner1
approved these changes
Mar 20, 2026
15 tasks
akoerner1
pushed a commit
that referenced
this pull request
Jun 12, 2026
## Description Deleted r2s_loading_from_wfs_test.cpp from map downloader tests, and updated two paths to reflect the latest structural changes. In detail: In ros2_workspace/src/adore_test_programs/adore_map_downloader_test/: - Deleted r2s_loading_from_wfs_test.cpp and two related resources (.json) under tracks/ from map downloader tests (had already been done in PR #86, however PR #92 mistakenly reintroduced the files) - Updated path in attribute "output" of config/r2s_wfs_config_bs.json (necessary due to structural changes in PR #92) - Updated configuration path in basic_map_loading_from_wfs_test.cpp (necessary due to structural changes in PR #92) ## Type of Change Please delete options that are not relevant: - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation update (adds or updates documentation) - [ ] Refactor (non-breaking change for code readability/structure) - [ ] Other (please describe): ## Checklist - [x] I have performed a self-review of my own code. - [x] I have signed and submitted the Eclipse Foundation Contributors Agreement: https://www.eclipse.org/legal/eca/. - [x] My last commit was made with the `--signoff` flag as required by the Eclipse Foundation. - [x] I have commented my code, particularly in hard-to-understand areas and provided a README.md when necessary. - [x] I have added tests that prove my fix is effective or that my feature works. - [ ] Tests pass locally with my changes: (run 'make test' on the ADORe project root to run unit tests). - [ ] I have updated the documentation in `documentation/technical_reference_manual` where necessary. - [ ] I have updated the `THIRD-PARTY.md` if I have introduced new third-party libraries or dependencies to the project. - [ ] I have updated the `CONTRIBUTERS.md` if I wish to acknowledged for my contribution. ## How Has This Been Tested? After building and 'make cli', add the password in adore/ros2_workspace/src/adore_test_programs/adore_map_downloader_test/config/r2s_wfs_config_bs.json. In adore/ros2_workspace/install/adore_map_downloader_test/bin, type './basic_map_loading_from_wfs_test' (without parameters). Along with the last few lines of output, you should see 'basic_map_loading_from_wfs_test: All tests passed successfully, good!' (which has been tested). **Test Configuration**: - OS: Ubuntu Noble Numbat - Docker Version: 29.3.1 Signed-off-by: s0nofab1t <ruediger.ebendt@dlr.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reason: The test compared R2S data from the test server, which is subject to frequent updates, to a static download done once at a specific point in time with the Python legacy. Every update of the R2S data on the test server would require a likewise update of the datasets dowloaded by the Python legacy (otherwise the test would not be meaningful, i.e. it would report a failed comparison on wrong grounds). This does not seem to be workable.
Also, the test is dispensable:
Remark: This PR is best merged after merging PR 7 of adore_map. After this has been done, the new hash of adore_map can already be updated here in this PR.
Type of Change
Please delete options that are not relevant:
Checklist
--signoffflag as required by the Eclipse Foundation.documentation/technical_reference_manualwhere necessary.THIRD-PARTY.mdif I have introduced new third-party libraries or dependencies to the project.CONTRIBUTERS.mdif I wish to acknowledged for my contribution.How Has This Been Tested?
Test Configuration:
Screenshots (if applicable)
Include any relevant screenshots or videos to demonstrate the feature/fix.
Related Issues
Best merged after PR 7 of adore_map, another bugfix in adore_map.
Notes for Reviewers
This PR is best merged after merging PR 7 of adore_map. After this has been done, the new hash of adore_map can already be updated here in this PR.