Skip to content

Deleted r2s_loading_from_wfs_test.cpp from map downloader tests#86

Merged
akoerner1 merged 2 commits into
eclipse-adore:developfrom
s0nofab1t:bugfix/wfs-downloader
Mar 23, 2026
Merged

Deleted r2s_loading_from_wfs_test.cpp from map downloader tests#86
akoerner1 merged 2 commits into
eclipse-adore:developfrom
s0nofab1t:bugfix/wfs-downloader

Conversation

@s0nofab1t

Copy link
Copy Markdown
Contributor

Description

  • Deleted r2s_loading_from_wfs_test.cpp from map downloader tests

Reason: The test compared R2S data from the test server, which is subject to frequent updates, to a static download done once at a specific point in time with the Python legacy. Every update of the R2S data on the test server would require a likewise update of the datasets dowloaded by the Python legacy (otherwise the test would not be meaningful, i.e. it would report a failed comparison on wrong grounds). This does not seem to be workable.

Also, the test is dispensable:

  • the remaining basic_map_loading_from_wfs_test still tests basic access to the test server.
  • one of the unit tests in adore/adore_libraries/adore_map/test/ already tests the same for static R2S data (static because a cache is used): this is the test results_comparable_to_legacy_results.

Remark: This PR is best merged after merging PR 7 of adore_map. After this has been done, the new hash of adore_map can already be updated here in this PR.

Type of Change

Please delete options that are not relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (adds or updates documentation)
  • Refactor (non-breaking change for code readability/structure)
  • Other (please describe):

Checklist

  • I have performed a self-review of my own code.
  • I have signed and submitted the Eclipse Foundation Contributors Agreement: https://www.eclipse.org/legal/eca/.
  • My last commit was made with the --signoff flag as required by the Eclipse Foundation.
  • I have commented my code, particularly in hard-to-understand areas and provided a README.md when necessary.
  • I have added tests that prove my fix is effective or that my feature works.
  • Tests pass locally with my changes: (run 'make test' on the ADORe project root to run unit tests).
  • I have updated the documentation in documentation/technical_reference_manual where necessary.
  • I have updated the THIRD-PARTY.md if I have introduced new third-party libraries or dependencies to the project.
  • I have updated the CONTRIBUTERS.md if I wish to acknowledged for my contribution.

How Has This Been Tested?

  • Unit tests for the new feature WFS-downloader had already been added before (see adore/adore_libraries/adore_map/test/adore_map_downloader_cache_test.cpp). These tests have been used again (they succeed).
  • A standalone test testing the basic functionality with an actual test server had already been added before (see adore/adore_test_programs/adore_map_downloader_test/basic_map_loading_from:_wfs_test.cpp): This test has been used again (it succeeds).

Test Configuration:

  • OS: Ubuntu linux (Noble Numbat)
  • Docker Version: 28.4.0

Screenshots (if applicable)

Include any relevant screenshots or videos to demonstrate the feature/fix.

Related Issues

Best merged after PR 7 of adore_map, another bugfix in adore_map.

Notes for Reviewers

This PR is best merged after merging PR 7 of adore_map. After this has been done, the new hash of adore_map can already be updated here in this PR.

  - Deleted because the test compared data from the test server, which is subject to frequent updates, to a static download done once at a specific point in time with the Python legacy.
    - Every update of the R2S data on the test server would require a likewise update of the datasets dowloaded by the Python legacy (otherwise the test would not be meaningful, i.e. it would report a failed comparison on wrong grounds). This does not seem to be workable.

  - Also, the test is dispensable:
    - the remaining basic_map_loading_from_wfs_test still tests basic access to the test server
    - one of the unit tests in adore_libraries/adore_map/test/ already tests the same for static R2S data (static because a cache is used): this is the test results_comparable_to_legacy_results

Signed-off-by: s0nofab1t <ruediger.ebendt@dlr.de>
@akoerner1 akoerner1 self-requested a review March 19, 2026 20:46
Signed-off-by: s0nofab1t <ruediger.ebendt@dlr.de>
@s0nofab1t

Copy link
Copy Markdown
Contributor Author

Thanks for your work on PR 7 of adore_map and for merging!

I have now updated the hash of adore_libraries/adore_map.

@akoerner1 akoerner1 merged commit 8deff0c into eclipse-adore:develop Mar 23, 2026
3 checks passed
akoerner1 pushed a commit that referenced this pull request Jun 12, 2026
## Description

Deleted r2s_loading_from_wfs_test.cpp from map downloader tests, and
updated two paths to reflect the latest structural changes.

In detail:

In ros2_workspace/src/adore_test_programs/adore_map_downloader_test/:

- Deleted r2s_loading_from_wfs_test.cpp and two related resources
(.json) under tracks/ from map downloader tests (had already been done
in PR #86, however PR #92 mistakenly reintroduced the files)
- Updated path in attribute "output" of config/r2s_wfs_config_bs.json
(necessary due to structural changes in PR #92)
- Updated configuration path in basic_map_loading_from_wfs_test.cpp
(necessary due to structural changes in PR #92)

## Type of Change

Please delete options that are not relevant:

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Documentation update (adds or updates documentation)
- [ ] Refactor (non-breaking change for code readability/structure)
- [ ] Other (please describe):

## Checklist

- [x] I have performed a self-review of my own code.
- [x] I have signed and submitted the Eclipse Foundation Contributors
Agreement: https://www.eclipse.org/legal/eca/.
- [x] My last commit was made with the `--signoff` flag as required by
the Eclipse Foundation.
- [x] I have commented my code, particularly in hard-to-understand areas
and provided a README.md when necessary.
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [ ] Tests pass locally with my changes: (run 'make test' on the ADORe
project root to run unit tests).
- [ ] I have updated the documentation in
`documentation/technical_reference_manual` where necessary.
- [ ] I have updated the `THIRD-PARTY.md` if I have introduced new
third-party libraries or dependencies to the project.
- [ ] I have updated the `CONTRIBUTERS.md` if I wish to acknowledged for
my contribution.

## How Has This Been Tested?

After building and 'make cli', add the password in
adore/ros2_workspace/src/adore_test_programs/adore_map_downloader_test/config/r2s_wfs_config_bs.json.
In adore/ros2_workspace/install/adore_map_downloader_test/bin, type
'./basic_map_loading_from_wfs_test' (without parameters). Along with the
last few lines of output, you should see
'basic_map_loading_from_wfs_test: All tests passed successfully, good!'
(which has been tested).

**Test Configuration**:
- OS: Ubuntu Noble Numbat
- Docker Version: 29.3.1

Signed-off-by: s0nofab1t <ruediger.ebendt@dlr.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants