Skip to content

fix: rethrow DeFindex errors in resolvePositions instead of returning partial data #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
collinsezedike merged 1 commit into from
Jun 25, 2026
Merged

fix: rethrow DeFindex errors in resolvePositions instead of returning partial data #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/stellar-sdk-helpers/src/orchestration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,9 +151,8 @@ describe("resolvePositions", () => {
expect(positions).toEqual([BLEND_USDC]);
});

it("returns Blend positions even when the DeFindex fetch throws", async () => {
it("propagates DeFindex fetch errors to the caller", async () => {
vi.mocked(fetchDefindexPosition).mockRejectedValueOnce(new Error("RPC down"));
const positions = await resolvePositions(WALLET, network, addresses);
expect(positions).toEqual([BLEND_USDC]);
await expect(resolvePositions(WALLET, network, addresses)).rejects.toThrow("RPC down");
});
});
11 changes: 3 additions & 8 deletions packages/stellar-sdk-helpers/src/orchestration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ export async function buildDepositTx(

/**
* Fetches all positions for `publicKey` across Blend reserves and (optionally)
* the DeFindex vault. The DeFindex call is isolated — a failure there is logged
* and swallowed so the Blend positions are always returned.
* the DeFindex vault. Errors from either protocol propagate to the caller.
*/
export async function resolvePositions(
publicKey: string,
Expand All @@ -52,12 +51,8 @@ export async function resolvePositions(
]);

if (addresses.defindexVault) {
try {
const dfx = await fetchDefindexPosition(network, addresses.defindexVault, "defindex-usdc", publicKey);
positions.push(...dfx);
} catch (err) {
console.warn("[positions] defindex read failed:", err);
}
const dfx = await fetchDefindexPosition(network, addresses.defindexVault, "defindex-usdc", publicKey);
positions.push(...dfx);
}

return positions;
Expand Down